Re: [OS-BUILD PATCH 0/0] Add support for rh_flags to kernel-ark
From: Jiri Benc on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3070#note_1871493816
Please bring the pieces of the last commit ("rh_flags: Fix of build errors and
warnings") to the individual commits. While some projects do such cumulative
fixes at the end of a MR, we prefer long-time maintainability for the kernel.
--
___
kernel mailing list -- kernel@lists.fedoraproject.org
To unsubscribe send an email to kernel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org
Do not reply to spam, report it:
https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] Add support for rh_flags to kernel-ark
From: Ricardo Robaina on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3070#note_1871407358 Hi Scott, Thanks for reviewing this MR! I've moved `rh_flags.o` to `obj-$(CONFIG_RHEL_DIFFERENCES)` line in v2. Please, let me know if there's anything else to adjust. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
Re: [OS-BUILD PATCH 0/0] Add support for rh_flags to kernel-ark
From: Ricardo Robaina on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3070#note_1871400114 Hi Justin, Thanks for reviewing this MR! I just hid `rh_print_flags()` behind `#ifdef CONFIG_RHEL_DIFFERENCES`. Please, let me know if there's anything else to adjust. -- ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email to kernel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
