radix_tree_next_chunk: redundant search for next slot in hole

2019-05-03 Thread Probir Roy
Hi, I am running Phoronix-fio benchmark on Linux kernel 4.18.0-rc5. I observe that radix_tree_next_chunk search shows some form of a redundant walk while called from radix_tree_for_each_slot iterator. While searching for next slot in a hole, it walks through the same slots over n over. void

Re: radix_tree_next_chunk: redundant search for next slot in hole

2019-05-03 Thread Probir Roy
> > While searching for next slot in a hole, it walks through the same > > slots over n over. > > How did you determine this? I am working on a tool that identifies repeated load of an address. Often these repeated loads are redundant and can be avoided with data structure modification. The tool

Re: radix_tree_next_chunk: redundant search for next slot in hole

2019-05-03 Thread Valdis Klētnieks
On Fri, 03 May 2019 16:03:46 -0500, Probir Roy said: > While searching for next slot in a hole, it walks through the same > slots over n over. How did you determine this? > while (++offset < RADIX_TREE_MAP_SIZE) { > void *slot = rcu_dereference_raw( /* redundant

Re: radix_tree_next_chunk: redundant search for next slot in hole

2019-05-03 Thread Valdis Klētnieks
On Fri, 03 May 2019 19:00:26 -0500, Probir Roy said: > > > While searching for next slot in a hole, it walks through the same > > > slots over n over. > > > > How did you determine this? > > I am working on a tool that identifies repeated load of an address. > Often these repeated loads are

Re: Page Allocation Failure and Page allocation stalls

2019-05-03 Thread Pankaj Suryawanshi
On Thu, May 2, 2019 at 10:51 AM Valdis Klētnieks wrote: > > On Thu, 02 May 2019 04:56:05 +0530, Pankaj Suryawanshi said: > > > Please help me to decode the error messages and reason for this errors. > > > [ 3205.818891] HwBinder:1894_6: page allocation failure: order:7, > >