Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon)

2020-08-21 Thread Joe Perches
(forwarding on to kernel-janitors/mentees and kernelnewbies) Just fyi for anyone that cares: A janitorial task for someone might be to use Julia's coccinelle script below to convert the existing instances of commas that separate statements into semicolons.

Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon)

2020-08-21 Thread Valdis Klētnieks
On Fri, 21 Aug 2020 18:08:08 -0700, Joe Perches said: > (forwarding on to kernel-janitors/mentees and kernelnewbies) > > Just fyi for anyone that cares: > > A janitorial task for someone might be to use Julia's coccinelle > script below to convert the existing instances of commas that > separate

Re: [Cocci] coccinelle: Convert comma to semicolons (was Re: [PATCH] checkpatch: Add test for comma use that should be semicolon)

2020-08-21 Thread Joe Perches
On Fri, 2020-08-21 at 23:35 -0400, Valdis Klētnieks wrote: > On Fri, 21 Aug 2020 18:08:08 -0700, Joe Perches said: > > (forwarding on to kernel-janitors/mentees and kernelnewbies) > > > > Just fyi for anyone that cares: > > > > A janitorial task for someone might be to use Julia's coccinelle > >

Re: How to pass flag from makefile to preprocesor when building external kernel module

2020-08-21 Thread Tomek The Messenger
OK, problem solved. The issue was that preprocesor directive in c: #elseif doesn't work. I don't know why but I replaced this with #ifdef ... #endif and #ifdef ... #endif instead of using #elseif in the middle and everything works. On Fri, Aug 21, 2020 at 10:01 AM Tomek The Messenger <

How to pass flag from makefile to preprocesor when building external kernel module

2020-08-21 Thread Tomek The Messenger
Hi I have problem with passing flag from makefile to .c file. During building external kernel module my macro isn't seen by compiler. I used plenty of ways. First way: ccflags-y += -DMY_FLAG $(MAKE) -C $(KERNEL_SRC) M=$(SRC) Second: $(MAKE) -C $(KERNEL_SRC) M=$(SRC)