Re: Fwd: Need guidance regarding fixing styleguide error in rtl871x_pwrctrl.h

2022-02-09 Thread Jeffrey Walton
On Wed, Feb 9, 2022 at 11:36 AM Valdis Klētnieks wrote: > ... > It turns out that the C keyword 'volatile' usually doesn't actually do what > needs to happen if a variable actually *is* volatile and subject to change > while the executing thread isn't looking. > > There's a good documentation

Re: Fwd: Need guidance regarding fixing styleguide error in rtl871x_pwrctrl.h

2022-02-09 Thread Ankit Pandey
Thanks a lot Valdis. These are very helpful pointers to look into. Regards, Ankit On Wed, Feb 9, 2022 at 10:06 PM Valdis Klētnieks wrote: > On Tue, 08 Feb 2022 23:26:54 +0530, Ankit Pandey said: > > > And I was asked to verify if there is some specific meaning is attached > to > > comment here

Re: Fwd: Need guidance regarding fixing styleguide error in rtl871x_pwrctrl.h

2022-02-09 Thread Valdis Klētnieks
On Tue, 08 Feb 2022 23:26:54 +0530, Ankit Pandey said: > And I was asked to verify if there is some specific meaning is attached to > comment here (which was causing the issue). > I would be glad you could explain me how should I approach this issue? One > way would > be to rewrite that these

Re: Need guidance regarding fixing styleguide error in rtl871x_pwrctrl.h

2022-02-09 Thread Lukas Bulwahn
On Wed, Feb 9, 2022 at 4:15 AM Ankit Pandey wrote: > > > Hello, > I had submitted following patch: > > ``` > --- > drivers/staging/rtl8712/rtl871x_pwrctrl.h | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_pwrctrl.h >