On Thu, Mar 26, 2020 at 04:01:18PM +0300, Konstantin Andreev wrote:
> Valdis Klētnieks, 26 Mar 2020 07:13 MSK:
> > Don't split literal strings, it means that grepping the source tree for
> > "already registered" fails. Making grep for a string work is more important
> > than shutting up
Valdis Klētnieks, 26 Mar 2020 07:13 MSK:
Don't split literal strings, it means that grepping the source tree for "already
registered" fails. Making grep for a string work is more important than shutting up
checkpatch.
On Thu, Mar 26, 2020 at 02:36:23PM +0300, Konstantin Andreev wrote:
Sic!
On Thu, Mar 26, 2020 at 02:36:23PM +0300, Konstantin Andreev wrote:
> Valdis Klētnieks, 26 Mar 2020 07:13 MSK:
> >
> > To borrow from Pirates of the Carribean, "They're not exactly rules,
> > they're more like... suggestions..."
> >
> > Don't split literal strings, it means that grepping the
Valdis Klētnieks, 26 Mar 2020 07:13 MSK:
To borrow from Pirates of the Carribean, "They're not exactly rules, they're more
like... suggestions..."
Don't split literal strings, it means that grepping the source tree for "already
registered" fails. Making grep for a string work is more
On Wed, Mar 25, 2020 at 9:38 AM Tomek The Messenger <
tomekthemessen...@gmail.com> wrote:
> Hi
> There is checkpatch.pl script where You can check if You wrote code in
> your kernel module according to linux kernel style.
> However can I ignore warning message?
> WARNING: quoted string split
On Wed, 25 Mar 2020 10:36:08 +0100, Tomek The Messenger said:
> There is checkpatch.pl script
To borrow from Pirates of the Carribean, "They're not exactly rules, they're
more like... suggestions..."
Checkpatch flags *possible* code style problems, but it's not perfect. There's
often good
On Wed, Mar 25, 2020 at 10:36:08AM +0100, Tomek The Messenger wrote:
> Hi
> There is checkpatch.pl script where You can check if You wrote code in your
> kernel module according to linux kernel style.
> However can I ignore warning message?
> WARNING: quoted string split across lines
> #974: FILE:
Hi
There is checkpatch.pl script where You can check if You wrote code in your
kernel module according to linux kernel style.
However can I ignore warning message?
WARNING: quoted string split across lines
#974: FILE: fpgax67-core.c:974:
+ dev_err(>dev, "registration not done, driver
