Hi,
I'm planning to submit this cleanup patch but I would appreciate if some
of you could consider reviewing it first as this is my first patch.
Also, when it comes to whom to send it to, this is the list I got so far but
please let me know if I should either add or exclude anyone from this
list so that I send this patch to the right people while not spamming others.
./scripts/get_maintainer.pl
/tmp/0001-staging-rtl8192u-specify-printk-s-KERN_-LEVEL-in-iee.patch
Greg Kroah-Hartman <gre...@linuxfoundation.org> (supporter:STAGING
SUBSYSTEM,commit_signer:17/18=94%)
Puranjay Mohan <puranja...@gmail.com> (commit_signer:4/18=22%,authored:4/18=22%)
Stephen Brennan <step...@brennan.io>
(commit_signer:4/18=22%,authored:4/18=22%,added_lines:297/366=81%,removed_lines:388/470=83%)
Bhanusree Pola <bhanusreemah...@gmail.com>
(commit_signer:3/18=17%,authored:3/18=17%)
Sanjana Sanikommu <sanjana99redd...@gmail.com>
(commit_signer:2/18=11%,authored:2/18=11%)
Vatsala Narang <vatsalanar...@gmail.com> (authored:1/18=6%)
de...@driverdev.osuosl.org (open list:STAGING SUBSYSTEM)
linux-ker...@vger.kernel.org (open list)
The origin commit message follows
Checkpatch reports 'WARNING: printk() should include KERN_<LEVEL>
facility level'. Fix this by specifying a relevant KERN_<LEVEL> value
for each line in which it was missing.
Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rode...@gmail.com>
---
.../staging/rtl8192u/ieee80211/ieee80211_rx.c | 24 +++++++++----------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index 00fea127bdc3..f38986d74005 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -810,11 +810,11 @@ static u8 parse_subframe(struct sk_buff *skb,
nSubframe_Length = (nSubframe_Length >> 8) +
(nSubframe_Length << 8);
if (skb->len < (ETHERNET_HEADER_SIZE +
nSubframe_Length)) {
- printk("%s: A-MSDU parse error!!
pRfd->nTotalSubframe : %d\n",\
+ printk(KERN_DEBUG "%s: A-MSDU parse error!!
pRfd->nTotalSubframe : %d\n",
__func__, rxb->nr_subframes);
- printk("%s: A-MSDU parse error!! Subframe
Length: %d\n", __func__, nSubframe_Length);
- printk("nRemain_Length is %d and
nSubframe_Length is : %d\n", skb->len, nSubframe_Length);
- printk("The Packet SeqNum is %d\n", SeqNum);
+ printk(KERN_DEBUG "%s: A-MSDU parse error!!
Subframe Length: %d\n", __func__, nSubframe_Length);
+ printk(KERN_DEBUG "nRemain_Length is %d and
nSubframe_Length is : %d\n", skb->len, nSubframe_Length);
+ printk(KERN_DEBUG "The Packet SeqNum is %d\n",
SeqNum);
return 0;
}
@@ -919,7 +919,7 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct
sk_buff *skb,
if (HTCCheck(ieee, skb->data)) {
if (net_ratelimit())
- printk("find HTCControl\n");
+ printk(KERN_WARNING "find HTCControl\n");
hdrlen += 4;
rx_stats->bContainHTC = true;
}
@@ -1113,7 +1113,7 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct
sk_buff *skb,
if (ieee->host_decrypt && (fc & IEEE80211_FCTL_WEP) &&
(keyidx = ieee80211_rx_frame_decrypt(ieee, skb, crypt)) < 0) {
- printk("decrypt frame error\n");
+ printk(KERN_WARNING "decrypt frame error\n");
goto rx_dropped;
}
@@ -1178,7 +1178,7 @@ int ieee80211_rx(struct ieee80211_device *ieee, struct
sk_buff *skb,
* encrypted/authenticated */
if (ieee->host_decrypt && (fc & IEEE80211_FCTL_WEP) &&
ieee80211_rx_frame_decrypt_msdu(ieee, skb, keyidx, crypt)) {
- printk("==>decrypt msdu error\n");
+ printk(KERN_WARNING "==>decrypt msdu error\n");
goto rx_dropped;
}
@@ -1863,7 +1863,7 @@ int ieee80211_parse_info_param(struct ieee80211_device
*ieee,
info_element->data[0] == 0x00 &&
info_element->data[1] == 0x13 &&
info_element->data[2] == 0x74)) {
- printk("========>%s(): athros AP is exist\n",
__func__);
+ printk(KERN_DEBUG "========>%s(): athros AP is
exist\n", __func__);
network->atheros_cap_exist = true;
} else
network->atheros_cap_exist = false;
@@ -2357,14 +2357,14 @@ static inline void ieee80211_process_probe_response(
if (IS_COUNTRY_IE_VALID(ieee)) {
// Case 1: Country code
if (!is_legal_channel(ieee, network->channel)) {
- printk("GetScanInfo(): For Country
code, filter probe response at channel(%d).\n", network->channel);
+ printk(KERN_WARNING "GetScanInfo(): For
Country code, filter probe response at channel(%d).\n", network->channel);
goto out;
}
} else {
// Case 2: No any country code.
// Filter over channel ch12~14
if (network->channel > 11) {
- printk("GetScanInfo(): For Global
Domain, filter probe response at channel(%d).\n", network->channel);
+ printk(KERN_WARNING "GetScanInfo(): For
Global Domain, filter probe response at channel(%d).\n", network->channel);
goto out;
}
}
@@ -2372,14 +2372,14 @@ static inline void ieee80211_process_probe_response(
if (IS_COUNTRY_IE_VALID(ieee)) {
// Case 1: Country code
if (!is_legal_channel(ieee, network->channel)) {
- printk("GetScanInfo(): For Country
code, filter beacon at channel(%d).\n", network->channel);
+ printk(KERN_WARNING "GetScanInfo(): For
Country code, filter beacon at channel(%d).\n", network->channel);
goto out;
}
} else {
// Case 2: No any country code.
// Filter over channel ch12~14
if (network->channel > 14) {
- printk("GetScanInfo(): For Global
Domain, filter beacon at channel(%d).\n", network->channel);
+ printk(KERN_WARNING "GetScanInfo(): For
Global Domain, filter beacon at channel(%d).\n", network->channel);
goto out;
}
}
--
2.24.1
_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies
