[PATCH v10] x86, apic, kexec, Documentation: Add disable_cpu_apic kernel parameter

2013-12-04 Thread HATAYAMA Daisuke
This patch set is to allow kdump 2nd kernel to wake up multiple CPUs, a continueing work from: [PATCH v3 0/2] x86, apic, kdump: Disable BSP if boot cpu is AP https://lkml.org/lkml/2013/10/16/300. At v4, basic design has changed. Now users need to figure out initial APIC ID of BSP in the 1st

Re: [PATCH] vmcore: call remap_pfn_range() separately for respective partial pages

2013-12-04 Thread HATAYAMA Daisuke
(2013/12/04 0:12), Vivek Goyal wrote: On Tue, Dec 03, 2013 at 02:16:35PM +0900, HATAYAMA Daisuke wrote: [..] Even if copying partial pages into the 2nd kernel, we need to use ioremap() once on them, and I think the ioremap() is exactly similar to remap_pfn_range() for a single page. There

Re: [PATCH v4 07/12] efi: passing kexec necessary efi data via setup_data

2013-12-04 Thread Toshi Kani
On Wed, 2013-12-04 at 10:46 +0800, Dave Young wrote: Hi, Toshi Oh, I think I now understand what the issue was. The z420 firmware updates the SMBIOS table address in the EFI system table to a virtual address after calling EFI SetVirtualAddressMap. So, you are passing the original

Re: [PATCH 4/6] kexec: A new system call, kexec_file_load, for in kernel kexec

2013-12-04 Thread Vivek Goyal
On Wed, Dec 04, 2013 at 09:35:29AM +0800, Baoquan He wrote: On 12/02/13 at 10:44am, Vivek Goyal wrote: On Fri, Nov 29, 2013 at 11:10:48AM +0800, Baoquan He wrote: [..] +void *arch_kexec_kernel_image_load(struct kimage *image, char *kernel, + unsigned long

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-04 Thread Vivek Goyal
On Wed, Dec 04, 2013 at 09:41:05AM +0800, Baoquan He wrote: On 11/20/13 at 12:50pm, Vivek Goyal wrote: This patch adds support for loading a kexec on panic (kdump) kernel usning new system call. +int load_crashdump_segments(struct kimage *image) +{ + unsigned long src_start, src_sz;

Re: [PATCH 6/6] kexec: Support for Kexec on panic using new system call

2013-12-04 Thread Vivek Goyal
On Wed, Dec 04, 2013 at 09:51:27AM +0800, Baoquan He wrote: On 12/02/13 at 10:30am, Vivek Goyal wrote: On Thu, Nov 28, 2013 at 07:28:16PM +0800, Baoquan He wrote: [..] +int crash_copy_backup_region(struct kimage *image) +{ Why need this func be called, backup region has been

Re: [PATCH 4/6] kexec: A new system call, kexec_file_load, for in kernel kexec

2013-12-04 Thread Vivek Goyal
On Wed, Dec 04, 2013 at 09:56:57AM +0800, Baoquan He wrote: On 11/20/13 at 12:50pm, Vivek Goyal wrote: + * that kexec_mutex is held. + */ I think kexec_add_buffer is guaranteed to be called before allocating control pages, why not updating image-control_page after each time

Re: [PATCH v9] x86, apic, kexec, Documentation: Add disable_cpu_apic kernel parameter

2013-12-04 Thread Vivek Goyal
On Wed, Dec 04, 2013 at 03:24:43PM +0900, HATAYAMA Daisuke wrote: (2013/12/04 12:08), HATAYAMA Daisuke wrote: (2013/12/04 0:25), Vivek Goyal wrote: On Tue, Dec 03, 2013 at 10:32:26AM +0900, HATAYAMA Daisuke wrote: [..] diff --git a/Documentation/kernel-parameters.txt

Re: [PATCH 0/6] kexec: A new system call to allow in kernel loading

2013-12-04 Thread Vivek Goyal
On Fri, Nov 22, 2013 at 07:23:39PM -0800, Eric W. Biederman wrote: [..] There is also a huge missing piece of this in that your purgatory is not checking a hash of the loaded image before jumping too it. Without that this is a huge regression at least for the kexec on panic case. We

Re: [PATCH v10] x86, apic, kexec, Documentation: Add disable_cpu_apic kernel parameter

2013-12-04 Thread Vivek Goyal
On Wed, Dec 04, 2013 at 05:10:58PM +0900, HATAYAMA Daisuke wrote: This patch set is to allow kdump 2nd kernel to wake up multiple CPUs, a continueing work from: [PATCH v3 0/2] x86, apic, kdump: Disable BSP if boot cpu is AP https://lkml.org/lkml/2013/10/16/300. At v4, basic design has

Re: [PATCH v4 07/12] efi: passing kexec necessary efi data via setup_data

2013-12-04 Thread Dave Young
On 12/04/13 at 09:43am, Toshi Kani wrote: On Wed, 2013-12-04 at 10:46 +0800, Dave Young wrote: Hi, Toshi Oh, I think I now understand what the issue was. The z420 firmware updates the SMBIOS table address in the EFI system table to a virtual address after calling EFI

Re: [PATCH 0/6] kexec: A new system call to allow in kernel loading

2013-12-04 Thread Eric W. Biederman
Vivek Goyal vgo...@redhat.com writes: Hi Eric, So you want a separate purgatory code and that purgatory should be self contained and should not share any code with rest of the kernel. No inclusion of header files, no linking against kernel libraries? That means even re-implementing sha256