Re: [PATCH] makedumpfile: Fix string append in dump_log_entry()

2014-03-04 Thread Petr Tesarik
On Fri, 28 Feb 2014 01:01:33 + Atsushi Kumagai kumagai-atsu...@mxc.nes.nec.co.jp wrote: Hello Petr, Hello Kumagai-san, To quote the sprintf(3) man page: Some programs imprudently rely on code such as the following sprintf(buf, %s some further text, buf); to append

Re: PATCH: bug in locate_hole()

2014-03-04 Thread Matthew Fleming
On Mon, Mar 3, 2014 at 8:03 PM, Simon Horman ho...@verge.net.au wrote: Thanks Matthew. Could you provide a signed-off-by line? I'm not sure what that would look like. Do I sign off on my own patch? Thanks, matthew On Mon, Mar 03, 2014 at 04:34:35PM -0800, Matthew Fleming wrote: In

Re: [PATCHv3 3/6] Crashdump-Accepting-Active-IOMMU-Domain-Interfaces

2014-03-04 Thread Joerg Roedel
On Fri, Jan 10, 2014 at 03:07:29PM -0700, Bill Sumner wrote: +context_get_entry(struct context_entry *context_addr, + struct intel_iommu *iommu, u32 bus, int devfn) +{ + unsigned long long q; /* quadword scratch */ + struct root_entry *root_phys; /*

Re: [PATCHv3 0/6] Crashdump Accepting Active IOMMU

2014-03-04 Thread Joerg Roedel
Hi Bill, On Fri, Jan 10, 2014 at 03:07:26PM -0700, Bill Sumner wrote: Bill Sumner (6): Crashdump-Accepting-Active-IOMMU-Flags-and-Prototype Crashdump-Accepting-Active-IOMMU-Utility-functions Crashdump-Accepting-Active-IOMMU-Domain-Interfaces

Re: PATCH: bug in locate_hole()

2014-03-04 Thread Baoquan He
On 03/04/14 at 06:55am, Matthew Fleming wrote: On Mon, Mar 3, 2014 at 8:03 PM, Simon Horman ho...@verge.net.au wrote: Thanks Matthew. Could you provide a signed-off-by line? I'm not sure what that would look like. Do I sign off on my own patch? Thanks, matthew It's a convention for

Re: PATCH: bug in locate_hole()

2014-03-04 Thread Matthew Fleming
On Mon, Mar 3, 2014 at 4:34 PM, Matthew Fleming mdf...@gmail.com wrote: In upgrading to kexec-tools 2.0.5 I first got the error Overlapping memory segments at 0xbeff000 Adding some debugging I found locate_hole was returning incorrect values. The below is from the debug I added: XXXMDF:

RE: [PATCH 00/10] makedumpfile/eppic: Sample eppic scripts

2014-03-04 Thread Atsushi Kumagai
Hello Aruna, The series has few sample eppic scripts to scrub the security data. --- Aruna Balakrishnaiah (10): Scrub executable name for each user process Scrub filenames of cached dentries Scrub all entries in the keyring Clear the message data of all ap_bus requests

RE: [PATCH 10/10] Install sample eppic scripts

2014-03-04 Thread Atsushi Kumagai
Install sample eppic scripts in the documentation directory Signed-off-by: Aruna Balakrishnaiah ar...@linux.vnet.ibm.com --- Makefile |1 + makedumpfile.spec |3 +++ 2 files changed, 4 insertions(+) diff --git a/Makefile b/Makefile index 10178ba..6e8e9b9 100644 --- a/Makefile

RE: makedumpfile: optimize is_zero_page

2014-03-04 Thread Atsushi Kumagai
Hello Marc, There are local complaints that filtering out only zero pages is slow. I found that is_zero_page was inefficient. It checks if the page contains any non-zero bytes - one byte at a time. Improve performance by checking for non-zero data 64 bits at a time. Also, unroll the loop for

Re: How could we get rid of saved_max_pfn for calgary iommu?

2014-03-04 Thread WANG Chao
[ Add Muli, I find his new email in git log] Hi, Muli saved_max_pfn is becoming a setback for kexec-tools. Ideally calgary could get rid of saved_max_pfn at all. But If this can't work, how about exporting a calgary tce table size to user space, so that kexec-tools can simply pass calgary=xxx