Re: [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump

2018-06-21 Thread Baoquan He
On 06/21/18 at 08:12am, Tom Lendacky wrote: > On 6/21/2018 3:39 AM, Baoquan He wrote: > > On 06/21/18 at 01:42pm, lijiang wrote: > >> 在 2018年06月21日 00:42, Tom Lendacky 写道: > >>> On 6/16/2018 3:27 AM, Lianbo Jiang wrote: > In kdump mode, it will copy the device table of IOMMU from the old > >>>

Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled

2018-06-21 Thread Baoquan He
On 06/21/18 at 09:27pm, lijiang wrote: > 在 2018年06月21日 18:23, Baoquan He 写道: > > On 06/21/18 at 01:06pm, lijiang wrote: > >> 在 2018年06月21日 09:53, Baoquan He 写道: > >>> On 06/16/18 at 04:27pm, Lianbo Jiang wrote: > When SME is enabled in the first kernel, we will allocate pages > for kdump

Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled

2018-06-21 Thread lijiang
在 2018年06月21日 18:23, Baoquan He 写道: > On 06/21/18 at 01:06pm, lijiang wrote: >> 在 2018年06月21日 09:53, Baoquan He 写道: >>> On 06/16/18 at 04:27pm, Lianbo Jiang wrote: When SME is enabled in the first kernel, we will allocate pages for kdump without encryption in order to be able to boot the

Re: [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump

2018-06-21 Thread Tom Lendacky
On 6/21/2018 3:39 AM, Baoquan He wrote: > On 06/21/18 at 01:42pm, lijiang wrote: >> 在 2018年06月21日 00:42, Tom Lendacky 写道: >>> On 6/16/2018 3:27 AM, Lianbo Jiang wrote: In kdump mode, it will copy the device table of IOMMU from the old device table, which is encrypted when SME is enabled i

[PATCH v4 1/2] dt-ops: Add helper API to dump fdt blob

2018-06-21 Thread Bhupesh Sharma
At several occasions it would be useful to dump the fdt blob being passed to the second (kexec/kdump) kernel when '-d' flag is specified while invoking kexec/kdump. This allows one to look at the device-tree fields that is being passed to the secondary kernel and accordingly debug issues. This ca

[PATCH v4 2/2] kexec-arm64: Add functionality to dump 2nd dtb

2018-06-21 Thread Bhupesh Sharma
Since during the arm64 kexec_load()/kdump invocation, the dtb is passed to the second kernel, it is sometimes useful to dump the dtb contents (to verify the correctness of the same). This patch adds this feature which is enabled when '-d' flag is used with kexec command line invocation. Signed-of

[PATCH v4 0/2] Add capability to dump fdt blob for arm64 platforms

2018-06-21 Thread Bhupesh Sharma
Changes since v3: - Addressed comments from Akashi regarding: ~ Using sensible names for variables and pointers. ~ Removing usage of local pointer variable in 'dump_fdt()' function. ~ Tried addressing a comment regarding converting GET_CELL macro to inline function,

Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled

2018-06-21 Thread Baoquan He
On 06/21/18 at 01:06pm, lijiang wrote: > 在 2018年06月21日 09:53, Baoquan He 写道: > > On 06/16/18 at 04:27pm, Lianbo Jiang wrote: > >> When SME is enabled in the first kernel, we will allocate pages > >> for kdump without encryption in order to be able to boot the > >> second kernel in the same manner a

Re: [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump

2018-06-21 Thread lijiang
在 2018年06月21日 16:39, Baoquan He 写道: > On 06/21/18 at 01:42pm, lijiang wrote: >> 在 2018年06月21日 00:42, Tom Lendacky 写道: >>> On 6/16/2018 3:27 AM, Lianbo Jiang wrote: In kdump mode, it will copy the device table of IOMMU from the old device table, which is encrypted when SME is enabled in th

Re: [PATCH 1/4 V3] Add a function(ioremap_encrypted) for kdump when AMD sme enabled

2018-06-21 Thread lijiang
在 2018年06月21日 00:00, Tom Lendacky 写道: > On 6/16/2018 3:27 AM, Lianbo Jiang wrote: >> It is convenient to remap the old memory encrypted to the second >> kernel by calling ioremap_encrypted(). >> >> Signed-off-by: Lianbo Jiang >> --- >> Some changes: >> 1. remove the sme_active() check in __ioremap

Re: [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump

2018-06-21 Thread Baoquan He
On 06/21/18 at 01:42pm, lijiang wrote: > 在 2018年06月21日 00:42, Tom Lendacky 写道: > > On 6/16/2018 3:27 AM, Lianbo Jiang wrote: > >> In kdump mode, it will copy the device table of IOMMU from the old > >> device table, which is encrypted when SME is enabled in the first > >> kernel. So we must remap i

Re: [PATCH v3 1/2] dt-ops: Add helper API to dump fdt blob

2018-06-21 Thread Bhupesh Sharma
Hi Akashi, On 06/20/2018 03:59 PM, Bhupesh Sharma wrote: Hi Akashi, Apologies for delay in replying. Somehow my email filter rules messed up and the review email was sent to another folder. Please see my comments inline: On 05/08/2018 07:44 AM, AKASHI Takahiro wrote: Bhupesh, On Mon, Apr

Re: [PATCH 0/4 V3] Support kdump for AMD secure memory encryption(SME)

2018-06-21 Thread Baoquan He
On 06/21/18 at 11:18am, lijiang wrote: > 在 2018年06月21日 09:21, Baoquan He 写道: > > On 06/16/18 at 04:27pm, Lianbo Jiang wrote: > >> It is convenient to remap the old memory encrypted to the second kernel by > >> calling ioremap_encrypted(). > >> > >> When sme enabled on AMD server, we also need to su