[PATCH] Removing condition that will never be met after calls xmalloc and xrealloc

2020-03-02 Thread Leonidas S. Barbosa
Hi, Looking in the kexec-tools code I found these conditions that seems will never be met. Not sure if that was intentional for explicitity, if it was the case, please disconsider this patch. xmalloc and xrealloc when fails calls die() that calls exit(1). Checks for if(!memory) after they are

Re: misc nits Re: [PATCH 1/2] printk: add lockless buffer

2020-03-02 Thread John Ogness
On 2020-03-02, Petr Mladek wrote: diff --git a/kernel/printk/printk_ringbuffer.c b/kernel/printk/printk_ringbuffer.c new file mode 100644 index ..796257f226ee --- /dev/null +++ b/kernel/printk/printk_ringbuffer.c +/* + * Read the record @id and

Re: misc nits Re: [PATCH 1/2] printk: add lockless buffer

2020-03-02 Thread Petr Mladek
On Mon 2020-03-02 11:38:42, John Ogness wrote: > On 2020-02-21, Petr Mladek wrote: > >> diff --git a/kernel/printk/printk_ringbuffer.c > >> b/kernel/printk/printk_ringbuffer.c > >> new file mode 100644 > >> index ..796257f226ee > >> --- /dev/null > >> +++

Re: misc nits Re: [PATCH 1/2] printk: add lockless buffer

2020-03-02 Thread Joe Perches
On Mon, 2020-03-02 at 11:38 +0100, John Ogness wrote: > On 2020-02-21, Petr Mladek wrote: > > > diff --git a/kernel/printk/printk_ringbuffer.c > > > b/kernel/printk/printk_ringbuffer.c [] > > > +static struct prb_data_block *to_block(struct prb_data_ring *data_ring, > > > +

Re: misc nits Re: [PATCH 1/2] printk: add lockless buffer

2020-03-02 Thread John Ogness
On 2020-02-21, Petr Mladek wrote: >> diff --git a/kernel/printk/printk_ringbuffer.c >> b/kernel/printk/printk_ringbuffer.c >> new file mode 100644 >> index ..796257f226ee >> --- /dev/null >> +++ b/kernel/printk/printk_ringbuffer.c >> +static struct prb_data_block *to_block(struct

Re: About kexec issues in AWS nitro instances (RH bz 1758323)

2020-03-02 Thread Dave Young
On 03/02/20 at 12:20am, Bhupesh Sharma wrote: > Hi Guilherme, > > On Sat, Feb 29, 2020 at 10:37 PM Guilherme G. Piccoli > wrote: > > > > Hi Bhupesh and Dave (and everybody CC'ed here), I'm Guilherme Piccoli > > and I'm working in the same issue observed in RH bugzilla 1758323 [0] - > > or at

Re: [PATCH 2/2] powerpc/pseries: update device tree before ejecting hotplug uevents

2020-03-02 Thread Hari Bathini
On 11/02/20 8:29 AM, Pingfan Liu wrote: > A bug is observed on pseries by taking the following steps on rhel: > -1. drmgr -c mem -r -q 5 > -2. echo c > /proc/sysrq-trigger > > And then, the failure looks like: > kdump: saving to /sysroot//var/crash/127.0.0.1-2020-01-16-02:06:14/ > kdump: