[PATCH] kernel/kexec: remove the lock operation of system_transition_mutex

2021-01-21 Thread Baoquan He
Function kernel_kexec() is called with lock system_transition_mutex held in reboot system call. While inside kernel_kexec(), it will acquire system_transition_mutex agin. This will lead to dead lock. The dead lock should be easily triggered, it hasn't caused any failure report just because the fea

Re: [bug report] PM / reboot: Eliminate race between reboot and suspend

2021-01-21 Thread Baoquan He
On 01/21/21 at 03:42pm, Rafael J. Wysocki wrote: > On Thu, Jan 21, 2021 at 10:14 AM Pingfan Liu wrote: > > > > On Wed, Jan 20, 2021 at 5:30 PM Baoquan He wrote: > > > > > > Hi, > > > > > > On 11/18/20 at 09:59pm, Dan Carpenter wrote: > > > > Hello Pingfan Liu, > > > > > > > > The patch 55f2503c3b

Re: [PATCH 1/1] kernel/crash_core.c - Add crashkernel=auto for x86 and ARM

2021-01-21 Thread Dave Young
On 01/22/21 at 09:22am, Dave Young wrote: > Hi John, > > On 01/21/21 at 09:32am, john.p.donne...@oracle.com wrote: > > On 11/22/20 9:47 PM, Dave Young wrote: > > > Hi Guilherme, > > > On 11/22/20 at 12:32pm, Guilherme Piccoli wrote: > > > > Hi Dave and Kairui, thanks for your responses! OK, if tha

Re: [PATCH 1/1] kernel/crash_core.c - Add crashkernel=auto for x86 and ARM

2021-01-21 Thread Dave Young
Hi John, On 01/21/21 at 09:32am, john.p.donne...@oracle.com wrote: > On 11/22/20 9:47 PM, Dave Young wrote: > > Hi Guilherme, > > On 11/22/20 at 12:32pm, Guilherme Piccoli wrote: > > > Hi Dave and Kairui, thanks for your responses! OK, if that makes sense > > > to you I'm fine with it. I'd just re

Re: [PATCH 1/1] kernel/crash_core.c - Add crashkernel=auto for x86 and ARM

2021-01-21 Thread john . p . donnelly
On 11/22/20 9:47 PM, Dave Young wrote: Hi Guilherme, On 11/22/20 at 12:32pm, Guilherme Piccoli wrote: Hi Dave and Kairui, thanks for your responses! OK, if that makes sense to you I'm fine with it. I'd just recommend to test recent kernels in multiple distros with the minimum "range" to see if 6

Re: [bug report] PM / reboot: Eliminate race between reboot and suspend

2021-01-21 Thread Rafael J. Wysocki
On Thu, Jan 21, 2021 at 10:14 AM Pingfan Liu wrote: > > On Wed, Jan 20, 2021 at 5:30 PM Baoquan He wrote: > > > > Hi, > > > > On 11/18/20 at 09:59pm, Dan Carpenter wrote: > > > Hello Pingfan Liu, > > > > > > The patch 55f2503c3b69: "PM / reboot: Eliminate race between reboot > > > and suspend" fr

Re: [bug report] PM / reboot: Eliminate race between reboot and suspend

2021-01-21 Thread Pingfan Liu
On Wed, Jan 20, 2021 at 5:30 PM Baoquan He wrote: > > Hi, > > On 11/18/20 at 09:59pm, Dan Carpenter wrote: > > Hello Pingfan Liu, > > > > The patch 55f2503c3b69: "PM / reboot: Eliminate race between reboot > > and suspend" from Jul 31, 2018, leads to the following static checker > > warning: > > >

Re: [PATCH] vmalloc: remove redundant NULL check

2021-01-21 Thread Baoquan He
On 01/21/21 at 04:12pm, Yang Li wrote: > Fix below warnings reported by coccicheck: > ./fs/proc/vmcore.c:1503:2-7: WARNING: NULL check before some freeing > functions is not needed. > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > fs/proc/vmcore.c | 7 ++- > 1 file changed, 2 i

[PATCH] vmalloc: remove redundant NULL check

2021-01-21 Thread Yang Li
Fix below warnings reported by coccicheck: ./fs/proc/vmcore.c:1503:2-7: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/proc/vmcore.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/proc/vmcore