[PATCH v2] proc/vmcore: fix potential memory leak in vmcore_init()

2022-09-13 Thread Jianglei Nie
elfcorehdr_alloc() allocates a memory chunk for elfcorehdr_addr with kzalloc(). If is_vmcore_usable() returns false, elfcorehdr_addr is a predefined value. If parse_crash_elf_headers() gets some error and returns a negetive value, the elfcorehdr_addr should be released with elfcorehdr_free(). Fix

Re: [PATCH v12 7/7] x86/crash: Add x86 crash hotplug support

2022-09-13 Thread Eric DeVolder
Boris, Thanks for the feedback! Inline responses below. eric On 9/12/22 01:52, Borislav Petkov wrote: On Fri, Sep 09, 2022 at 05:05:09PM -0400, Eric DeVolder wrote: For x86_64, when CPU or memory is hot un/plugged, the crash elfcorehdr, which describes the CPUs and memory in the system, must

Re: [PATCH] proc/vmcore: fix potential memory leak in vmcore_init()

2022-09-13 Thread Baoquan He
On 09/13/22 at 07:35am, Matthew Wilcox wrote: > On Tue, Sep 13, 2022 at 02:25:01PM +0800, Jianglei Nie wrote: > > } > > - elfcorehdr_free(elfcorehdr_addr); > > elfcorehdr_addr = ELFCORE_ADDR_ERR; > > > > proc_vmcore = proc_create("vmcore", S_IRUSR, NULL, _proc_ops); > > if

Re: [PATCH] proc/vmcore: fix potential memory leak in vmcore_init()

2022-09-13 Thread Matthew Wilcox
On Tue, Sep 13, 2022 at 02:25:01PM +0800, Jianglei Nie wrote: > } > - elfcorehdr_free(elfcorehdr_addr); > elfcorehdr_addr = ELFCORE_ADDR_ERR; > > proc_vmcore = proc_create("vmcore", S_IRUSR, NULL, _proc_ops); > if (proc_vmcore) > proc_vmcore->size =

[PATCH] proc/vmcore: fix potential memory leak in vmcore_init()

2022-09-13 Thread Jianglei Nie
elfcorehdr_alloc() allocates a memory chunk for elfcorehdr_addr with kzalloc(). If is_vmcore_usable() returns false, elfcorehdr_addr is a predefined value. If parse_crash_elf_headers() gets some error and returns a negetive value, the elfcorehdr_addr should be released with elfcorehdr_free(). Fix