Re: [PATCH] lockdown: s390: kexec_file: don't skip signature verification when not secure IPLed

2022-11-22 Thread Coiby Xu
On Tue, Nov 22, 2022 at 04:15:04PM +0100, Vasily Gorbik wrote: On Mon, Nov 21, 2022 at 03:27:15PM +0800, Coiby Xu wrote: --- a/arch/s390/kernel/machine_kexec_file.c +++ b/arch/s390/kernel/machine_kexec_file.c @@ -33,10 +33,6 @@ int s390_verify_sig(const char *kernel, unsigned long kernel_len)

Re: [PATCH v5 5/6] crash: forward memory_notify args to arch crash hotplug handler

2022-11-22 Thread Eric DeVolder
On 11/20/22 17:25, Sourabh Jain wrote: The way memory hot remove is handled on PowerPC, it is hard to update the elfcorehdr without memory_notify args. On PowePC memblock data structure is used to prepare elfcorehdr for kdump. Since the notifier used for memory hotplug crash handler get

Re: [PATCH v5 3/6] crash: add phdr for possible CPUs in elfcorehdr

2022-11-22 Thread Eric DeVolder
On 11/20/22 17:25, Sourabh Jain wrote: On architectures like PowerPC the crash notes are available for all possible CPUs. So let's populate the elfcorehdr for all possible CPUs having crash notes to avoid updating elfcorehdr during in-kernel crash update on CPU hotplug events. The similar

Re: [PATCH] x86/bugs: Explicitly clear speculative MSR bits

2022-11-22 Thread Breno Leitao
On Mon, Nov 21, 2022 at 02:20:31PM -0800, Pawan Gupta wrote: > On Sun, Nov 20, 2022 at 12:02:55PM +, Breno Leitao wrote: ... > > diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c > > index 3e3230cccaa7..970b277d02a6 100644 > > --- a/arch/x86/kernel/cpu/bugs.c > > +++

Re: [PATCH] lockdown: s390: kexec_file: don't skip signature verification when not secure IPLed

2022-11-22 Thread Vasily Gorbik
On Mon, Nov 21, 2022 at 03:27:15PM +0800, Coiby Xu wrote: > --- a/arch/s390/kernel/machine_kexec_file.c > +++ b/arch/s390/kernel/machine_kexec_file.c > @@ -33,10 +33,6 @@ int s390_verify_sig(const char *kernel, unsigned long > kernel_len) > unsigned long sig_len; > int ret; > > -

Re: [PATCH V3 08/11] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-11-22 Thread Borislav Petkov
On Tue, Nov 22, 2022 at 10:33:12AM -0300, Guilherme G. Piccoli wrote: Leaving in the whole thing for newly added people. > On 18/09/2022 11:10, Guilherme G. Piccoli wrote: > > On 19/08/2022 19:17, Guilherme G. Piccoli wrote: > >> The altera_edac panic notifier performs some data collection with

Re: [PATCH V3 11/11] panic: Fixes the panic_print NMI backtrace setting

2022-11-22 Thread Guilherme G. Piccoli
On 19/08/2022 19:17, Guilherme G. Piccoli wrote: > Commit 8d470a45d1a6 ("panic: add option to dump all CPUs backtraces in > panic_print") > introduced a setting for the "panic_print" kernel parameter to allow > users to request a NMI backtrace on panic. Problem is that the panic_print > handling

Re: [PATCH V3 08/11] EDAC/altera: Skip the panic notifier if kdump is loaded

2022-11-22 Thread Guilherme G. Piccoli
On 18/09/2022 11:10, Guilherme G. Piccoli wrote: > On 19/08/2022 19:17, Guilherme G. Piccoli wrote: >> The altera_edac panic notifier performs some data collection with >> regards errors detected; such code relies in the regmap layer to >> perform reads/writes, so the code is abstracted and there

Re: [PATCH V3 07/11] notifiers: Add tracepoints to the notifiers infrastructure

2022-11-22 Thread Guilherme G. Piccoli
On 19/08/2022 19:17, Guilherme G. Piccoli wrote: > Currently there is no way to show the callback names for registered, > unregistered or executed notifiers. This is very useful for debug > purposes, hence add this functionality here in the form of notifiers' > tracepoints, one per operation. > >

Re: [PATCH V3 06/11] tracing: Improve panic/die notifiers

2022-11-22 Thread Guilherme G. Piccoli
On 20/10/2022 19:22, Steven Rostedt wrote: > On Thu, 20 Oct 2022 18:53:43 -0300 > "Guilherme G. Piccoli" wrote: > >> Could you pick it in your tree? Or do you prefer that I re-send as a >> solo patch, with your ACK? > > I wasn't sure there were any dependencies on this. If not, I can take it. >

Re: [PATCH V3 03/11] alpha: Clean-up the panic notifier code

2022-11-22 Thread Guilherme G. Piccoli
On 19/08/2022 19:17, Guilherme G. Piccoli wrote: > The alpha panic notifier has some code issues, not following > the conventions of other notifiers. Also, it might halt the > machine but still it is set to run as early as possible, which > doesn't seem to be a good idea. > > So, let's clean the

Re: [PATCH V3 02/11] notifier: Add panic notifiers info and purge trailing whitespaces

2022-11-22 Thread Guilherme G. Piccoli
On 19/08/2022 19:17, Guilherme G. Piccoli wrote: > Although many notifiers are mentioned in the comments, the panic > notifiers infrastructure is not. Also, the file contains some > trailing whitespaces. Fix both issues here. > > Cc: Arjan van de Ven > Cc: Cong Wang > Cc: Sebastian Andrzej