Re: nvdimm,pmem: makedumpfile: __vtop4_x86_64: Can't get a valid pte.

2022-11-28 Thread Eliot Moss
Glad you found it. Any thoughts/reactions? EM Sent from my iPhone > On Nov 29, 2022, at 12:17 AM, lizhij...@fujitsu.com wrote: > >  > >> On 28/11/2022 23:03, Eliot Moss wrote: >>> On 11/28/2022 9:46 AM, lizhij...@fujitsu.com wrote: >>> >>> >>> On 28/11/2022 20:53, Eliot Moss wrote: On

Re: nvdimm,pmem: makedumpfile: __vtop4_x86_64: Can't get a valid pte.

2022-11-28 Thread lizhij...@fujitsu.com
On 28/11/2022 23:03, Eliot Moss wrote: > On 11/28/2022 9:46 AM, lizhij...@fujitsu.com wrote: >> >> >> On 28/11/2022 20:53, Eliot Moss wrote: >>> On 11/28/2022 7:04 AM, lizhij...@fujitsu.com wrote: Hi folks, I'm going to make crash coredump support pmem region. So I have

Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support

2022-11-28 Thread Baoquan He
On 11/28/22 at 09:46am, Eric DeVolder wrote: > > > On 11/24/22 21:26, Baoquan He wrote: > > On 11/16/22 at 04:46pm, Eric DeVolder wrote: > > .. > > > diff --git a/include/linux/kexec.h b/include/linux/kexec.h > > > index ebf46c3b8f8b..b4dbc21f9081 100644 > > > --- a/include/linux/kexec.h > >

Re: [PATCH v2] x86/bugs: Explicitly clear speculative MSR bits

2022-11-28 Thread Pawan Gupta
On Mon, Nov 28, 2022 at 03:02:21PM -0800, Pawan Gupta wrote: On Mon, Nov 28, 2022 at 11:40:19PM +0100, Borislav Petkov wrote: On Mon, Nov 28, 2022 at 02:03:58PM -0800, Pawan Gupta wrote: diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c index 3e3230cccaa7..cfc2ed2661fc

Re: [PATCH v1 2/2] kexec: Introduce kexec_reboot_disabled

2022-11-28 Thread Steven Rostedt
On Mon, 28 Nov 2022 17:28:55 +0100 Philipp Rudo wrote: > To be honest I don't think we make a progress here at the moment. I > would like to hear from others what they think about this. Not sure if you missed my reply. https://lore.kernel.org/all/20221128114200.72b3e...@gandalf.local.home/

Re: [PATCH v2] x86/bugs: Explicitly clear speculative MSR bits

2022-11-28 Thread Borislav Petkov
On Mon, Nov 28, 2022 at 03:02:19PM -0800, Pawan Gupta wrote: > Yes thats a cleaner approach, except that the late microcode load will > ruin the MSR: > > microcode_reload_late() > microcode_check() > get_cpu_cap() > init_speculation_control() Microcode late loading ruins a lot of

Re: [PATCH v2] x86/bugs: Explicitly clear speculative MSR bits

2022-11-28 Thread Pawan Gupta
On Mon, Nov 28, 2022 at 11:40:19PM +0100, Borislav Petkov wrote: On Mon, Nov 28, 2022 at 02:03:58PM -0800, Pawan Gupta wrote: diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c index 3e3230cccaa7..cfc2ed2661fc 100644 --- a/arch/x86/kernel/cpu/bugs.c +++

Re: [PATCH v2] x86/bugs: Explicitly clear speculative MSR bits

2022-11-28 Thread Borislav Petkov
On Mon, Nov 28, 2022 at 02:03:58PM -0800, Pawan Gupta wrote: > diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c > index 3e3230cccaa7..cfc2ed2661fc 100644 > --- a/arch/x86/kernel/cpu/bugs.c > +++ b/arch/x86/kernel/cpu/bugs.c > @@ -66,7 +66,7 @@ static

Re: [PATCH v2] x86/bugs: Explicitly clear speculative MSR bits

2022-11-28 Thread Pawan Gupta
On Mon, Nov 28, 2022 at 01:42:26AM +0100, Borislav Petkov wrote: On Thu, Nov 24, 2022 at 02:46:50AM -0800, Breno Leitao wrote: Currently x86_spec_ctrl_base is read at boot time, and speculative bits are set if configs are enable, such as MSR[SPEC_CTRL_IBRS] is enabled if CONFIG_CPU_IBRS_ENTRY

Re: [PATCH] lockdown: kexec_file: prevent unsigned kernel image when KEXEC_SIG not enabled

2022-11-28 Thread Mimi Zohar
On Tue, 2022-11-22 at 10:36 +0800, Coiby Xu wrote: > Hi Mimi, > > On Mon, Nov 21, 2022 at 01:23:57PM -0500, Mimi Zohar wrote: > >Hi Coiby, > > > >On Mon, 2022-11-21 at 15:29 +0800, Coiby Xu wrote: > >> A kernel builder may not enable KEXEC_SIG and some architectures like > >> ppc64 simply don't

Re: [PATCH] kexec: Enable runtime allocation of crash_image

2022-11-28 Thread Ricardo Ribalda
Hi Philipp Thanks for your review. On Mon, 28 Nov 2022 at 18:00, Philipp Rudo wrote: > > Hi Ricardo, > > On Thu, 24 Nov 2022 23:23:36 +0100 > Ricardo Ribalda wrote: > > > Usually crash_image is defined statically via the crashkernel parameter > > or DT. > > > > But if the crash kernel is not

Re: [PATCH] kexec: Enable runtime allocation of crash_image

2022-11-28 Thread Philipp Rudo
Hi Ricardo, On Thu, 24 Nov 2022 23:23:36 +0100 Ricardo Ribalda wrote: > Usually crash_image is defined statically via the crashkernel parameter > or DT. > > But if the crash kernel is not used, or is smaller than then > area pre-allocated that memory is wasted. > > Also, if the crash kernel

Re: [PATCH v1 2/2] kexec: Introduce kexec_reboot_disabled

2022-11-28 Thread Steven Rostedt
On Thu, 24 Nov 2022 16:01:15 +0100 Philipp Rudo wrote: > No, I think the implementation is fine. I'm currently only struggling > to understand what problem kexec_reboot_disabled solves that cannot be > solved by kexec_load_disabled. Hi Philipp, Thanks for working with us on this. Let me try

Re: [PATCH v1 2/2] kexec: Introduce kexec_reboot_disabled

2022-11-28 Thread Philipp Rudo
Hi Ricardo, On Thu, 24 Nov 2022 23:32:34 +0100 Ricardo Ribalda wrote: > Hi Philipp > > > On Thu, 24 Nov 2022 at 16:01, Philipp Rudo wrote: > > > > On Thu, 24 Nov 2022 13:52:58 +0100 > > Ricardo Ribalda wrote: > > > > > On Thu, 24 Nov 2022 at 12:40, Philipp Rudo wrote: > > > > > > > >

Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support

2022-11-28 Thread Eric DeVolder
On 11/24/22 21:26, Baoquan He wrote: On 11/16/22 at 04:46pm, Eric DeVolder wrote: .. diff --git a/include/linux/kexec.h b/include/linux/kexec.h index ebf46c3b8f8b..b4dbc21f9081 100644 --- a/include/linux/kexec.h +++ b/include/linux/kexec.h @@ -32,6 +32,7 @@ extern note_buf_t __percpu

[PATCH v3] x86/bugs: Explicitly clear speculative MSR bits

2022-11-28 Thread Breno Leitao
Currently x86_spec_ctrl_base is read at boot time, and speculative bits are set if configs are enable, such as MSR[SPEC_CTRL_IBRS] is enabled if CONFIG_CPU_IBRS_ENTRY is configured. These MSR bits are not cleared if the mitigations are disabled. This is a problem when kexec-ing a kernel that has

Re: nvdimm,pmem: makedumpfile: __vtop4_x86_64: Can't get a valid pte.

2022-11-28 Thread Eliot Moss
On 11/28/2022 9:46 AM, lizhij...@fujitsu.com wrote: On 28/11/2022 20:53, Eliot Moss wrote: On 11/28/2022 7:04 AM, lizhij...@fujitsu.com wrote: Hi folks, I'm going to make crash coredump support pmem region. So I have modified kexec-tools to add pmem region to PT_LOAD of vmcore. But it

Re: nvdimm,pmem: makedumpfile: __vtop4_x86_64: Can't get a valid pte.

2022-11-28 Thread lizhij...@fujitsu.com
On 28/11/2022 20:53, Eliot Moss wrote: > On 11/28/2022 7:04 AM, lizhij...@fujitsu.com wrote: >> Hi folks, >> >> I'm going to make crash coredump support pmem region. So >> I have modified kexec-tools to add pmem region to PT_LOAD of vmcore. >> >> But it failed at makedumpfile, log are as

Re: nvdimm,pmem: makedumpfile: __vtop4_x86_64: Can't get a valid pte.

2022-11-28 Thread Eliot Moss
On 11/28/2022 7:04 AM, lizhij...@fujitsu.com wrote: Hi folks, I'm going to make crash coredump support pmem region. So I have modified kexec-tools to add pmem region to PT_LOAD of vmcore. But it failed at makedumpfile, log are as following: In my environment, i found the last 512 pages in

nvdimm,pmem: makedumpfile: __vtop4_x86_64: Can't get a valid pte.

2022-11-28 Thread lizhij...@fujitsu.com
Hi folks, I'm going to make crash coredump support pmem region. So I have modified kexec-tools to add pmem region to PT_LOAD of vmcore. But it failed at makedumpfile, log are as following: In my environment, i found the last 512 pages in pmem region will cause the error. qemu commandline: