Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support

2022-12-07 Thread Baoquan He
On 12/07/22 at 04:56pm, Borislav Petkov wrote: > On Wed, Dec 07, 2022 at 09:57:48PM +0800, Baoquan He wrote: > > I thought we usually need to introduce the kernel config option, then > > add code related to it, so that is a wrong idea. > > It depends: sometimes it is prudent to add the code

Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support

2022-12-07 Thread Borislav Petkov
On Wed, Dec 07, 2022 at 09:57:48PM +0800, Baoquan He wrote: > I thought we usually need to introduce the kernel config option, then > add code related to it, so that is a wrong idea. It depends: sometimes it is prudent to add the code behind an ifdeffery first but have it not being buildable so

[ANNOUNCE] kexec-tools 2.0.26-rc1

2022-12-07 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.26-rc1. This is an incremental feature pre-release. So long as no serious problems arise I intend to release kexec-tools 2.0.26 in a weeks time. Testing of 2.0.26-rc1 would be greatly appreciated. I do not have any outstanding

Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64

2022-12-07 Thread Conor Dooley
On Wed, Dec 07, 2022 at 11:34:57AM +0800, Guo Ren wrote: > On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley wrote: > > > > Hey Palmer, Xianting, > > > > On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > > > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > > > As disscussed

Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64

2022-12-07 Thread Conor Dooley
Hey Palmer, Xianting, On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > On Wed, 26 Oct 2022 22:42:06 +0800, Xianting Tian wrote: > > As disscussed in below patch set, the patch of 'describe VMCOREINFO export > > in Documentation' > > need to update according to Bagas's comments.

Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support

2022-12-07 Thread Baoquan He
On 12/07/22 at 01:42pm, Borislav Petkov wrote: > On Wed, Dec 07, 2022 at 08:36:13PM +0800, Baoquan He wrote: > > Below is my last reply to Eric about my thinking on this. > > Yes, I saw that. > > So think about it: if a CONFIG_ item is not present, what does that mean > for the code which is

Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support

2022-12-07 Thread Borislav Petkov
On Wed, Dec 07, 2022 at 08:36:13PM +0800, Baoquan He wrote: > Below is my last reply to Eric about my thinking on this. Yes, I saw that. So think about it: if a CONFIG_ item is not present, what does that mean for the code which is enclosed around it? -- Regards/Gruss, Boris.

Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support

2022-12-07 Thread Baoquan He
On 12/07/22 at 11:00am, Borislav Petkov wrote: > On Fri, Nov 25, 2022 at 11:26:53AM +0800, Baoquan He wrote: > > This kernel config CRASH_HOTPLUG is added in patch 7, but we have used > > it in the previous patch, not sure if this is acceptable. > > Why would it not be acceptable? Below is my

Re: [PATCH v14 7/7] x86/crash: add x86 crash hotplug support

2022-12-07 Thread Borislav Petkov
On Wed, Nov 16, 2022 at 04:46:43PM -0500, Eric DeVolder wrote: > When CPU or memory is hot un/plugged, the crash elfcorehdr, which > describes the CPUs and memory in the system, must also be updated. > > A new elfcorehdr is generated from the available CPUs and memory > into a buffer, and then

Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support

2022-12-07 Thread Borislav Petkov
On Wed, Nov 16, 2022 at 04:46:39PM -0500, Eric DeVolder wrote: > +#ifndef arch_map_crash_pages > +/* > + * NOTE: The addresses and sizes passed to this routine have > + * already been fully aligned on page boundaries. There is no > + * need for massaging the address or size. > + */ > +static

Re: [PATCH v14 3/7] crash: add generic infrastructure for crash hotplug support

2022-12-07 Thread Borislav Petkov
On Fri, Nov 25, 2022 at 11:26:53AM +0800, Baoquan He wrote: > This kernel config CRASH_HOTPLUG is added in patch 7, but we have used > it in the previous patch, not sure if this is acceptable. Why would it not be acceptable? -- Regards/Gruss, Boris.

Re: [PATCH V5 0/2] Support VMCOREINFO export for RISCV64

2022-12-07 Thread Guo Ren
On Wed, Dec 7, 2022 at 4:08 PM Conor Dooley wrote: > > On Wed, Dec 07, 2022 at 11:34:57AM +0800, Guo Ren wrote: > > On Wed, Dec 7, 2022 at 7:05 AM Conor Dooley wrote: > > > > > > Hey Palmer, Xianting, > > > > > > On Fri, Dec 02, 2022 at 04:49:39PM -0800, Palmer Dabbelt wrote: > > > > On Wed, 26