Re: [PATCH -next v2 1/2] riscv: kdump: Implement crashkernel=X,[high,low]

2023-03-30 Thread Baoquan He
On 03/30/23 at 09:40pm, chenjiahao (C) wrote: .. > Agreed, I will clean this up later in next version. > > > + if (ret || !crash_size) > > > + return; > > > + > > > + /* > > > + * crashkernel=Y,low is valid only when crashkernel=X,high > > > +

Re: [PATCH v5 2/2] x86/purgatory: Add linker script

2023-03-30 Thread Borislav Petkov
On Thu, Mar 30, 2023 at 11:31:27AM -0400, Steven Rostedt wrote: > On Thu, 30 Mar 2023 17:18:26 +0200 > Borislav Petkov wrote: > > > On Thu, Mar 30, 2023 at 11:15:23AM -0400, Steven Rostedt wrote: > > > > Make sure that the .text section is not divided in multiple overlapping > > > > sections.

Re: [PATCH v5 2/2] x86/purgatory: Add linker script

2023-03-30 Thread Steven Rostedt
On Thu, 30 Mar 2023 17:18:26 +0200 Borislav Petkov wrote: > On Thu, Mar 30, 2023 at 11:15:23AM -0400, Steven Rostedt wrote: > > > Make sure that the .text section is not divided in multiple overlapping > > > sections. This is not supported by kexec_file. > > And? > > What is the failure

Re: [PATCH v5 2/2] x86/purgatory: Add linker script

2023-03-30 Thread Borislav Petkov
On Thu, Mar 30, 2023 at 11:15:23AM -0400, Steven Rostedt wrote: > > Make sure that the .text section is not divided in multiple overlapping > > sections. This is not supported by kexec_file. And? What is the failure scenario? Why are you fixing it? Why do we care? This is way too laconic. --

Re: [PATCH v5 2/2] x86/purgatory: Add linker script

2023-03-30 Thread Steven Rostedt
Hmm, this patch may need some more eyes. At least from the x86 maintainers. -- Steve On Thu, 30 Mar 2023 11:44:48 +0200 Ricardo Ribalda wrote: > Make sure that the .text section is not divided in multiple overlapping > sections. This is not supported by kexec_file. > > Signed-off-by:

Re: [PATCH v5 1/2] kexec: Support purgatories with .text.hot sections

2023-03-30 Thread Steven Rostedt
On Thu, 30 Mar 2023 11:44:47 +0200 Ricardo Ribalda wrote: > Clang16 links the purgatory text in two sections: > > [ 1] .text PROGBITS 0040 >11a1 AX 0 0 16 > [ 2] .rela.textRELA

Re: [PATCH -next v2 1/2] riscv: kdump: Implement crashkernel=X,[high,low]

2023-03-30 Thread chenjiahao (C)
On 2023/3/29 19:19, Baoquan He wrote: On 03/28/23 at 07:51pm, Chen Jiahao wrote: Thanks for reviewing. On riscv, the current crash kernel allocation logic is trying to allocate within 32bit addressible memory region by default, if failed, try to allocate without 4G restriction. In need of

Re: [PATCH v4 1/2] kexec: Support purgatories with .text.hot sections

2023-03-30 Thread Ricardo Ribalda
Hi Simon Thanks for your review! On Thu, 30 Mar 2023 at 09:49, Simon Horman wrote: > > On Mon, Mar 27, 2023 at 05:06:53PM +0200, Ricardo Ribalda wrote: > > Clang16 links the purgatory text in two sections: > > > > [ 1] .text PROGBITS 0040 > >

[PATCH v5 2/2] x86/purgatory: Add linker script

2023-03-30 Thread Ricardo Ribalda
Make sure that the .text section is not divided in multiple overlapping sections. This is not supported by kexec_file. Signed-off-by: Ricardo Ribalda --- arch/x86/purgatory/.gitignore| 2 ++ arch/x86/purgatory/Makefile | 20 + arch/x86/purgatory/kexec-purgatory.S |

[PATCH v5 0/2] kexec: Fix kexec_file_load for llvm16

2023-03-30 Thread Ricardo Ribalda
When upreving llvm I realised that kexec stopped working on my test platform. This patch fixes it. Signed-off-by: Ricardo Ribalda --- Changes in v5: - Add warning when multiple text sections are found. Thanks Simon! - Add Fixes tag. - Link to v4:

[PATCH v5 1/2] kexec: Support purgatories with .text.hot sections

2023-03-30 Thread Ricardo Ribalda
Clang16 links the purgatory text in two sections: [ 1] .text PROGBITS 0040 11a1 AX 0 0 16 [ 2] .rela.textRELA 3498 0648 0018

Re: [PATCH v4 1/2] kexec: Support purgatories with .text.hot sections

2023-03-30 Thread Simon Horman
On Mon, Mar 27, 2023 at 05:06:53PM +0200, Ricardo Ribalda wrote: > Clang16 links the purgatory text in two sections: > > [ 1] .text PROGBITS 0040 >11a1 AX 0 0 16 > [ 2] .rela.textRELA