Re: [PATCH] parisc: kexec: include reboot.h

2023-05-09 Thread Baoquan He
On 05/09/23 at 01:52pm, Simon Horman wrote: > On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote: > > On 05/09/23 at 09:01am, Simon Horman wrote: > > > Include reboot.h in machine_kexec.c for declaration of > > > machine_crash_shutdown and machine_shutdown. > > > > > > gcc-12 with W=1

Re: [PATCH v6 06/14] x86: Add early SHA support for Secure Launch early measurements

2023-05-09 Thread Eric Biggers
On Thu, May 04, 2023 at 02:50:15PM +, Ross Philipson wrote: > From: "Daniel P. Smith" > > The SHA algorithms are necessary to measure configuration information into > the TPM as early as possible before using the values. This implementation > uses the established approach of #including the

Re: [PATCH v22 5/8] x86/crash: add x86 crash hotplug support

2023-05-09 Thread Thomas Gleixner
On Wed, May 03 2023 at 18:41, Eric DeVolder wrote: > In the patch 'kexec: exclude elfcorehdr from the segment digest' See reply to 8/8 > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > index 53bab123a8ee..80538524c494 100644 > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -2119,6

Re: [PATCH v22 8/8] x86/crash: optimize CPU changes

2023-05-09 Thread Thomas Gleixner
On Wed, May 03 2023 at 18:41, Eric DeVolder wrote: > This patch is dependent upon the patch 'crash: change Seriously? You send a patch series which is ordered in itself and then tell in the changelog of patch 8/8 that it depends on patch 7/8? This information is complete garbage once the patches

Re: [PATCH v22 6/8] crash: hotplug support for kexec_load()

2023-05-09 Thread Eric DeVolder
On 5/9/23 01:56, Sourabh Jain wrote: > > On 04/05/23 04:11, Eric DeVolder wrote: >> The hotplug support for kexec_load() requires coordination with >> userspace, and therefore a little extra help from the kernel to >> facilitate the coordination. >> >> In the absence of the solution contained

Re: [PATCH v6 06/14] x86: Add early SHA support for Secure Launch early measurements

2023-05-09 Thread Daniel P. Smith
On 5/5/23 12:34, Simon Horman wrote: On Thu, May 04, 2023 at 02:50:15PM +, Ross Philipson wrote: From: "Daniel P. Smith" The SHA algorithms are necessary to measure configuration information into the TPM as early as possible before using the values. This implementation uses the

Re: [PATCH] parisc: kexec: include reboot.h

2023-05-09 Thread Helge Deller
On 5/9/23 13:52, Simon Horman wrote: On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote: On 05/09/23 at 09:01am, Simon Horman wrote: Include reboot.h in machine_kexec.c for declaration of machine_crash_shutdown and machine_shutdown. gcc-12 with W=1 reports:

Re: [PATCH] parisc: kexec: include reboot.h

2023-05-09 Thread Simon Horman
On Tue, May 09, 2023 at 05:01:42PM +0800, Baoquan He wrote: > On 05/09/23 at 09:01am, Simon Horman wrote: > > Include reboot.h in machine_kexec.c for declaration of > > machine_crash_shutdown and machine_shutdown. > > > > gcc-12 with W=1 reports: > > > > arch/parisc/kernel/kexec.c:57:6:

Re: [PATCH] parisc: kexec: include reboot.h

2023-05-09 Thread Baoquan He
On 05/09/23 at 09:01am, Simon Horman wrote: > Include reboot.h in machine_kexec.c for declaration of > machine_crash_shutdown and machine_shutdown. > > gcc-12 with W=1 reports: > > arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for > 'machine_crash_shutdown'

[PATCH] parisc: kexec: include reboot.h

2023-05-09 Thread Simon Horman
Include reboot.h in machine_kexec.c for declaration of machine_crash_shutdown and machine_shutdown. gcc-12 with W=1 reports: arch/parisc/kernel/kexec.c:57:6: warning: no previous prototype for 'machine_crash_shutdown' [-Wmissing-prototypes] 57 | void machine_crash_shutdown(struct pt_regs

Re: [PATCH v22 6/8] crash: hotplug support for kexec_load()

2023-05-09 Thread Sourabh Jain
On 04/05/23 04:11, Eric DeVolder wrote: The hotplug support for kexec_load() requires coordination with userspace, and therefore a little extra help from the kernel to facilitate the coordination. In the absence of the solution contained within this particular patch, if a kdump capture kernel

Re: [PATCH v22 6/8] crash: hotplug support for kexec_load()

2023-05-09 Thread Sourabh Jain
On 04/05/23 04:11, Eric DeVolder wrote: The hotplug support for kexec_load() requires coordination with userspace, and therefore a little extra help from the kernel to facilitate the coordination. In the absence of the solution contained within this particular patch, if a kdump capture kernel