Re: [PATCH v2 6/8] x86: kdump: use generic interface to simplify crashkernel reservation code

2023-08-29 Thread kernel test robot
Hi Baoquan, kernel test robot noticed the following build errors: [auto build test ERROR on arm64/for-next/core] [also build test ERROR on tip/x86/core powerpc/next powerpc/fixes v6.5] [cannot apply to linus/master next-20230829] [If your patch is applied to the wrong git tree, kindly drop us

Re: [RFC] IMA Log Snapshotting Design Proposal

2023-08-29 Thread Paul Moore
On Tue, Aug 29, 2023 at 5:54 PM Mimi Zohar wrote: > On Tue, 2023-08-29 at 17:30 -0400, Paul Moore wrote: > > On Tue, Aug 29, 2023 at 5:05 PM Mimi Zohar wrote: > > > On Tue, 2023-08-29 at 15:34 -0400, Paul Moore wrote: > > > > On Mon, Aug 21, 2023 at 7:08 PM Mimi Zohar wrote: > > > > > On Mon,

Re: [RFC PATCH] Introduce persistent memory pool

2023-08-29 Thread Stanislav Kinsburskii
On Mon, Aug 28, 2023 at 10:50:19PM +0200, Alexander Graf wrote: > +kexec, iommu, kvm > > On 23.08.23 04:45, Stanislav Kinsburskii wrote: > > > > +akpm, +linux-mm > > > > On Fri, Aug 25, 2023 at 01:32:40PM +, Gowans, James wrote: > > > On Fri, 2023-08-25 at 10:05 +0200, Greg Kroah-Hartman

Re: [RFC] IMA Log Snapshotting Design Proposal

2023-08-29 Thread Mimi Zohar
On Tue, 2023-08-29 at 17:30 -0400, Paul Moore wrote: > On Tue, Aug 29, 2023 at 5:05 PM Mimi Zohar wrote: > > On Tue, 2023-08-29 at 15:34 -0400, Paul Moore wrote: > > > On Mon, Aug 21, 2023 at 7:08 PM Mimi Zohar wrote: > > > > On Mon, 2023-08-21 at 15:05 -0700, Sush Shringarputale wrote: > > > >

Re: [PATCH v2 6/8] x86: kdump: use generic interface to simplify crashkernel reservation code

2023-08-29 Thread kernel test robot
Hi Baoquan, kernel test robot noticed the following build errors: [auto build test ERROR on arm64/for-next/core] [also build test ERROR on tip/x86/core powerpc/next powerpc/fixes linus/master v6.5] [cannot apply to next-20230829] [If your patch is applied to the wrong git tree, kindly drop us

Re: [RFC] IMA Log Snapshotting Design Proposal

2023-08-29 Thread Paul Moore
On Tue, Aug 29, 2023 at 5:05 PM Mimi Zohar wrote: > On Tue, 2023-08-29 at 15:34 -0400, Paul Moore wrote: > > On Mon, Aug 21, 2023 at 7:08 PM Mimi Zohar wrote: > > > On Mon, 2023-08-21 at 15:05 -0700, Sush Shringarputale wrote: > > > > On 8/14/2023 3:02 PM, Mimi Zohar wrote: > > > > > On Mon,

Re: [RFC] IMA Log Snapshotting Design Proposal

2023-08-29 Thread Mimi Zohar
On Tue, 2023-08-29 at 15:34 -0400, Paul Moore wrote: > On Mon, Aug 21, 2023 at 7:08 PM Mimi Zohar wrote: > > On Mon, 2023-08-21 at 15:05 -0700, Sush Shringarputale wrote: > > > On 8/14/2023 3:02 PM, Mimi Zohar wrote: > > > > On Mon, 2023-08-14 at 14:42 -0700, Sush Shringarputale wrote: > > > >>>

Re: [RFC] IMA Log Snapshotting Design Proposal

2023-08-29 Thread Paul Moore
On Mon, Aug 21, 2023 at 7:08 PM Mimi Zohar wrote: > On Mon, 2023-08-21 at 15:05 -0700, Sush Shringarputale wrote: > > On 8/14/2023 3:02 PM, Mimi Zohar wrote: > > > On Mon, 2023-08-14 at 14:42 -0700, Sush Shringarputale wrote: > > >>> This design seems overly complex and requires synchronization

[PATCH v2 4/8] crash_core: add generic function to do reservation

2023-08-29 Thread Baoquan He
In architecture like x86_64, arm64 and riscv, they have vast virtual address space and usually have huge physical memory RAM. Their crashkernel reservation doesn't have to be limited under 4G RAM, but can be extended to the whole physical memory via crashkernel=,high support. Now add function

[PATCH v2 7/8] arm64: kdump: use generic interface to simplify crashkernel reservation

2023-08-29 Thread Baoquan He
With the help of newly changed function parse_crashkernel() and generic reserve_crashkernel_generic(), crashkernel reservation can be simplified by steps: 1) Add a new header file , and define CRASH_ALIGN, CRASH_ADDR_LOW_MAX, CRASH_ADDR_HIGH_MAX and DEFAULT_CRASH_KERNEL_LOW_SIZE in ; 2)

[PATCH v2 6/8] x86: kdump: use generic interface to simplify crashkernel reservation code

2023-08-29 Thread Baoquan He
With the help of newly changed function parse_crashkernel() and generic reserve_crashkernel_generic(), crashkernel reservation can be simplified by steps: 1) Add a new header file , and define CRASH_ALIGN, CRASH_ADDR_LOW_MAX, CRASH_ADDR_HIGH_MAX and DEFAULT_CRASH_KERNEL_LOW_SIZE in ; 2)

[PATCH v2 8/8] crash_core.c: remove unneeded functions

2023-08-29 Thread Baoquan He
So far, nobody calls functions parse_crashkernel_high() and parse_crashkernel_low(), remove both of them. Signed-off-by: Baoquan He --- include/linux/crash_core.h | 4 kernel/crash_core.c| 18 -- 2 files changed, 22 deletions(-) diff --git

[PATCH v2 5/8] crash_core.h: include if generic reservation is needed

2023-08-29 Thread Baoquan He
In asm/crash_core.h, ARCH can provide its own macro definitions to override DEFAULT_CRASH_KERNEL_LOW_SIZE, CRASH_ALIGN, CRASH_ADDR_LOW_MAX, CRASH_ADDR_HIGH_MAX in if needed. Later, x86 and arm64 wil support the generic reservaton, so wrap the including into

[PATCH v2 2/8] crash_core: change the prototype of function parse_crashkernel()

2023-08-29 Thread Baoquan He
Add two parameters 'low_size' and 'high' to function parse_crashkernel(), later crashkernel=,high|low parsing will be added. Make adjustments in all call sites of parse_crashkernel() in arch. Signed-off-by: Baoquan He --- arch/arm/kernel/setup.c | 3 ++- arch/arm64/mm/init.c

[PATCH v2 0/8] kdump: use generic functions to simplify crashkernel reservation in arch

2023-08-29 Thread Baoquan He
In the current arm64, crashkernel=,high support has been finished after several rounds of posting and careful reviewing. The code in arm64 which parses crashkernel kernel parameters firstly, then reserve memory can be a good example for other ARCH to refer to. Whereas in x86_64, the code mixing

[PATCH v2 3/8] crash_core: change parse_crashkernel() to support crashkernel=,high|low parsing

2023-08-29 Thread Baoquan He
Now parse_crashkernel() is a real entry point for all kinds of crahskernel parsing on any architecture. And wrap the crahskernel=,high|low handling inside CONFIG_ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION ifdeffery scope. Signed-off-by: Baoquan He --- include/linux/crash_core.h | 6 ++

[PATCH v2 1/8] crash_core.c: remove unnecessary parameter of function

2023-08-29 Thread Baoquan He
In all call sites of __parse_crashkernel(), the parameter 'name' is hardcoded as "crashkernel=". So remove the unnecessary parameter 'name', add local varibale 'name' inside __parse_crashkernel() instead. Signed-off-by: Baoquan He --- kernel/crash_core.c | 8 1 file changed, 4

Re: [PATCH -next v9 0/2] support allocating crashkernel above 4G explicitly on riscv

2023-08-29 Thread chenjiahao (C)
Hi folks, This is a friendly ping. Anyone has additional comments on this patch set? Best regards, Jiahao On 2023/7/27 1:49, Chen Jiahao wrote: On riscv, the current crash kernel allocation logic is trying to allocate within 32bit addressible memory region by default, if failed, try to