Re: [PATCH v3 8/9] riscv: kdump: use generic interface to simplify crashkernel reservation

2023-09-20 Thread Baoquan He
MB) > [0.00] crashkernel reserved: 0x000177e0 - 0x000277e0 > (4096 MB) > [0.00] [ cut here ] > [0.00] WARNING: CPU: 0 PID: 0 at kernel/resource.c:779 > __insert_resource+0x8e/0xd0 > [0.00] Modules linked in: > [

Re: [PATCH v2 0/2] x86/kexec: UKI Support

2023-09-20 Thread Dave Young
On Wed, 20 Sept 2023 at 20:18, Dave Young wrote: > > On Wed, 20 Sept 2023 at 20:07, Dave Young wrote: > > > > On Wed, 20 Sept 2023 at 18:50, Ard Biesheuvel wrote: > > > > > > On Wed, 20 Sept 2023 at 08:40, Dave Young wrote: > > > > > > > > On Wed, 20 Sept 2023 at 15:43, Dave Young wrote: > >

Re: [PATCH v3 8/9] riscv: kdump: use generic interface to simplify crashkernel reservation

2023-09-20 Thread chenjiahao (C)
] CPU: 0 PID: 0 Comm: swapper Not tainted 6.6.0-rc2-next-20230920 #1 [0.00] Hardware name: riscv-virtio,qemu (DT) [0.00] epc : __insert_resource+0x8e/0xd0 [0.00] ra : insert_resource+0x28/0x4e [0.00] epc : 80017344 ra : 8001742e sp : 81203db0

Re: [PATCH v2 0/2] x86/kexec: UKI Support

2023-09-20 Thread Jan Hendrik Farr
Hi Ard, Greetings from Delft On 20 10:50:31, Ard Biesheuvel wrote: > On Wed, 20 Sept 2023 at 08:40, Dave Young wrote: > > > > On Wed, 20 Sept 2023 at 15:43, Dave Young wrote: > > > > > > > > In the end the only benefit this series brings is to extend the > > > > > signature checking on the

Re: [PATCH v6 07/14] x86: Secure Launch kernel early boot stub

2023-09-20 Thread ross . philipson
On 5/12/23 11:04 AM, Thomas Gleixner wrote: On Thu, May 04 2023 at 14:50, Ross Philipson wrote: + +/* CPUID: leaf 1, ECX, SMX feature bit */ +#define X86_FEATURE_BIT_SMX(1 << 6) + +/* Can't include apiddef.h in asm */ Why not? All it needs is a #ifndef __ASSEMBLY__ guard around the C

Re: [PATCH 0/7] Kexec-tools: Improve RISC-V port

2023-09-20 Thread Nick Kossifidis
On 9/15/23 06:50, Song Shuai wrote: Hi, This series is created to improve RISC-V port of kexec-tools, and is based on the horms/kexec-tools:build-test-riscv-v2 branch. For your convenience, here is my Github branch for kexec-tools: https://github.com/sugarfillet/kexec-tools/commits/rv-Image

Re: [PATCH] kexec: update manpage with explicit mention of clean kexec

2023-09-20 Thread Hari Bathini
On 20/09/23 5:11 pm, Simon Horman wrote: On Mon, Sep 11, 2023 at 12:04:08PM +0530, Hari Bathini wrote: On 28/08/23 3:12 pm, Baoquan He wrote: On 08/28/23 at 09:48am, Simon Horman wrote: On Mon, Aug 28, 2023 at 11:46:14AM +0530, Hari Bathini wrote: Any comments on this, please.. Hi

[PATCH v3 3/5] kernel: watch_queue: copy user-array safely

2023-09-20 Thread Philipp Stanner
Currently, there is no overflow-check with memdup_user(). Use the new function memdup_array_user() instead of memdup_user() for duplicating the user-space array safely. Suggested-by: David Airlie Signed-off-by: Philipp Stanner Reviewed-by: Kees Cook Reviewed-by: Zack Rusin ---

[PATCH v3 2/5] kernel: kexec: copy user-array safely

2023-09-20 Thread Philipp Stanner
Currently, there is no overflow-check with memdup_user(). Use the new function memdup_array_user() instead of memdup_user() for duplicating the user-space array safely. Suggested-by: David Airlie Signed-off-by: Philipp Stanner Acked-by: Baoquan He Reviewed-by: Kees Cook Reviewed-by: Zack

[PATCH v3 4/5] drm_lease.c: copy user-array safely

2023-09-20 Thread Philipp Stanner
Currently, there is no overflow-check with memdup_user(). Use the new function memdup_array_user() instead of memdup_user() for duplicating the user-space array safely. Suggested-by: David Airlie Signed-off-by: Philipp Stanner Reviewed-by: Kees Cook Reviewed-by: Zack Rusin ---

[PATCH v3 5/5] drm: vmgfx_surface.c: copy user-array safely

2023-09-20 Thread Philipp Stanner
Currently, there is no overflow-check with memdup_user(). Use the new function memdup_array_user() instead of memdup_user() for duplicating the user-space array safely. Suggested-by: David Airlie Signed-off-by: Philipp Stanner Reviewed-by: Kees Cook Reviewed-by: Zack Rusin ---

[PATCH v3 0/5] Introduce new wrappers to copy user-arrays

2023-09-20 Thread Philipp Stanner
Hi! David Airlie suggested that we could implement new wrappers around (v)memdup_user() for duplicating user arrays. This small patch series first implements the two new wrapper functions memdup_array_user() and vmemdup_array_user(). They calculate the array-sizes safely, i.e., they return an

[PATCH v3 1/5] string.h: add array-wrappers for (v)memdup_user()

2023-09-20 Thread Philipp Stanner
Currently, user array duplications are sometimes done without an overflow check. Sometimes the checks are done manually; sometimes the array size is calculated with array_size() and sometimes by calculating n * size directly in code. Introduce wrappers for arrays for memdup_user() and

Re: [PATCH v2 0/2] x86/kexec: UKI Support

2023-09-20 Thread Dave Young
On Wed, 20 Sept 2023 at 20:07, Dave Young wrote: > > On Wed, 20 Sept 2023 at 18:50, Ard Biesheuvel wrote: > > > > On Wed, 20 Sept 2023 at 08:40, Dave Young wrote: > > > > > > On Wed, 20 Sept 2023 at 15:43, Dave Young wrote: > > > > > > > > > > In the end the only benefit this series brings is

Re: [PATCH v2 0/2] x86/kexec: UKI Support

2023-09-20 Thread Dave Young
On Wed, 20 Sept 2023 at 18:50, Ard Biesheuvel wrote: > > On Wed, 20 Sept 2023 at 08:40, Dave Young wrote: > > > > On Wed, 20 Sept 2023 at 15:43, Dave Young wrote: > > > > > > > > In the end the only benefit this series brings is to extend the > > > > > signature checking on the whole UKI except

[PATCH v2] kexec: update manpage with explicit mention of clean kexec

2023-09-20 Thread Hari Bathini
While the manpage does mention about kexec boot with a clean shutdown, it is not explicit about it. Make it explicit. Signed-off-by: Hari Bathini --- Changes in v2: * Replaced "your linux distribution" with user-space. kexec/kexec.8 | 11 +-- 1 file changed, 9 insertions(+), 2

Re: [PATCH 0/7] Kexec-tools: Improve RISC-V port

2023-09-20 Thread Simon Horman
On Fri, Sep 15, 2023 at 11:50:06AM +0800, Song Shuai wrote: > Hi, > > This series is created to improve RISC-V port of kexec-tools, > and is based on the horms/kexec-tools:build-test-riscv-v2 branch. In my mind the big question is how to move RISC-V support from that branch, to being merged into

Re: [PATCH -next] crash_core: Remove duplicated include in crash_core.c

2023-09-20 Thread Simon Horman
On Fri, Sep 15, 2023 at 01:58:44PM +0800, Yang Li wrote: > ./kernel/crash_core.c: linux/kexec.h is included more than once. > > Signed-off-by: Yang Li FWIIW, this seems to have been added recently, by 926f75c8a5ab ("Add linux-next specific files for 20230920") Review

Re: [PATCH v1 0/2] zboot: enable kexec_load for zboot kernel images

2023-09-20 Thread Simon Horman
On Thu, Sep 14, 2023 at 04:49:58PM +0800, Dave Young wrote: > The current kexec-tools only support kexec_file_load for zboot kernel > images on arm64. > > This series tweak a bit of the code so kexec_load can also load zboot > images on both arm64 and loongarch. Thanks, applied.

Re: [PATCH] kexec: update manpage with explicit mention of clean kexec

2023-09-20 Thread Simon Horman
On Mon, Sep 11, 2023 at 12:04:08PM +0530, Hari Bathini wrote: > > > On 28/08/23 3:12 pm, Baoquan He wrote: > > On 08/28/23 at 09:48am, Simon Horman wrote: > > > On Mon, Aug 28, 2023 at 11:46:14AM +0530, Hari Bathini wrote: > > > > Any comments on this, please.. > > > > > > Hi Hari, > > > > > >

Re: [PATCH v2 0/2] x86/kexec: UKI Support

2023-09-20 Thread Ard Biesheuvel
On Wed, 20 Sept 2023 at 08:40, Dave Young wrote: > > On Wed, 20 Sept 2023 at 15:43, Dave Young wrote: > > > > > > In the end the only benefit this series brings is to extend the > > > > signature checking on the whole UKI except of just the kernel image. > > > > Everything else can also be done

Re: [PATCH v2 0/2] x86/kexec: UKI Support

2023-09-20 Thread Dave Young
On Wed, 20 Sept 2023 at 15:43, Dave Young wrote: > > > > In the end the only benefit this series brings is to extend the > > > signature checking on the whole UKI except of just the kernel image. > > > Everything else can also be done in user space. Compared to the > > > problems described above

Re: [PATCH v2 0/2] x86/kexec: UKI Support

2023-09-20 Thread Dave Young
> > In the end the only benefit this series brings is to extend the > > signature checking on the whole UKI except of just the kernel image. > > Everything else can also be done in user space. Compared to the > > problems described above this is a very small gain for me. > > Correct. That is the