Re: [PATCH v2 02/14] crash: split vmcoreinfo exporting code out from crash_core.c

2024-02-21 Thread Baoquan He
On 02/21/24 at 11:07pm, Sourabh Jain wrote: > Hello Baoquan, > > On 19/01/24 20:22, Baoquan He wrote: > > Now move the relevant codes into separate files: > > kernel/crash_reserve.c, include/linux/crash_reserve.h. > > > > And add config item CRASH_RESERVE to control its enabling. > > Feels like

Re: [PATCH v2] kexec: copy only happens before uchunk goes to zero

2024-02-21 Thread Baoquan He
On 02/20/24 at 10:11am, yang.zhang wrote: > From: "yang.zhang" > > When load segments, all of the copying and the rest > only happens before uchunk goes to zero. The code change looks good, while the log can be improved with more details so that people can more easily get what's wrong and

Re: [PATCH v2 00/14] Split crash out from kexec and clean up related config items

2024-02-21 Thread Baoquan He
On 02/21/24 at 12:57pm, Andrew Morton wrote: > On Wed, 21 Feb 2024 11:15:00 +0530 Hari Bathini > wrote: > > > On 04/02/24 8:56 am, Baoquan He wrote: > > >>> Hope Hari and Pingfan can help have a look, see if > > >>> it's doable. Now, I make it either have both kexec and crash enabled, or > >

Re: [PATCH v2 00/14] Split crash out from kexec and clean up related config items

2024-02-21 Thread Hari Bathini
On 22/02/24 2:27 am, Andrew Morton wrote: On Wed, 21 Feb 2024 11:15:00 +0530 Hari Bathini wrote: On 04/02/24 8:56 am, Baoquan He wrote: Hope Hari and Pingfan can help have a look, see if it's doable. Now, I make it either have both kexec and crash enabled, or disable both of them

Re: [PATCH v16 2/5] crash: add a new kexec flag for hotplug support

2024-02-21 Thread Sourabh Jain
On 22/02/24 09:28, Baoquan He wrote: On 02/22/24 at 09:01am, Sourabh Jain wrote: Hello Baoquan, There are a lot of code movements introduced by your patch series, 'Split crash out from kexec and clean up related config items.'

Re: [PATCH v16 2/5] crash: add a new kexec flag for hotplug support

2024-02-21 Thread Baoquan He
On 02/22/24 at 09:01am, Sourabh Jain wrote: > Hello Baoquan, > > There are a lot of code movements introduced by your patch series, 'Split > crash out from kexec and clean up related config items.' > > https://lore.kernel.org/all/20240221125752.36fbfe9c307496313198b...@linux-foundation.org/ > >

Re: [PATCH v16 2/5] crash: add a new kexec flag for hotplug support

2024-02-21 Thread Sourabh Jain
Hello Baoquan, There are a lot of code movements introduced by your patch series, 'Split crash out from kexec and clean up related config items.' https://lore.kernel.org/all/20240221125752.36fbfe9c307496313198b...@linux-foundation.org/ Do you want me to rebase this patch series on top of the

Re: [PATCH v8 06/15] x86: Add early SHA support for Secure Launch early measurements

2024-02-21 Thread Andrew Cooper
On 15/02/2024 8:17 am, Ard Biesheuvel wrote: > On Wed, 14 Feb 2024 at 23:31, Ross Philipson > wrote: >> From: "Daniel P. Smith" >> >> The SHA algorithms are necessary to measure configuration information into >> the TPM as early as possible before using the values. This implementation >> uses

Re: [PATCH v8 04/15] x86: Secure Launch Resource Table header file

2024-02-21 Thread ross . philipson
On 2/21/24 6:03 PM, 'Andrew Cooper' via trenchboot-devel wrote: On 15/02/2024 8:08 am, Ard Biesheuvel wrote: On Wed, 14 Feb 2024 at 23:31, Ross Philipson wrote: +/* + * Primary SLR Table Header I know it's just a comment, but SLR ought to be written in longhand here. Will do, thanks.

Re: [PATCH v8 04/15] x86: Secure Launch Resource Table header file

2024-02-21 Thread Andrew Cooper
On 15/02/2024 8:08 am, Ard Biesheuvel wrote: > On Wed, 14 Feb 2024 at 23:31, Ross Philipson > wrote: >> +/* >> + * Primary SLR Table Header I know it's just a comment, but SLR ought to be written in longhand here. >> + */ >> +struct slr_table { >> + u32 magic; >> + u16 revision; >>

Re: [PATCH v5 5/8] ima: kexec: move IMA log copy from kexec load to execute

2024-02-21 Thread Mimi Zohar
> @@ -195,7 +181,34 @@ void ima_add_kexec_buffer(struct kimage *image) > static int ima_update_kexec_buffer(struct notifier_block *self, > unsigned long action, void *data) > { > - return NOTIFY_OK; > + void *buf = NULL; > + size_t buf_size; > +

Re: [PATCH v8 15/15] x86: EFI stub DRTM launch support for Secure Launch

2024-02-21 Thread Ard Biesheuvel
On Wed, 21 Feb 2024 at 21:37, H. Peter Anvin wrote: > > On February 21, 2024 12:17:30 PM PST, ross.philip...@oracle.com wrote: > >On 2/15/24 1:01 AM, Ard Biesheuvel wrote: > >> On Wed, 14 Feb 2024 at 23:32, Ross Philipson > >> wrote: > >>> > >>> This support allows the DRTM launch to be

Re: [PATCH v5 4/8] ima: kexec: define functions to copy IMA log at soft boot

2024-02-21 Thread Mimi Zohar
Additional comments ... > diff --git a/security/integrity/ima/ima_kexec.c > b/security/integrity/ima/ima_kexec.c > index ccb072617c2d..1d4d6c122d82 100644 > --- a/security/integrity/ima/ima_kexec.c > +++ b/security/integrity/ima/ima_kexec.c > @@ -12,10 +12,14 @@ > #include > #include >

Re: [PATCH v5 4/8] ima: kexec: define functions to copy IMA log at soft boot

2024-02-21 Thread Mimi Zohar
On Wed, 2024-02-14 at 22:55 -0800, Tushar Sugandhi wrote: > > On 2/14/24 12:47, Stefan Berger wrote: > > > > On 2/14/24 10:38, Tushar Sugandhi wrote: > ... > > ... > > > +void kimage_file_post_load(struct kimage *image) > > > +{ > > > +ima_kexec_post_load(image); > > > +} > > > + > > > >

Re: [PATCH v2 00/14] Split crash out from kexec and clean up related config items

2024-02-21 Thread Andrew Morton
On Wed, 21 Feb 2024 11:15:00 +0530 Hari Bathini wrote: > On 04/02/24 8:56 am, Baoquan He wrote: > >>> Hope Hari and Pingfan can help have a look, see if > >>> it's doable. Now, I make it either have both kexec and crash enabled, or > >>> disable both of them altogether. > >> > >> Sure. I will

Re: [PATCH v8 15/15] x86: EFI stub DRTM launch support for Secure Launch

2024-02-21 Thread H. Peter Anvin
On February 21, 2024 12:17:30 PM PST, ross.philip...@oracle.com wrote: >On 2/15/24 1:01 AM, Ard Biesheuvel wrote: >> On Wed, 14 Feb 2024 at 23:32, Ross Philipson >> wrote: >>> >>> This support allows the DRTM launch to be initiated after an EFI stub >>> launch of the Linux kernel is done. This

Re: [PATCH 2/2] x86/snp: Convert shared memory back to private on kexec

2024-02-21 Thread Tom Lendacky
On 2/19/24 19:18, Ashish Kalra wrote: From: Ashish Kalra SNP guests allocate shared buffers to perform I/O. It is done by allocating pages normally from the buddy allocator and converting them to shared with set_memory_decrypted(). The second kernel has no idea what memory is converted this

Re: [PATCH v5 2/8] kexec: define functions to map and unmap segments

2024-02-21 Thread Mimi Zohar
On Wed, 2024-02-14 at 07:38 -0800, Tushar Sugandhi wrote: > Currently, the mechanism to map and unmap segments to the kimage > structure is not available to the subsystems outside of kexec. This > functionality is needed when IMA is allocating the memory segments > during kexec 'load' operation.

Re: [PATCH v8 15/15] x86: EFI stub DRTM launch support for Secure Launch

2024-02-21 Thread ross . philipson
On 2/15/24 1:01 AM, Ard Biesheuvel wrote: On Wed, 14 Feb 2024 at 23:32, Ross Philipson wrote: This support allows the DRTM launch to be initiated after an EFI stub launch of the Linux kernel is done. This is accomplished by providing a handler to jump to when a Secure Launch is in progress.

Re: [PATCH v2 01/14] kexec: split crashkernel reservation code out from crash_core.c

2024-02-21 Thread Andrew Morton
On Wed, 21 Feb 2024 22:59:47 +0530 Sourabh Jain wrote: > > config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION > > - def_bool CRASH_CORE > > + def_bool CRASH_RESEERVE > > %s/CRASH_RESEERVE/CRASH_RESERVE? Yes, thanks, this has been addressed in a followon fixup patch in the mm.git tree.

Re: [PATCH v2 02/14] crash: split vmcoreinfo exporting code out from crash_core.c

2024-02-21 Thread Sourabh Jain
Hello Baoquan, On 19/01/24 20:22, Baoquan He wrote: Now move the relevant codes into separate files: kernel/crash_reserve.c, include/linux/crash_reserve.h. And add config item CRASH_RESERVE to control its enabling. Feels like this patch is more about vmcore_info.[c|h] and CONFIG_VMCORE_INFO

Re: [PATCH v2 01/14] kexec: split crashkernel reservation code out from crash_core.c

2024-02-21 Thread Sourabh Jain
Hello Baoquan, Thank you for reorganizing the kexec and kdump code with a well-defined configuration structure. While reviewing the patch series, I noticed a few typos. On 19/01/24 20:22, Baoquan He wrote: Both kdump and fa_dump of ppc rely on crashkernel reservation. Move the relevant codes

Re: [PATCHv7 07/16] x86/mm: Return correct level from lookup_address() if pte is none

2024-02-21 Thread Kirill A. Shutemov
On Wed, Feb 21, 2024 at 10:37:29AM +0800, Baoquan He wrote: > > diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c > > index 3612e3167147..425ff6e192e6 100644 > > --- a/arch/x86/mm/pat/set_memory.c > > +++ b/arch/x86/mm/pat/set_memory.c > > @@ -657,7 +657,8 @@ static inline

Re: [PATCH v2 00/14] Split crash out from kexec and clean up related config items

2024-02-21 Thread Baoquan He
On 02/21/24 at 11:15am, Hari Bathini wrote: > Hi Baoquan, > > On 04/02/24 8:56 am, Baoquan He wrote: > > > > Hope Hari and Pingfan can help have a look, see if > > > > it's doable. Now, I make it either have both kexec and crash enabled, or > > > > disable both of them altogether. > > > > > >

Należność za fakturę

2024-02-21 Thread Tomasz Wawrzyniak
Dzień dobry, chciałbym poinformować o możliwości wydłużenia Państwa spłaty za towar. Mogą Państwo złożyć zamówienie u swojego dostawcy za które my zapłacimy we wskazanym przez niego terminie. Po wpłacie wystawiamy Państwu fv sprzedaży z odroczonym terminem płatności (30-90 dni). Jeśli takie