Re: [PATCH v8 01/15] x86/boot: Place kernel_info at a fixed offset

2024-02-15 Thread Daniel Kiper
On Thu, Feb 15, 2024 at 08:56:25AM +0100, Ard Biesheuvel wrote: > On Wed, 14 Feb 2024 at 23:31, Ross Philipson > wrote: > > > > From: Arvind Sankar > > > > There are use cases for storing the offset of a symbol in kernel_info. > > For example, the trenchboot series [0] needs to store the offset

Re: [RFC v1] kexec: Prototype for signature verification within Xen

2019-01-15 Thread Daniel Kiper
On Tue, Jan 15, 2019 at 03:15:28PM +0100, Simon Horman wrote: > On Mon, Jan 14, 2019 at 01:52:07PM -0600, Eric DeVolder wrote: > > These changes work in conjunction with the signature > > verification support for Xen I published recently. > > > > Prior to this change, kexec supported the following

Re: [Xen-devel] RFC Xen signature verification for kexec

2018-04-24 Thread Daniel Kiper
On Tue, Apr 24, 2018 at 10:46:38AM +0100, George Dunlap wrote: > On Mon, Apr 23, 2018 at 11:33 AM, Jan Beulich wrote: > On 23.04.18 at 12:25, wrote: > >> On Mon, Apr 23, 2018 at 12:55:45AM -0600, Jan Beulich wrote: > >>> >>> On 20.04.18 at 21:12,

Re: [Xen-devel] RFC Xen signature verification for kexec

2018-04-23 Thread Daniel Kiper
On Mon, Apr 23, 2018 at 12:55:45AM -0600, Jan Beulich wrote: > >>> On 20.04.18 at 21:12, wrote: > > Two options for signature verification in Xen > > > > This proposal outlines two options under consideration for enhancing > > Xen to support signature verification of

Re: [PATCH v4] kexec-tools: Make xc_dlhandle static

2018-01-25 Thread Daniel Kiper
On Thu, Jan 25, 2018 at 09:06:52AM +0100, Simon Horman wrote: > On Wed, Jan 24, 2018 at 08:26:32PM +0100, Daniel Kiper wrote: > > On Wed, Jan 24, 2018 at 01:20:21PM -0600, Eric DeVolder wrote: > > > This patch is a follow-on to commit 894bea93 "kexec-tools: Perform

Re: [PATCH v4] kexec-tools: Make xc_dlhandle static

2018-01-24 Thread Daniel Kiper
On Wed, Jan 24, 2018 at 01:20:21PM -0600, Eric DeVolder wrote: > This patch is a follow-on to commit 894bea93 "kexec-tools: Perform > run-time linking of libxenctrl.so". This patch addresses feedback > from Daniel Kiper. > > This patch implements Daniel's suggestion

Re: [PATCH v3] kexec-tools: Make xc_dlhandle static

2018-01-24 Thread Daniel Kiper
On Wed, Jan 24, 2018 at 12:04:34PM -0600, Eric DeVolder wrote: > This patch is a follow-on to commit 894bea93 "kexec-tools: Perform > run-time linking of libxenctrl.so". This patch addresses feedback > from Daniel Kiper. > > This patch implements Daniel's suggestion

Re: [PATCH v2 2/2] kexec-tools: Make xc_dlhandle static

2018-01-23 Thread Daniel Kiper
On Tue, Jan 23, 2018 at 01:12:51PM -0600, Eric DeVolder wrote: > This patch is a follow-on to commit 43d3932e "kexec-tools: Perform > run-time linking of libxenctrl.so". This patch addresses feedback > from Daniel Kiper. > > This patch implements Daniel's suggestion

Re: [PATCH v2 1/2] kexec-tools: Call dlclose() from within __xc_interface_close()

2018-01-23 Thread Daniel Kiper
On Tue, Jan 23, 2018 at 01:12:50PM -0600, Eric DeVolder wrote: > This patch is a follow-on to commit 43d3932e "kexec-tools: Perform > run-time linking of libxenctrl.so". This patch addresses feedback > from Daniel Kiper. > > In the original patch, the call to dlclose()

Re: [PATCH v1] kexec-tools: Tweak run-time handling of libxenctrl.so

2018-01-23 Thread Daniel Kiper
Hi Eric, On Tue, Jan 23, 2018 at 11:39:29AM -0600, Eric DeVolder wrote: > This patch is a follow-on to commit 43d3932e "kexec-tools: Perform > run-time linking of libxenctrl.so". This patch addresses feedback > from Daniel Kiper concerning the lack of a dlclose() and t

Re: [PATCH v4] kexec-tools: Perform run-time linking of libxenctrl.so

2018-01-18 Thread Daniel Kiper
On Wed, Jan 17, 2018 at 10:39:01AM -0600, Eric DeVolder wrote: > When kexec is utilized in a Xen environment, it has an explicit > run-time dependency on libxenctrl.so. This dependency occurs > during the configure stage and when building kexec-tools. [...] As I saw Simon applied the patch.

Re: [PATCH v3] kexec-tools: Perform run-time linking of libxenctrl.so

2018-01-16 Thread Daniel Kiper
ed in a non-Xen environment (either bare > metal or KVM), the configure and build of kexec-tools omits > any reference to libxenctrl.so. [...] Wow! What a long story! Patch looks quite good. Just a few nitpicks. If you fix them then you can add Reviewed-by: Daniel Kiper <daniel.ki...@oracle.

Re: [PATCH v2] kexec-tools: Perform run-time linking of libxenctrl.so

2017-12-18 Thread Daniel Kiper
tly this feature is enabled with the following: > > ./configure --with-xen-dl --with-xen=no > > This is a bit clunky. I welcome feedback such as better names > and/or usage of --with, as well as if we might make this feature > the default. I would do it in a bit different way

Re: [PATCH v1] kexec-tools: Perform run-time linking of libxenctrl.so

2017-12-06 Thread Daniel Kiper
On Wed, Nov 29, 2017 at 10:45:16AM -0600, Eric DeVolder wrote: > When kexec is utilized in a Xen environment, it has an explicit > run-time dependency on libxenctrl.so. This dependency occurs > during the configure stage and when building kexec-tools. > > When kexec is utilized in a non-Xen

Re: [PATCH v1] kexec-tools: Perform run-time linking of libxenctrl.so

2017-11-30 Thread Daniel Kiper
On Wed, Nov 29, 2017 at 10:45:16AM -0600, Eric DeVolder wrote: > When kexec is utilized in a Xen environment, it has an explicit > run-time dependency on libxenctrl.so. This dependency occurs > during the configure stage and when building kexec-tools. > > When kexec is utilized in a non-Xen

Re: [makedumpfile PATCH] Wipe excluded pages that are written into ELF dump file

2017-07-31 Thread Daniel Kiper
On Mon, Jul 31, 2017 at 06:35:30AM -0700, Eric DeVolder wrote: > When a page is excluded by any of the existing dump levels, > that page may still be written to the ELF dump file, depending > upon the PFN_EXCLUDED mechanism. > > The PFN_EXCLUDED mechanism looks for N consecutive "not > dumpable"

Re: [makedumpfile PATCH v2] Prevent data loss in last page of ELF core dumpfile

2017-07-05 Thread Daniel Kiper
On Wed, Jul 05, 2017 at 12:13:22PM -0500, Eric DeVolder wrote: > When generating an ELF core dump file, if a segment size > is not an exact multiple of PAGE_SIZE, then the corresponding > generated segment is erroneously truncated to a PAGE_SIZE multiple. > Thus a small loss of data up to

Re: makedumpfile PATCH] Fix the use of Xen physical and machine addresses

2017-05-31 Thread Daniel Kiper
On Tue, May 30, 2017 at 11:28:15PM +0200, Petr Tesarik wrote: > On Tue, 30 May 2017 14:30:43 -0500 > Eric DeVolder wrote: > > > Hi, > > Testing is underway. Generally working but I do have a couple of fails > > I'm looking into: > > > > > FAIL

Re: [Crash-utility] [PATCH] xen: Add support for domU with Linux kernel 3.19 and newer

2017-05-29 Thread Daniel Kiper
translated again. > > * Endless loop starts from here. > > */ > > xen_m2p(machine=0x581b7e000) > > __xen_m2p(machine=0x581b7e000, mfn=0x581b7e) > > readmem(addr=0xc91f5000) > > > > Fortunately, PV domU p2m mapping is also stored at xd->xfd + > > xc

[ptesa...@suse.cz: [makedumpfile PATCH] Fix the use of Xen physical and machine addresses]

2017-05-23 Thread Daniel Kiper
0 From: Petr Tesarik <ptesa...@suse.cz> To: Atsushi Kumagai <ats-kuma...@wm.jp.nec.com> Cc: kexec@lists.infradead.org, Daniel Kiper <daniel.ki...@oracle.com> Subject: [makedumpfile PATCH] Fix the use of Xen physical and machine addresses X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.3

Re: [PATCH v0] Fix broken Xen support in configure.ac

2017-04-07 Thread Daniel Kiper
abling support for Xen altogether due to the > missing HAVE_LIBXENCTRL=1. This corrects the broken behavior > while still maintaining the original intention of detecting > support for kexec_status() call. In general Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> but two nitpicks.

[PATCH] crashdump: Remove stray get_crashkernel_region() declaration

2017-03-16 Thread Daniel Kiper
Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/crashdump.h |1 - 1 file changed, 1 deletion(-) diff --git a/kexec/crashdump.h b/kexec/crashdump.h index 96219a8..86e1ef2 100644 --- a/kexec/crashdump.h +++ b/kexec/crashdump.h @@ -1,7 +1,6 @@ #ifndef CRASHDUMP_H #

Re: [PATCH v5 00/11] kexec: Add option to get crash kernel region size

2017-03-02 Thread Daniel Kiper
On Thu, Mar 02, 2017 at 10:51:51AM +0100, Simon Horman wrote: > On Fri, Feb 17, 2017 at 04:47:14PM -0600, Eric DeVolder wrote: > > This is the fifth version of a patch series originally posted by > > Daniel Kiper on December 5. > > Thanks, applied.

Re: [PATCH v2] gitignore: add two generated files in purgatory

2017-02-21 Thread Daniel Kiper
On Tue, Feb 21, 2017 at 10:18:24AM -0600, Eric DeVolder wrote: > This patch adds the two generated files below to .gitignore, > so that 'git status' does not complain about them. This is not a problem. Do you have issues during 'git checkout' or so? If yes then I think it is worth considering.

Re: [PATCH v4 11/11] kexec: Add option to get crash kernel region size

2017-02-14 Thread Daniel Kiper
On Tue, Feb 14, 2017 at 03:09:23PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Crash kernel region size is available via sysfs on Linux running on > bare metal. However, this does not work when Linux runs as Xen dom0. > In this case Xen cra

Re: [PATCH v4 07/11] crashdump/ppc: Add get_crash_kernel_load_range() function

2017-02-14 Thread Daniel Kiper
On Tue, Feb 14, 2017 at 03:09:19PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Implement get_crash_kernel_load_range() in support of > print crash kernel region size option. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com>

Re: [PATCH v3 11/11] kexec: Add option to get crash kernel region size

2017-02-13 Thread Daniel Kiper
On Fri, Feb 10, 2017 at 04:07:42PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > From: Daniel Kiper <daniel.ki...@oracle.com> Hmmm... One is sufficient... > Crash kernel region size is available via sysfs on Linux running on > bar

Re: [PATCH v3 08/11] crashdump/ppc64: Add get_crash_kernel_load_range() function

2017-02-13 Thread Daniel Kiper
On Fri, Feb 10, 2017 at 04:07:39PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Implement get_crash_kernel_load_range() in support of > print crash kernel region size option. Most of comments for #07 applies

Re: [PATCH v3 07/11] crashdump/ppc: Add get_crash_kernel_load_range() function

2017-02-13 Thread Daniel Kiper
On Fri, Feb 10, 2017 at 04:07:38PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Implement get_crash_kernel_load_range() in support of > print crash kernel region size option. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com>

Re: [PATCH v3 05/11] crashdump/m68k: Add get_crash_kernel_load_range() function

2017-02-13 Thread Daniel Kiper
On Fri, Feb 10, 2017 at 04:07:36PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Implement get_crash_kernel_load_range() in support of > print crash kernel region size option. Ditto. Daniel ___ kexec

Re: [PATCH v3 03/11] crashdump/cris: Add get_crash_kernel_load_range() function

2017-02-13 Thread Daniel Kiper
On Fri, Feb 10, 2017 at 04:07:34PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Implement get_crash_kernel_load_range() in support of > print crash kernel region size option. Ditto. Daniel ___ kexec

Re: [PATCH v3 02/11] crashdump/arm64: Add get_crash_kernel_load_range() function

2017-02-13 Thread Daniel Kiper
art, uint64_t *end) > +{ > + /* Crash kernel region size is not exposed by the system */ Usually I add a full stop at the end of comment. Just my preference. Otherwise: Reviewed-by: Daniel Kiper <daniel.ki...@oracle.com> Daniel ___ kexec m

Re: [PATCH v2 12/12] kexec: Add option to get crash kernel region size

2017-02-07 Thread Daniel Kiper
ser space. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > Signed-off-by: Eric DeVolder <eric.devol...@oracle.com> I think that patch #11 and #12 should be merged into one thing like it was in my original series. Daniel __

Re: [PATCH v2 08/12] crashdump/ppc64: Add print_crashkernel_region_size() function

2017-02-07 Thread Daniel Kiper
On Mon, Feb 06, 2017 at 01:42:20PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Follow similar x86 patch. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > Signed-off-by: Eric DeVolder <eric.devol...@oracle.com>

Re: [PATCH v2 07/12] crashdump/ppc: Add print_crashkernel_region_size() function

2017-02-07 Thread Daniel Kiper
On Mon, Feb 06, 2017 at 01:42:19PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Follow similar x86 patch. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > Signed-off-by: Eric DeVolder <eric.devol...@oracle.com&g

Re: [PATCH v2 05/12] crashdump/m68k: Add print_crashkernel_region_size() function

2017-02-07 Thread Daniel Kiper
On Mon, Feb 06, 2017 at 01:42:17PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Provide just print_crashkernel_region_size() stub. This way > we can properly build kexec utility on m68k arch even > if the functionality is not available

Re: [PATCH v2 03/12] crashdump/cris: Add print_crashkernel_region_size() function

2017-02-07 Thread Daniel Kiper
On Mon, Feb 06, 2017 at 01:42:15PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Provide just print_crashkernel_region_size() stub. This way > we can properly build kexec utility on cris arch even > if the functionality is not available

Re: [PATCH v2 01/12] crashdump/x86: Add print_crashkernel_region_size() function

2017-02-07 Thread Daniel Kiper
On Mon, Feb 06, 2017 at 01:42:13PM -0600, Eric DeVolder wrote: > From: Daniel Kiper <daniel.ki...@oracle.com> > > Crash kernel region size is available via sysfs on Linux running on > bare metal. However, this does not work when Linux runs as Xen dom0. > In this case Xen cra

Re: [PATCH v2 00/12] crashdump: Add print_crashkernel_region_size() function

2017-02-07 Thread Daniel Kiper
ther archs supported by kexec-tools. Last patch > of this series will export this functionality to the userspace via > separate kexec utility option. > > Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> > Signed-off-by: Eric DeVolder <eric.devol...@oracle.com> This does n

Re: [PATCH v4] kexec: implemented XEN KEXEC STATUS to determine if an image is loaded

2017-01-26 Thread Daniel Kiper
On Thu, Jan 26, 2017 at 11:22:19AM +0100, Simon Horman wrote: > On Thu, Jan 26, 2017 at 12:02:48AM +0100, Daniel Kiper wrote: > > On Wed, Jan 25, 2017 at 09:31:15AM -0600, Eric DeVolder wrote: > > > > [...] > > > > > diff --git a/kexec/kexec.c b/kexec/kexec.c

Re: [PATCH v4] kexec: implemented XEN KEXEC STATUS to determine if an image is loaded

2017-01-25 Thread Daniel Kiper
On Wed, Jan 25, 2017 at 09:31:15AM -0600, Eric DeVolder wrote: [...] > diff --git a/kexec/kexec.c b/kexec/kexec.c > index 500e5a9..ec16247 100644 > --- a/kexec/kexec.c > +++ b/kexec/kexec.c > @@ -51,6 +51,9 @@ > #include "kexec-lzma.h" > #include > > +#define KEXEC_LOADED_PATH

Re: [PATCH v3] kexec: implemented XEN KEXEC STATUS to determine if an image is loaded

2017-01-25 Thread Daniel Kiper
On Tue, Jan 24, 2017 at 04:47:09PM -0600, Eric DeVolder wrote: > On 01/24/2017 01:16 PM, Daniel Kiper wrote: > >On Tue, Jan 24, 2017 at 12:55:35PM -0600, Eric DeVolder wrote: [...] > >>diff --git a/kexec/kexec.c b/kexec/kexec.c > >>index 500e5a9..defbbe3 100644 > &

Re: [PATCH v3] kexec: implemented XEN KEXEC STATUS to determine if an image is loaded

2017-01-25 Thread Daniel Kiper
On Tue, Jan 24, 2017 at 04:37:27PM -0600, Eric DeVolder wrote: > On 01/24/2017 01:16 PM, Daniel Kiper wrote: > >On Tue, Jan 24, 2017 at 12:55:35PM -0600, Eric DeVolder wrote: [...] > >>diff --git a/configure.ac b/configure.ac > >>index 3044185..c6e864b 100644 >

Re: [PATCH v2] kexec: implemented XEN KEXEC STATUS to determine if an image is loaded

2017-01-23 Thread Daniel Kiper
ives/html/xen-devel/2017-01/msg01570.html > > > > CC: Andrew Cooper <andrew.coop...@citrix.com> > > CC: kexec@lists.infradead.org > > CC: xen-de...@lists.xenproject.org > > CC: Daniel Kiper <daniel.ki...@oracle.com> > > > > v0: First versio

Re: [PATCH v1 1/2] xen/kexec: Find out whether an kexec type is loaded.

2016-11-15 Thread Daniel Kiper
M as it has one size fits all > check and does not check for subcommands. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.w...@oracle.com> > --- > v0: Internal version. > v1: Dropped Reviewed-by, posting on xen-devel. > > CC: Elena Ufimtseva <elena.ufimts...@oracle.

Re: [Xen-devel] [PATCH] xen: Add support for dom0 with Linux kernel 3.19 and newer

2016-01-22 Thread Daniel Kiper
On Fri, Jan 22, 2016 at 10:03:34AM +, David Vrabel wrote: > On 21/01/16 20:13, Daniel Kiper wrote: > > Linux kernel commit 054954eb051f35e74b75a566a96fe756015352c8 > > (xen: switch to linear virtual mapped sparse p2m list), which > > appeared in 3.19, introduced linear

[PATCH] xen: Add support for dom0 with Linux kernel 3.19 and newer

2016-01-21 Thread Daniel Kiper
crash_xen_info_t.dom0_pfn_to_mfn_frame_list_list which is available out of the box. So, let's use it and make at least some users happy. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kernel.c | 81 ++-- xen_dom0.c |3 ++- xen_dom0.h |2

[PATCH 04/14] crashdump/x86: Add print_crashkernel_region_size() function

2015-12-08 Thread Daniel Kiper
Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/i386/crashdump-x86.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/kexec/arch/i386/crashdump-x86.c b/kexec/arch/i386/crashdump-x86.c index bbc0f35..10a56a8 100644 --- a/kexec/arch/i386/crash

[PATCH 02/14] kexec: Remove redundant space from help message

2015-12-08 Thread Daniel Kiper
Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/kexec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kexec/kexec.c b/kexec/kexec.c index f0bd527..20dd93d 100644 --- a/kexec/kexec.c +++ b/kexec/kexec.c @@ -969,7 +969,7 @@ void usag

[PATCH 00/14] kexec: Add option to get crash kernel region size

2015-12-08 Thread Daniel Kiper
insertions(+), 5 deletions(-) Daniel Kiper (14): purgatory: Add purgatory.map and purgatory.ro.sym to clean recipe kexec: Remove redundant space from help message crashdump: Remove stray get_crashkernel_region() declaration crashdump/x86: Add print_crashkernel_region_size(

[PATCH 12/14] crashdump/s390: Add print_crashkernel_region_size() function

2015-12-08 Thread Daniel Kiper
Follow similar x86 patch. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/s390/kexec-s390.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/kexec/arch/s390/kexec-s390.c b/kexec/arch/s390/kexec-s390.c index 074575e..212a64f 100644 --- a/kexec/arch/s390

[PATCH 01/14] purgatory: Add purgatory.map and purgatory.ro.sym to clean recipe

2015-12-08 Thread Daniel Kiper
Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- purgatory/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/purgatory/Makefile b/purgatory/Makefile index 2b5c061..caea7ea 100644 --- a/purgatory/Makefile +++ b/purgatory/Makefile @@ -33,7

[PATCH 09/14] crashdump/mips: Add print_crashkernel_region_size() function

2015-12-08 Thread Daniel Kiper
Follow similar x86 patch. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/mips/crashdump-mips.c |9 + 1 file changed, 9 insertions(+) diff --git a/kexec/arch/mips/crashdump-mips.c b/kexec/arch/mips/crashdump-mips.c index dc68cb4..450fa13 100644 --- a/kexe

[PATCH 07/14] crashdump/ia64: Add print_crashkernel_region_size() function

2015-12-08 Thread Daniel Kiper
Follow similar x86 patch. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/ia64/crashdump-ia64.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/kexec/arch/ia64/crashdump-ia64.c b/kexec/arch/ia64/crashdump-ia64.c index 726c9f4..07de42a 100644 --- a

[PATCH 14/14] kexec: Add option to get crash kernel region size

2015-12-08 Thread Daniel Kiper
Here print_crashkernel_region_size() function is available on all archs (even if the functionality is not implemented on some). So, we can safely use it in arch independent code and export the functionality to the user space. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec

[PATCH 06/14] crashdump/cris: Add print_crashkernel_region_size() function

2015-12-08 Thread Daniel Kiper
Provide just print_crashkernel_region_size() stub. This way we can properly build kexec utility on cris arch even if the functionality is not available on it. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/cris/kexec-cris.c |5 + 1 file changed, 5 inse

[PATCH 10/14] crashdump/ppc: Add print_crashkernel_region_size() function

2015-12-08 Thread Daniel Kiper
Provide just print_crashkernel_region_size() stub. This way we can properly build kexec utility on ppc arch even if the functionality is not available on it. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/ppc/crashdump-powerpc.c |4 1 file changed, 4 inse

[PATCH 08/14] crashdump/m68k: Add print_crashkernel_region_size() function

2015-12-08 Thread Daniel Kiper
Provide just print_crashkernel_region_size() stub. This way we can properly build kexec utility on m68k arch even if the functionality is not available on it. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/m68k/kexec-m68k.c |5 + 1 file changed, 5 inse

[PATCH 05/14] crashdump/arm: Add print_crashkernel_region_size() function

2015-12-08 Thread Daniel Kiper
Follow similar x86 patch. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/arm/crashdump-arm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/kexec/arch/arm/crashdump-arm.c b/kexec/arch/arm/crashdump-arm.c index b523e5f..b3e93ad 100644 --- a/kexec/ar

[PATCH 11/14] crashdump/ppc64: Add print_crashkernel_region_size() function

2015-12-08 Thread Daniel Kiper
Provide just print_crashkernel_region_size() stub. This way we can properly build kexec utility on ppc64 arch even if the functionality is not available on it. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/ppc64/crashdump-ppc64.c |5 + 1 file changed, 5 inse

[PATCH 13/14] crashdump/sh: Add print_crashkernel_region_size() function

2015-12-08 Thread Daniel Kiper
Follow similar x86 patch. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/sh/crashdump-sh.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/kexec/arch/sh/crashdump-sh.c b/kexec/arch/sh/crashdump-sh.c index 9e6af6b..6556eb1 100644 --- a/kexec/a

Re: [RFC PATCH] crashdump/x86: Add option to get crash kernel region size

2015-11-29 Thread Daniel Kiper
On Mon, Nov 30, 2015 at 08:55:32AM +0900, Simon Horman wrote: > On Sat, Nov 28, 2015 at 09:14:04PM +0100, Daniel Kiper wrote: > > Crash kernel region size is available via sysfs on Linux running on > > bare metal. However, this does not work when Linux runs as Xen dom0. > > I

[RFC PATCH] crashdump/x86: Add option to get crash kernel region size

2015-11-28 Thread Daniel Kiper
ctionality is available on x86 platform only. If idea is acceptable then I can prepare patches for other platforms (if it is possible and make sense) and repost them as fully flagged patch series. Signed-off-by: Daniel Kiper <daniel.ki...@oracle.com> --- kexec/arch/i386/crashdump-x86.c | 18 +

Re: [PATCH] kexec-tools: Read always one vmcoreinfo file

2014-12-19 Thread Daniel Kiper
Hi Petr, On Thu, Nov 13, 2014 at 04:51:48PM +0100, Petr Tesarik wrote: Hi all, this thread got somehow forgotten because of vacations... Anyway, read below. [...] Due to delays in EFI + GRUB2 + Xen project I must postpone work on this a bit longer than I expected. I will check what is going

Re: [PATCH] kexec-tools: Read always one vmcoreinfo file

2014-11-13 Thread Daniel Kiper
Hi Petr, On Thu, Nov 13, 2014 at 04:51:48PM +0100, Petr Tesarik wrote: Hi all, this thread got somehow forgotten because of vacations... Anyway, read below. On Tue, 24 Jul 2012 15:54:10 +0200 Daniel Kiper daniel.ki...@oracle.com wrote: On Tue, Jul 24, 2012 at 10:18:34AM +0200, Petr

Re: [PATCH v2 3/4] makedumpfile/xen: Fail immediately on every architecture if dump level is invalid

2014-09-01 Thread Daniel Kiper
-atsu...@mxc.nes.nec.co.jp Date: Fri, 29 Aug 2014 15:11:27 +0900 Subject: [PATCH] Fix description about filtering for Xen. Correct the following points for Xen dump: - Add how to filter the pages of domain-0. - Fix the difference between man and help. Reported-by: Daniel Kiper daniel.ki

Re: [PATCH 0/4] Enable use of crash on xen 4.4.0 vmcore

2014-01-08 Thread Daniel Kiper
without any issue. Reviewed-by: Daniel Kiper daniel.ki...@oracle.com Tested-by: Daniel Kiper daniel.ki...@oracle.com Daniel ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2 3/4] makedumpfile/xen: Fail immediately on every architecture if dump level is invalid

2013-12-17 Thread Daniel Kiper
On Fri, Dec 13, 2013 at 06:59:06AM +, Atsushi Kumagai wrote: On 2013/12/10 19:41:54, kexec kexec-boun...@lists.infradead.org wrote: [...] Docs are not consistent because man and help displayed from makedumpfile are different. Additionally, even man says nothing how to use this feature

Re: [PATCH v2 3/4] makedumpfile/xen: Fail immediately on every architecture if dump level is invalid

2013-12-10 Thread Daniel Kiper
to process Xen crash dump on every architecture if dump level is invalid. Fail immediately and print relevant error message. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- makedumpfile.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 1/4] makedumpfile/xen: Add cache_init() call to initial_xen()

2013-12-02 Thread Daniel Kiper
() indirectly which refers to uninitialized structures. Hence, makedumfile run on Xen crash dumps finally fails. This patch adds cache_init() call to initial_xen() and fixes above mentioned issue. cache_init() is called in initial() if crash dump is not Xen one. Signed-off-by: Daniel Kiper daniel.ki

[PATCH v2 2/4] makedumpfile/xen: Disable cyclic mode for every Xen crash dump

2013-12-02 Thread Daniel Kiper
Disable cyclic mode for every Xen crash dump not only when -X option is used. This way makedumpfile is much more flexible and different modes could be used to dump whole system memory (e.g. zero pages could be striped without requiring -X option). Signed-off-by: Daniel Kiper daniel.ki

[PATCH v2 4/4] makedumpfile/xen: Move cyclic mode check from initial() to initial_xen()

2013-12-02 Thread Daniel Kiper
Move cyclic mode check from initial() to initial_xen(). Just small cleanup. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- makedumpfile.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/makedumpfile.c b/makedumpfile.c index 45f96aa..e173f85 100644

[PATCH v2 0/4] makedumpfile: Xen fixes and cleanups

2013-12-02 Thread Daniel Kiper
Hi, This is second version of patch series containing following makedumpfile Xen fixes and cleanups: - makedumpfile/xen: Add cache_init() call to initial_xen(), - makedumpfile/xen: Disable cyclic mode for every Xen crash dump, - makedumpfile/xen: Fail immediately on every architecture if

[PATCH 2/2] kexec-tools/xen: Remove redundant include

2013-12-02 Thread Daniel Kiper
Remove redundant include of stdlib.h introduced by commit d01680c28ba7bf1e02f74aa5841247a45738f5d4 (kexec/xen: Correct some compile errors). Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- kexec/kexec-xen.c |1 - 1 file changed, 1 deletion(-) diff --git a/kexec/kexec-xen.c b/kexec

[PATCH 0/2] kexec-tools: Minor Xen fixes and cleanups

2013-12-02 Thread Daniel Kiper
Hi, This patch series contains following minor Xen fixes and cleanups for kexec-tools: - kexec-tools/xen: Do not call xc_interface_close() if xc_interface_open() failed, - kexec-tools/xen: Remove redundant include. Please apply. Daniel ___

[PATCH 1/2] kexec-tools/xen: Do not call xc_interface_close() if xc_interface_open() failed

2013-12-02 Thread Daniel Kiper
Do not call xc_interface_close() if xc_interface_open() failed. xc_interface_close() crashes if it gets NULL as an argument. Relevant fix for libxenctrl will be posted too but kexec-tools should also behave properly. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- kexec/arch/i386

Re: [PATCH] kexec/xen: Fix typo in __i386__ preprocessor identifier

2013-11-26 Thread Daniel Kiper
...@citrix.com CC: Daniel Kiper daniel.ki...@oracle.com CC: Simon Horman ho...@verge.net.au CC: kexec@lists.infradead.org Reviewed-by: Daniel Kiper daniel.ki...@oracle.com Daniel ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org

[PATCH 1/3] makedumpfile/xen: Move Xen crash dump check

2013-11-26 Thread Daniel Kiper
() indirectly which refers to uninitialized structures. Hence, makedumfile run on Xen crash dumps finally fails. This patch moves initial_xen() behind cache_init() call and fixes above mentioned issue. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- makedumpfile.c |5 + 1 file changed

[PATCH 0/3] makedumpfile: Xen fixes

2013-11-26 Thread Daniel Kiper
Hi, This patch series contains following makedumpfile Xen fixes: - makedumpfile/xen: Move Xen crash dump check, - makedumpfile/xen: Disable cyclic mode for every Xen crash dump, - makedumpfile/xen: Fail immediately if dump level is invalid. All patches were tested with Xen versions up to

[PATCH 3/3] makedumpfile/xen: Fail immediately if dump level is invalid

2013-11-26 Thread Daniel Kiper
Do not try to process Xen crash dump if dump level is invalid. Fail immediately and print relevant error message. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- makedumpfile.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/makedumpfile.c b

[PATCH 2/3] makedumpfile/xen: Disable cyclic mode for every Xen crash dump

2013-11-26 Thread Daniel Kiper
Disable cyclic mode for every Xen crash dump not only when -X option is used. This way makedumpfile is much more flexible and different modes could be used to dump whole system memory (e.g. zero pages could be striped without requiring -X option). Signed-off-by: Daniel Kiper daniel.ki

Re: [PATCH 4/4] kexec/xen: directly load images images into Xen

2013-11-19 Thread Daniel Kiper
. Use the API provided by libxc to load images when running in a Xen guest. Support for loading images via the kexec_load syscall in non-upstream (classic) Xen kernels is no longer supported. Signed-off-by: David Vrabel david.vra...@citrix.com Reviewed-by: Daniel Kiper daniel.ki

Re: [PATCH] xen/kexec: Clear unused registers before jumping into an image

2013-11-18 Thread Daniel Kiper
On Mon, Nov 18, 2013 at 11:23:27AM +, David Vrabel wrote: On 18/11/13 09:29, Jan Beulich wrote: On 15.11.13 at 21:07, David Vrabel david.vra...@citrix.com wrote: On 15/11/13 15:56, Daniel Kiper wrote: Clear unused registers before jumping into an image. This way loaded image could

Re: [PATCH] xen/kexec: Clear unused registers before jumping into an image

2013-11-18 Thread Daniel Kiper
On Mon, Nov 18, 2013 at 11:27:34AM +, Jan Beulich wrote: On 18.11.13 at 12:08, Daniel Kiper daniel.ki...@oracle.com wrote: On Mon, Nov 18, 2013 at 09:29:41AM +, Jan Beulich wrote: On 15.11.13 at 21:07, David Vrabel david.vra...@citrix.com wrote: On 15/11/13 15:56, Daniel Kiper

Re: [PATCH] xen/kexec: Clear unused registers before jumping into an image

2013-11-18 Thread Daniel Kiper
On Mon, Nov 18, 2013 at 12:05:38PM +, George Dunlap wrote: On 18/11/13 11:47, Daniel Kiper wrote: On Mon, Nov 18, 2013 at 11:23:27AM +, David Vrabel wrote: On 18/11/13 09:29, Jan Beulich wrote: On 15.11.13 at 21:07, David Vrabel david.vra...@citrix.com wrote: On 15/11/13 15:56, Daniel

[PATCH] xen/kexec: Clear unused registers before jumping into an image

2013-11-15 Thread Daniel Kiper
register has a random value or in other words it is uninitialized or has undefined state. Signed-off-by: Daniel Kiper daniel.ki...@oracle.com --- xen/arch/x86/x86_64/kexec_reloc.S | 37 + 1 file changed, 37 insertions(+) diff --git a/xen/arch/x86/x86_64

Re: [PATCH] xen/kexec: Clear unused registers before jumping into an image

2013-11-15 Thread Daniel Kiper
On Fri, Nov 15, 2013 at 08:07:02PM +, David Vrabel wrote: On 15/11/13 15:56, Daniel Kiper wrote: Clear unused registers before jumping into an image. This way loaded image could not assume that any register has an specific info about earlier running Xen hypervisor. However, it also

Re: [PATCHv10 0/9] Xen: extend kexec hypercall for use with pv-ops kernels

2013-11-09 Thread Daniel Kiper
On Thu, Nov 07, 2013 at 10:16:51PM +0100, Daniel Kiper wrote: On Wed, Nov 06, 2013 at 02:49:37PM +, David Vrabel wrote: The series (for Xen 4.4) improves the kexec hypercall by making Xen responsible for loading and relocating the image. This allows kexec to be usable by pv-ops kernels

Re: [PATCHv7 0/4] kexec-tools: add support for Xen 4.4

2013-11-09 Thread Daniel Kiper
kexec-tools series: Reviewed-by: Daniel Kiper daniel.ki...@oracle.com Tested-by: Daniel Kiper daniel.ki...@oracle.com Daniel ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCHv10 0/9] Xen: extend kexec hypercall for use with pv-ops kernels

2013-11-08 Thread Daniel Kiper
On Fri, Nov 08, 2013 at 01:13:59PM +, David Vrabel wrote: Keir, Sorry, forgot to CC you on this series. Can we have your opinion on whether this kexec series can be merged? And if not, what further work and/or testing is required? On 07/11/13 21:16, Daniel Kiper wrote: On Wed, Nov 06

Re: [PATCHv10 0/9] Xen: extend kexec hypercall for use with pv-ops kernels

2013-11-08 Thread Daniel Kiper
On Fri, Nov 08, 2013 at 01:13:59PM +, David Vrabel wrote: [...] (XEN) Domain 0 crashed: Executing crash image gdb shows: (gdb) bt #0 0x82d0801a0092 in do_nmi_crash (regs=optimized out) at crash.c:113 #1 0x82d0802281d9 in nmi_crash () at entry.S:666 #2

Re: [Xen-devel] [PATCHv10 0/9] Xen: extend kexec hypercall for use with pv-ops kernels

2013-11-08 Thread Daniel Kiper
On Fri, Nov 08, 2013 at 02:01:28PM +, Andrew Cooper wrote: On 08/11/13 13:19, Jan Beulich wrote: On 08.11.13 at 14:13, David Vrabel david.vra...@citrix.com wrote: Keir, Sorry, forgot to CC you on this series. Can we have your opinion on whether this kexec series can be merged?

Re: [Xen-devel] [PATCHv10 0/9] Xen: extend kexec hypercall for use with pv-ops kernels

2013-11-08 Thread Daniel Kiper
On Fri, Nov 08, 2013 at 10:42:51AM -0500, Konrad Rzeszutek Wilk wrote: On Fri, Nov 08, 2013 at 07:15:00AM -0800, Daniel Kiper wrote: On Fri, Nov 08, 2013 at 02:01:28PM +, Andrew Cooper wrote: On 08/11/13 13:19, Jan Beulich wrote: On 08.11.13 at 14:13, David Vrabel david.vra

Re: [PATCHv10 0/9] Xen: extend kexec hypercall for use with pv-ops kernels

2013-11-07 Thread Daniel Kiper
On Wed, Nov 06, 2013 at 02:49:37PM +, David Vrabel wrote: The series (for Xen 4.4) improves the kexec hypercall by making Xen responsible for loading and relocating the image. This allows kexec to be usable by pv-ops kernels and should allow kexec to be usable from a HVM or PVH privileged

Re: [Xen-devel] [PATCHv10 0/9] Xen: extend kexec hypercall for use with pv-ops kernels

2013-11-07 Thread Daniel Kiper
On Thu, Nov 07, 2013 at 09:25:33PM +, Andrew Cooper wrote: On 07/11/13 21:16, Daniel Kiper wrote: On Wed, Nov 06, 2013 at 02:49:37PM +, David Vrabel wrote: The series (for Xen 4.4) improves the kexec hypercall by making Xen responsible for loading and relocating the image

Re: kexec: Clearing registers just before jumping into purgatory

2013-10-14 Thread Daniel Kiper
On Fri, Oct 11, 2013 at 03:15:38PM -0700, ebied...@xmission.com wrote: Daniel Kiper daniel.ki...@oracle.com writes: On Fri, Oct 11, 2013 at 03:08:43AM -0700, ebied...@xmission.com wrote: Daniel Kiper daniel.ki...@oracle.com writes: [...] What is your opinion in that case? I can see

kexec: Clearing registers just before jumping into purgatory

2013-10-11 Thread Daniel Kiper
Hi, Could you explain why do you clear all registers just before jumping into purgatory (please look into arch/x86/kernel/relocate_kernel_64.S for more details)? There is no any single word about that. I do not count comment which states what is going on. purgatory on entry does not assume any

Re: kexec: Clearing registers just before jumping into purgatory

2013-10-11 Thread Daniel Kiper
On Fri, Oct 11, 2013 at 03:08:43AM -0700, ebied...@xmission.com wrote: Daniel Kiper daniel.ki...@oracle.com writes: Hi, Could you explain why do you clear all registers just before jumping into purgatory (please look into arch/x86/kernel/relocate_kernel_64.S for more details

Re: [PATCH 8/9] x86: check kexec relocation code fits in a page

2013-09-16 Thread Daniel Kiper
On Thu, Sep 12, 2013 at 08:49:06PM +0100, David Vrabel wrote: From: David Vrabel david.vra...@citrix.com The kexec relocation (control) code must fit in a single page so add a link time check for this. Signed-off-by: David Vrabel david.vra...@citrix.com --- xen/arch/x86/xen.lds.S |2

Re: [PATCH 1/5] purgatory: put variables altered by kexec in .data not .bss

2013-09-16 Thread Daniel Kiper
On Thu, Sep 12, 2013 at 09:00:38PM +0100, David Vrabel wrote: From: David Vrabel david.vra...@citrix.com elf_rel_set_symbol() fails if the symbol is in the .bss section. Signed-off-by: David Vrabel david.vra...@citrix.com --- purgatory/arch/i386/console-x86.c|6 +++---

  1   2   3   >