[PATCH v3 9/9] ima: platform-independent hash value

2016-09-06 Thread Mimi Zohar
Signed-off-by: Andreas Steffen <andreas.stef...@strongswan.org> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima_crypto.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/security/integrity/ima/ima_crypto.c b/security/integrit

[PATCH v3 2/9] ima: permit duplicate measurement list entries

2016-09-06 Thread Mimi Zohar
ment entry is the delimiter between soft boots. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima_queue.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/security/integrity/ima/ima_queue.c b/security/integrity/ima/ima_queue.c index

[PATCH v3 3/9] ima: maintain memory size needed for serializing the measurement list

2016-09-06 Thread Mimi Zohar
In preparation for serializing the binary_runtime_measurements, this patch maintains the amount of memory required. Changelog v3: - include the ima_kexec_hdr size in the binary_runtime_measurement size. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/K

[PATCH v3 0/9] ima: carry the measurement list across kexec

2016-09-06 Thread Mimi Zohar
tive patch changelog. Changelog v2: - Canonical measurement list support added - Redefined the ima_kexec_hdr struct to use well defined sizes Mimi Andreas Steffen (1): ima: platform-independent hash value Mimi Zohar (7): ima: on soft reboot, restore the measurement list ima: permit duplic

Re: [PATHC v2 5/9] ima: on soft reboot, save the measurement list

2016-09-02 Thread Mimi Zohar
Hi Dave, On Thu, 2016-09-01 at 09:57 +0800, Dave Young wrote: > On 08/30/16 at 06:40pm, Mimi Zohar wrote: > > + * Called during kexec_file_load so that IMA can add a segment to the kexec > > + * image for the measurement list for the next kernel. > > + */ > > +void

Re: [PATHC v2 0/9] ima: carry the measurement list across kexec

2016-08-31 Thread Mimi Zohar
On Wed, 2016-08-31 at 13:50 -0700, Andrew Morton wrote: > On Tue, 30 Aug 2016 18:40:02 -0400 Mimi Zohar <zo...@linux.vnet.ibm.com> > wrote: > > > The TPM PCRs are only reset on a hard reboot. In order to validate a > > TPM's quote after a soft reboot (eg. kexec -e

[PATHC v2 9/9] ima: platform-independent hash value

2016-08-30 Thread Mimi Zohar
Signed-off-by: Andreas Steffen <andreas.stef...@strongswan.org> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima_crypto.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/security/integrity/ima/ima_crypto.c b/security/integrit

[PATHC v2 3/9] ima: maintain memory size needed for serializing the measurement list

2016-08-30 Thread Mimi Zohar
In preparation for serializing the binary_runtime_measurements, this patch maintains the amount of memory required. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/Kconfig | 12 ++ security/integrity/ima/ima.h | 1 + security/integri

[PATHC v2 6/9] ima: store the builtin/custom template definitions in a list

2016-08-30 Thread Mimi Zohar
template per boot. Changelog v2: - fix lookup_template_desc() preemption imbalance (kernel test robot) Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima.h | 2 ++ security/integrity/ima/ima_main.c | 1 + security/integrity/ima/ima_template.

[PATHC v2 8/9] ima: define a canonical binary_runtime_measurements list format

2016-08-30 Thread Mimi Zohar
an systems expecting the binary_runtime_measurements list to be in platform native format. Signed-off-by: Mimi Zohar <zo...@us.ibm.com> --- Documentation/kernel-parameters.txt | 4 security/integrity/ima/ima.h | 6 ++ security/integrity/i

[PATHC v2 0/9] ima: carry the measurement list across kexec

2016-08-30 Thread Mimi Zohar
t.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git Mimi Andreas Steffen (1): ima: platform-independent hash value Mimi Zohar (7): ima: on soft reboot, restore the measurement list ima: permit duplicate measurement list entries ima: maintain memory size needed for serializing

[PATHC v2 5/9] ima: on soft reboot, save the measurement list

2016-08-30 Thread Mimi Zohar
ed-off-by: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- include/linux/ima.h| 12 ++ kernel/kexec_file.c| 4 ++ security/integrity/ima/ima_kexec.c | 88 +

[PATHC v2 2/9] ima: permit duplicate measurement list entries

2016-08-30 Thread Mimi Zohar
ment entry is the delimiter between soft boots. Signed-off-by: Mimi Zohar <zo...@linuv.vnet.ibm.com> --- security/integrity/ima/ima_queue.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/security/integrity/ima/ima_queue.c b/security/integrity/ima/ima_queue.c index

Re: [PATCH v3 0/5] kexec_file: Add buffer hand-over for the next kernel

2016-08-27 Thread Mimi Zohar
On Thu, 2016-08-25 at 19:17 -0300, Thiago Jung Bauermann wrote: > Am Donnerstag, 25 August 2016, 14:12:43 schrieb Andrew Morton: > > I grabbed these two patch series. I also merged the "IMA: > > Demonstration code for kexec buffer passing." demonstration patch just > > to get things a bit of

Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list

2016-08-10 Thread Mimi Zohar
;> > Am Dienstag, 09 August 2016, 09:01:13 schrieb Mimi Zohar: > >> >> On Tue, 2016-08-09 at 20:59 +1000, Michael Ellerman wrote: > >> >> > Mimi Zohar <zo...@linux.vnet.ibm.com> writes: > >> >> > > +/* Some

Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list

2016-08-09 Thread Mimi Zohar
On Tue, 2016-08-09 at 09:55 -0400, Mimi Zohar wrote: > On Tue, 2016-08-09 at 10:19 -0300, Thiago Jung Bauermann wrote: > > Am Dienstag, 09 August 2016, 09:01:13 schrieb Mimi Zohar: > > > On Tue, 2016-08-09 at 20:59 +1000, Michael Ellerman wrote: > > > > Mimi Zohar <

Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list

2016-08-09 Thread Mimi Zohar
On Tue, 2016-08-09 at 10:19 -0300, Thiago Jung Bauermann wrote: > Am Dienstag, 09 August 2016, 09:01:13 schrieb Mimi Zohar: > > On Tue, 2016-08-09 at 20:59 +1000, Michael Ellerman wrote: > > > Mimi Zohar <zo...@linux.vnet.ibm.com> writes: > > > > diff --git a/se

Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list

2016-08-09 Thread Mimi Zohar
On Tue, 2016-08-09 at 20:59 +1000, Michael Ellerman wrote: > Mimi Zohar <zo...@linux.vnet.ibm.com> writes: > > > diff --git a/security/integrity/ima/ima.h b/security/integrity/ima/ima.h > > index b5728da..84e8d36 100644 > > --- a/security/integrity/ima/ima.h > >

Re: [PATCH 1/7] ima: on soft reboot, restore the measurement list

2016-08-05 Thread Mimi Zohar
Hi Petko, Thank you for review! On Fri, 2016-08-05 at 11:44 +0300, Petko Manolov wrote: > On 16-08-04 08:24:29, Mimi Zohar wrote: > > The TPM PCRs are only reset on a hard reboot. In order to validate a > > TPM's quote after a soft reboot (eg. kexec -e), the IMA m

[PATCH 6/7] ima: store the builtin/custom template definitions in a list

2016-08-04 Thread Mimi Zohar
template per boot. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima.h | 2 ++ security/integrity/ima/ima_main.c | 1 + security/integrity/ima/ima_template.c | 37 +++ 3 files changed, 32 insertions(+), 8 del

[PATCH 3/7] ima: maintain memory size needed for serializing the measurement list

2016-08-04 Thread Mimi Zohar
In preparation for serializing the binary_runtime_measurements, this patch maintains the amount of memory required. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/Kconfig | 12 ++ security/integrity/ima/ima.h | 1 + security/integri

[PATCH 5/7] ima: on soft reboot, save the measurement list

2016-08-04 Thread Mimi Zohar
Signed-off-by: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- include/linux/ima.h| 15 +++ kernel/kexec_file.c| 3 ++ security/integrity/ima/ima_kexec.c | 83 +

[PATCH 0/7] ima: carry the measurement list across kexec

2016-08-04 Thread Mimi Zohar
ement list across the kexec. Mimi *https://lists.infradead.org/pipermail/kexec/2016-June/016157.html Mimi Zohar (6): ima: on soft reboot, restore the measurement list ima: permit duplicate measurement list entries ima: maintain memory size needed for serializing the measurement list ima:

[PATCH 2/7] ima: permit duplicate measurement list entries

2016-08-04 Thread Mimi Zohar
ment entry is the delimiter between soft boots. Signed-off-by: Mimi Zohar <zo...@linuv.vnet.ibm.com> --- security/integrity/ima/ima_queue.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/security/integrity/ima/ima_queue.c b/security/integrity/ima/ima_queue.c index

[PATCH 4/7] ima: serialize the binary_runtime_measurements

2016-08-04 Thread Mimi Zohar
. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima.h | 1 + security/integrity/ima/ima_fs.c| 2 +- security/integrity/ima/ima_kexec.c | 51 ++ 3 files changed, 53 insertions(+), 1 deletion(-) diff --git a/se

[PATCH 3/3] ima: add pre-calculated measurements (experimental)

2016-06-22 Thread Mimi Zohar
This patch defines a new IMA hook named ima_add_measurement_check() for including pre-calculated measurements in the IMA measurement list. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- Documentation/ABI/testing/ima_policy | 2 +- include/linux/ima.h

[PATCH 1/3] ima: measure other types of data

2016-06-22 Thread Mimi Zohar
, buffer length and a buffer identifier. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- include/linux/ima.h | 11 + security/integrity/ima/Makefile | 2 +- security/integrity/ima/ima.h| 2 + security/integrity/ima/ima_buffer.

[PATCH 2/3] kexec: measure boot command line

2016-06-22 Thread Mimi Zohar
This patch defines the buffer identifier "KEXEC_CMDLINE_CHECK" for measuring the boot command line. eg: echo -n -e `cat /proc/cmdline | sed 's/^.*root=/root=/'` | sha256sum Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- Documentation/ABI/testing/ima_policy | 1 + inc

[PATCH 0/3] support other types of measurements

2016-06-22 Thread Mimi Zohar
to measure the kexec boot command line, while the latter could be used for including asymmetric key id information. Mimi Zohar (3): ima: measure other types of data kexec: measure boot command line ima: add pre-calculated measurements (experimental) Documentation/ABI/testing/ima_policy | 1

Re: [PATCH 0/6] kexec_file: Add buffer hand-over for the next kernel

2016-06-22 Thread Mimi Zohar
Hi Dave, On Wed, 2016-06-22 at 09:20 +0800, Dave Young wrote: > On 06/20/16 at 10:44pm, Thiago Jung Bauermann wrote: > > Hello, > > > > This patch series implements a mechanism which allows the kernel to pass on > > a buffer to the kernel that will be kexec'd. This buffer is passed as a > >

[PATCH v4 05/19] vfs: define kernel_read_file_id enumeration

2016-02-12 Thread Mimi Zohar
. Changelog v3: - Replace the IMA specific enumeration with a generic one. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by: Kees Cook <keesc...@chromium.org> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> Cc: Al Viro <v...@zeniv.linux.org.uk> --- fs/ex

[PATCH v4 00/19] vfs: support for a common kernel file loader

2016-02-12 Thread Mimi Zohar
ash calculation function ima: load policy using path Kees Cook (1): firmware: clean up filesystem load exit path Luis R. Rodriguez (2): firmware: simplify dev_*() print messages for generic helpers firmware: move completing fw into a helper Mimi Zohar (14): vfs: define a generic function

[PATCH v4 06/19] ima: provide buffer hash calculation function

2016-02-12 Thread Mimi Zohar
satkin <dmitry.kasat...@huawei.com> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima.h| 2 ++ security/integrity/ima/ima_crypto.c | 47 + 2 files changed, 49 insertions(+) diff --git a/security/integrity/ima/ima.h b/

[PATCH v4 07/19] ima: calculate the hash of a buffer using aynchronous hash(ahash)

2016-02-12 Thread Mimi Zohar
Setting up ahash has some overhead. Only use ahash to calculate the hash of a buffer, if the buffer is larger than ima_ahash_minsize. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by: Dmitry Kasatkin <dmitry.kasat...@huawei.com> --- security/integrity/ima/ima_c

[PATCH v4 15/19] kexec: replace call to copy_file_from_fd() with kernel version

2016-02-12 Thread Mimi Zohar
, moving copy_file_from_fd() to a separate patch - split patch, moving IMA changes to a separate patch v0: - use kstat file size type loff_t, not size_t - Calculate the file hash from the in memory buffer - Dave Young Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by: Kees Cook

[PATCH v4 04/19] vfs: define a generic function to read a file from the kernel

2016-02-12 Thread Mimi Zohar
some of these differences. This patch introduces a common function for reading files from the kernel with the corresponding security post-read hook and function. Changelog v3: - additional bounds checking - Luis v2: - To simplify patch review, re-ordered patches Signed-off-by: Mimi Zohar <

[PATCH v4 08/19] ima: define a new hook to measure and appraise a file already in memory

2016-02-12 Thread Mimi Zohar
ima_hash_and_process_file() to ima_post_read_file() v1: - split patch Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by: Dmitry Kasatkin <dmitry.kasat...@huawei.com> --- include/linux/ima.h | 8 +++ include/linux/security.h | 1 + security/integri

[PATCH v4 16/19] ima: support for kexec image and initramfs

2016-02-12 Thread Mimi Zohar
: - replaced switch statement with a kernel_read_file_id to an ima_hooks id mapping array - Dmitry - renamed ima_hook tokens KEXEC_CHECK and INITRAMFS_CHECK to KEXEC_KERNEL_CHECK and KEXEC_INITRAMFS_CHECK respectively - Dave Young Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by:

[PATCH v4 12/19] vfs: define kernel_copy_file_from_fd()

2016-02-12 Thread Mimi Zohar
uk> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- fs/exec.c | 16 include/linux/fs.h | 2 ++ 2 files changed, 18 insertions(+) diff --git a/fs/exec.c b/fs/exec.c index 78dfdf3..604f669 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -910,6 +910,22 @@ int kernel_

[PATCH v4 09/19] vfs: define kernel_read_file_from_path

2016-02-12 Thread Mimi Zohar
This patch defines kernel_read_file_from_path(), a wrapper for the VFS common kernel_read_file(). Changelog: - Separated from the IMA patch Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by: Kees Cook <keesc...@chromium.org> Acked-by: Luis R. Rodriguez <mcg...@kernel.o

[PATCH v4 13/19] module: replace copy_module_from_fd with kernel version

2016-02-12 Thread Mimi Zohar
module twice, once for measuring/appraising and again for loading the kernel module, the signature validation is moved to the kernel_post_read_file() security hook. This patch removes the security_kernel_module_from_file() hook and security call. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.

[PATCH v4 11/19] security: define kernel_read_file hook

2016-02-12 Thread Mimi Zohar
The kernel_read_file security hook is called prior to reading the file into memory. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by: Kees Cook <keesc...@chromium.org> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> Acked-by: Casey Schaufler <ca...@schaufler-c

[PATCH v4 14/19] ima: remove firmware and module specific cached status info

2016-02-12 Thread Mimi Zohar
simplifies adding support for other files read by the kernel. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by: Petko Manolov <pet...@mip-labs.com> Acked-by: Dmitry Kasatkin <dmitry.kasat...@huawei.com> --- security/integrity/iint.c | 4 ++-- security/i

[PATCH v4 17/19] ima: load policy using path

2016-02-12 Thread Mimi Zohar
v3: - moved kernel_read_file_from_path() to a separate patch v2: - after re-ordering the patches, replace calling integrity_kernel_read() to read the file with kernel_read_file_from_path() (Mimi) - Patch description re-written by Luis R. Rodriguez Signed-off-by: Dmitry Kasatkin <dmitry.kasat...@huawei.com> S

[PATCH v4 19/19] ima: require signed IMA policy

2016-02-12 Thread Mimi Zohar
Require the IMA policy to be signed when additional rules can be added. v1: - initialize the policy flag - include IMA_APPRAISE_POLICY in the policy flag Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by: Petko Manolov <pet...@mip-labs.com> Acked-by: Dmitry Kasatkin &

[PATCH v4 10/19] firmware: replace call to fw_read_file_contents() with kernel version

2016-02-12 Thread Mimi Zohar
kernel_fw_from_file() hook and security call. Changelog v3: - remove kernel_fw_from_file hook - use kernel_file_read_from_path() - requested by Luis v2: - reordered and squashed firmware patches - fix MAX firmware size (Kees Cook) Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by: Kees Cook

[PATCH v4 02/19] firmware: move completing fw into a helper

2016-02-12 Thread Mimi Zohar
From: "Luis R. Rodriguez" <mcg...@kernel.org> This will be re-used later through a new extensible interface. Reviewed-by: Josh Boyer <jwbo...@fedoraproject.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.

[PATCH v4 18/19] ima: measure and appraise the IMA policy itself

2016-02-12 Thread Mimi Zohar
Add support for measuring and appraising the IMA policy itself. Changelog v4: - use braces on both if/else branches, even if single line on one of the branches - Dmitry - Use the id mapping - Dmitry Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> Acked-by: Petko Manolov <pet...@mip

[PATCH v4 03/19] firmware: clean up filesystem load exit path

2016-02-12 Thread Mimi Zohar
com> Acked-by: Luis R. Rodriguez <mcg...@kernel.org> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- drivers/base/firmware_class.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_c

[PATCH v4 01/19] firmware: simplify dev_*() print messages for generic helpers

2016-02-12 Thread Mimi Zohar
chaufler <ca...@schaufler-ca.com> Cc: Ming Lei <ming@canonical.com> Cc: Takashi Iwai <ti...@suse.de> Cc: Vojtěch Pavlík <vojt...@suse.cz> Cc: Kyle McMartin <k...@kernel.org> Cc: Matthew Garrett <mj...@srcf.ucam.org> Cc: linux-ker...@vger.kernel.org

Re: [PATCH v3 14/22] security: define kernel_read_file hook

2016-02-11 Thread Mimi Zohar
On Thu, 2016-02-11 at 08:54 -0800, Casey Schaufler wrote: > On 2/3/2016 11:06 AM, Mimi Zohar wrote: > > The kernel_read_file security hook is called prior to reading the file > > into memory. > > > > Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> &

Re: [PATCH v3 19/22] ima: support for kexec image and initramfs

2016-02-11 Thread Mimi Zohar
On Thu, 2016-02-11 at 10:47 +0200, Dmitry Kasatkin wrote: > On Thu, Feb 11, 2016 at 4:08 AM, Mimi Zohar <zo...@linux.vnet.ibm.com> wrote: > static int idmap[] = { > [READING_FIRMWARE] = FIRMWARE_CHECK, > [READING_MODULE] = MODULE_CHECK, > ... &g

Re: [PATCH v3 21/22] ima: measure and appraise the IMA policy itself

2016-02-10 Thread Mimi Zohar
On Wed, 2016-02-10 at 22:22 +0200, Dmitry Kasatkin wrote: > On Wed, Feb 3, 2016 at 9:06 PM, Mimi Zohar <zo...@linux.vnet.ibm.com> wrote: > > Add support for measuring and appraising the IMA policy itself. > > > > Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com&g

Re: [PATCH v3 17/22] ima: remove firmware and module specific cached status info

2016-02-10 Thread Mimi Zohar
On Wed, 2016-02-10 at 22:18 +0200, Dmitry Kasatkin wrote: > > diff --git a/security/integrity/ima/ima_appraise.c > > b/security/integrity/ima/ima_appraise.c > > index cb0d0ff..6b4694a 100644 > > --- a/security/integrity/ima/ima_appraise.c > > +++ b/security/integrity/ima/ima_appraise.c > > @@

Re: [PATCH v3 19/22] ima: support for kexec image and initramfs

2016-02-10 Thread Mimi Zohar
On Wed, 2016-02-10 at 23:09 +0200, Dmitry Kasatkin wrote: > On Wed, Feb 3, 2016 at 9:06 PM, Mimi Zohar <zo...@linux.vnet.ibm.com> wrote: > > Add IMA policy support for measuring/appraising the kexec image and > > initramfs. > > > > Moving the enumeration to the

Re: [PATCH v3 19/22] ima: support for kexec image and initramfs

2016-02-10 Thread Mimi Zohar
On Thu, 2016-02-11 at 01:55 +0200, Dmitry Kasatkin wrote: > On Feb 11, 2016 1:22 AM, "Mimi Zohar" <zo...@linux.vnet.ibm.com> wrote: > > > > On Wed, 2016-02-10 at 23:09 +0200, Dmitry Kasatkin wrote: > > > On Wed, Feb 3, 2016 at 9:06 PM, Mimi

Re: [PATCH v3 20/22] ima: load policy using path

2016-02-08 Thread Mimi Zohar
On Mon, 2016-02-08 at 10:45 +, Dmitry Kasatkin wrote: > > > @@ -286,9 +322,12 @@ static ssize_t ima_write_policy(struct file *file, > > > const char __user *buf, > > > result = mutex_lock_interruptible(_write_mutex); > > > if (result < 0) > > > goto out_free; > > >

Re: [PATCH v3 19/22] ima: support for kexec image and initramfs

2016-02-08 Thread Mimi Zohar
On Sun, 2016-02-07 at 22:10 +0200, Petko Manolov wrote: > On 16-02-03 14:06:27, Mimi Zohar wrote: > > Option 3: incorportate the ima_hooks enumeration into kernel_read_file_id, > > perhaps changing the enumeration name. > > > > For now, duplicate the new RE

Re: [PATCH v3 16/22] module: replace copy_module_from_fd with kernel version

2016-02-04 Thread Mimi Zohar
On Thu, 2016-02-04 at 20:56 +0100, Luis R. Rodriguez wrote: > On Wed, Feb 03, 2016 at 02:06:24PM -0500, Mimi Zohar wrote: > > Replace copy_module_from_fd() with kernel_read_file_from_fd(). > > > > Although none of the upstreamed LSMs define a kernel_module_from_file > >

Re: [PATCH v3 00/22] vfs: support for a common kernel file loader

2016-02-04 Thread Mimi Zohar
On Thu, 2016-02-04 at 10:15 -0800, Kees Cook wrote: > On Wed, Feb 3, 2016 at 11:06 AM, Mimi Zohar <zo...@linux.vnet.ibm.com> wrote: > > For a while it was looked down upon to directly read files from Linux. > > These days there exists a few mechanisms in the kernel that do

Re: [PATCH v3.1] firmware: clean up filesystem load exit path

2016-02-04 Thread Mimi Zohar
;keesc...@chromium.org> > > Cc: Josh Boyer <jwbo...@fedoraproject.org> > > Cc: David Howells <dhowe...@redhat.com> > > Cc: Luis R. Rodriguez <mcg...@kernel.org> > > Cc: Mimi Zohar <zo...@linux.vnet.ibm.com> > > Thanks, > > Acked-by: Luis

[PATCH v3 04/22] firmware: simplify dev_*() print messages for generic helpers

2016-02-04 Thread Mimi Zohar
chaufler <ca...@schaufler-ca.com> Cc: Ming Lei <ming@canonical.com> Cc: Takashi Iwai <ti...@suse.de> Cc: Vojtěch Pavlík <vojt...@suse.cz> Cc: Kyle McMartin <k...@kernel.org> Cc: Matthew Garrett <mj...@srcf.ucam.org> Cc: linux-ker...@vger.kernel.org

[PATCH v3 07/22] vfs: define a generic function to read a file from the kernel

2016-02-03 Thread Mimi Zohar
some of these differences. This patch introduces a common function for reading files from the kernel with the corresponding security post-read hook and function. Changelog v3: - additional bounds checking - Luis v2: - To simplify patch review, re-ordered patches Signed-off-by: Mimi Zohar <

[PATCH v3 12/22] vfs: define kernel_read_file_from_path

2016-02-03 Thread Mimi Zohar
This patch defines kernel_read_file_from_path(), a wrapper for the VFS common kernel_read_file(). Changelog: - Separated from the IMA patch Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- fs/exec.c | 22 ++ include/linux/fs.h | 2 ++ 2 files chang

[PATCH v3 15/22] vfs: define kernel_copy_file_from_fd()

2016-02-03 Thread Mimi Zohar
This patch defines kernel_read_file_from_fd(), a wrapper for the VFS common kernel_read_file(). Changelog: - Separated from the kernel modules patch Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- fs/exec.c | 16 include/linux/fs.h | 2 ++ 2 files chang

[PATCH v3 09/22] ima: provide buffer hash calculation function

2016-02-03 Thread Mimi Zohar
satkin <dmitry.kasat...@huawei.com> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima.h| 2 ++ security/integrity/ima/ima_crypto.c | 47 + 2 files changed, 49 insertions(+) diff --git a/security/integrity/ima/ima.h b/

[PATCH v3 05/22] firmware: move completing fw into a helper

2016-02-03 Thread Mimi Zohar
From: "Luis R. Rodriguez" <mcg...@kernel.org> This will be re-used later through a new extensible interface. Reviewed-by: Josh Boyer <jwbo...@fedoraproject.org> Signed-off-by: Luis R. Rodriguez <mcg...@kernel.org> Signed-off-by: Mimi Zohar <zo...@linux.

[PATCH v3 00/22] vfs: support for a common kernel file loader

2016-02-03 Thread Mimi Zohar
implify dev_*() print messages for generic helpers firmware: move completing fw into a helper Mimi Zohar (16): ima: refactor ima_policy_show() to display "ima_hooks" rules ima: use "ima_hooks" enum as function argument vfs: define a generic function to read a file

[PATCH v3 08/22] vfs: define kernel_read_file_id enumeration

2016-02-03 Thread Mimi Zohar
. Changelog v3: - Replace the IMA specific enumeration with a generic one. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- fs/exec.c | 4 ++-- include/linux/fs.h| 7 ++- include/linux/lsm_hooks.h | 4 +++- include/linux/security.h | 7 +-- se

[PATCH v3 01/22] ima: separate 'security.ima' reading functionality from collect

2016-02-03 Thread Mimi Zohar
h algo to the ima_collect_measurement(). Signed-off-by: Dmitry Kasatkin <dmitry.kasat...@huawei.com> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima.h | 15 +++ security/integrity/ima/ima_api.c | 15 +++ secu

[PATCH v3 18/22] kexec: replace call to copy_file_from_fd() with kernel version

2016-02-03 Thread Mimi Zohar
ocess_file() allocating memory, the caller allocates and frees the memory. - Moved the kexec measurement/appraisal call to copy_file_from_fd(). The same call now measures and appraises both the kexec image and initramfs. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- include/linux/fs.h

[PATCH v3 21/22] ima: measure and appraise the IMA policy itself

2016-02-03 Thread Mimi Zohar
Add support for measuring and appraising the IMA policy itself. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima.h| 2 ++ security/integrity/ima/ima_fs.c | 9 - security/integrity/ima/ima_main.c | 3 +++ security/integri

[PATCH v3 06/22] firmware: fold successful fw read early

2016-02-03 Thread Mimi Zohar
Luis R. Rodriguez <mcg...@kernel.org> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- drivers/base/firmware_class.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c index fb64814..c65

[PATCH v3 16/22] module: replace copy_module_from_fd with kernel version

2016-02-03 Thread Mimi Zohar
module twice, once for measuring/appraising and again for loading the kernel module, the signature validation is moved to the kernel_post_read_file() security hook. This patch removes the security_kernel_module_from_file() hook and security call. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.

[PATCH v3 14/22] security: define kernel_read_file hook

2016-02-03 Thread Mimi Zohar
The kernel_read_file security hook is called prior to reading the file into memory. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- fs/exec.c | 4 include/linux/ima.h | 6 ++ include/linux/lsm_hooks.h | 8 include

[PATCH v3 19/22] ima: support for kexec image and initramfs

2016-02-03 Thread Mimi Zohar
{ enum ima_hooks func_id; enum kernel_read_file_id read_id; }; }; Option 3: incorportate the ima_hooks enumeration into kernel_read_file_id, perhaps changing the enumeration name. For now, duplicate the new READING_KEXEC_IMAGE/INITRAMFS in ima_hooks. Signed-off-by: Mimi

[PATCH v3 20/22] ima: load policy using path

2016-02-03 Thread Mimi Zohar
v3: - moved kernel_read_file_from_path() to a separate patch v2: - after re-ordering the patches, replace calling integrity_kernel_read() to read the file with kernel_read_file_from_path() (Mimi) - Patch description re-written by Luis R. Rodriguez Signed-off-by: Dmitry Kasatkin <dmitry.kasat...@huawei.com> S

[PATCH v3 22/22] ima: require signed IMA policy

2016-02-03 Thread Mimi Zohar
Require the IMA policy to be signed when additional rules can be added. v1: - initialize the policy flag - include IMA_APPRAISE_POLICY in the policy flag Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima_policy.c | 7 +++ 1 file changed, 7 inse

[PATCH v3 03/22] ima: use "ima_hooks" enum as function argument

2016-02-03 Thread Mimi Zohar
Cleanup the function arguments by using "ima_hooks" enumerator as needed. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima.h | 25 + security/integrity/ima/ima_api.c | 6 +++--- security/integrity/ima/ima

[PATCH v3 13/22] firmware: replace call to fw_read_file_contents() with kernel version

2016-02-03 Thread Mimi Zohar
kernel_fw_from_file() hook and security call. Changelog v3: - remove kernel_fw_from_file hook - use kernel_file_read_from_path() - requested by Luis v2: - reordered and squashed firmware patches - fix MAX firmware size (Kees Cook) Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- driver

[PATCH v3 02/22] ima: refactor ima_policy_show() to display "ima_hooks" rules

2016-02-03 Thread Mimi Zohar
Define and call a function to display the "ima_hooks" rules. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima_policy.c | 63 + 1 file changed, 36 insertions(+), 27 deletions(-) diff --git a/securi

[PATCH v3 17/22] ima: remove firmware and module specific cached status info

2016-02-03 Thread Mimi Zohar
simplifies adding support for other files read by the kernel. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/iint.c | 4 ++-- security/integrity/ima/ima.h | 3 ++- security/integrity/ima/ima_appraise.

[PATCH v3 10/22] ima: calculate the hash of a buffer using aynchronous hash(ahash)

2016-02-03 Thread Mimi Zohar
Setting up ahash has some overhead. Only use ahash to calculate the hash of a buffer, if the buffer is larger than ima_ahash_minsize. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima_crypto.c | 75 - 1 file chang

[PATCH v3 11/22] ima: define a new hook to measure and appraise a file already in memory

2016-02-03 Thread Mimi Zohar
the kexec changes in "kexec: replace call to copy_file_from_fd() with kernel version". Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- include/linux/ima.h | 8 +++ include/linux/security.h | 1 + security/integrity/ima/ima.h

Re: [RFC PATCH v2 06/11] kexec: replace call to copy_file_from_fd() with kernel version

2016-01-26 Thread Mimi Zohar
Hi Dave, On Tue, 2016-01-26 at 09:20 +0800, Dave Young wrote: > Hi, Mimi > > On 01/25/16 at 10:04am, Mimi Zohar wrote: > > On Mon, 2016-01-25 at 14:37 +0800, Dave Young wrote: > > > Hi, Mimi > > > > > > Besides of code issues, I have several

Re: [RFC PATCH v2 06/11] kexec: replace call to copy_file_from_fd() with kernel version

2016-01-25 Thread Mimi Zohar
On Mon, 2016-01-25 at 14:37 +0800, Dave Young wrote: > Hi, Mimi > > Besides of code issues, I have several thing to be understand: > > What is the effect to kexec behavior with this patchset? > - without IMA enabled (kconfig or kernel cmdline) it will be same as before? Yes, without IMA

Re: [RFC PATCH v2 06/11] kexec: replace call to copy_file_from_fd() with kernel version

2016-01-25 Thread Mimi Zohar
On Mon, 2016-01-25 at 21:34 +0100, Luis R. Rodriguez wrote: > On Mon, Jan 25, 2016 at 10:04:18AM -0500, Mimi Zohar wrote: > > On Mon, 2016-01-25 at 14:37 +0800, Dave Young wrote: > > > Hi, Mimi > > > > > > Besides of code issues, I have several thing

Re: [RFC PATCH v2 07/11] firmware: replace call to fw_read_file_contents() with kernel version

2016-01-21 Thread Mimi Zohar
On Wed, 2016-01-20 at 15:56 -0800, Luis R. Rodriguez wrote: > On Wed, Jan 20, 2016 at 3:39 PM, Luis R. Rodriguez wrote: > >> @@ -350,13 +321,18 @@ static int fw_get_filesystem_firmware(struct device > >> *device, > >> file = filp_open(path, O_RDONLY, 0); > >>

Re: [RFC PATCH v2 07/11] firmware: replace call to fw_read_file_contents() with kernel version

2016-01-21 Thread Mimi Zohar
On Tue, 2016-01-19 at 16:10 -0800, Kees Cook wrote: > On Mon, Jan 18, 2016 at 7:11 AM, Mimi Zohar <zo...@linux.vnet.ibm.com> wrote: > > Replace fw_read_file_contents() for reading a file with the common VFS > > kernel_read_file() function. A benefit of calling kernel_re

Re: [RFC PATCH v2 03/11] ima: provide buffer hash calculation function

2016-01-21 Thread Mimi Zohar
On Tue, 2016-01-19 at 21:26 +0200, Dmitry Kasatkin wrote: > On Mon, Jan 18, 2016 at 5:11 PM, Mimi Zohar <zo...@linux.vnet.ibm.com> wrote: > > From: Dmitry Kasatkin <d.kasat...@samsung.com> > > > > This patch provides convenient buffer hash calculation function.

Re: [RFC PATCH v2 01/11] ima: separate 'security.ima' reading functionality from collect

2016-01-21 Thread Mimi Zohar
On Tue, 2016-01-19 at 22:00 +0200, Dmitry Kasatkin wrote: > Hi Mimi, > > Please change > > Signed-off-by: Dmitry Kasatkin I'll make the change here and in the other patches as well. Mimi ___ kexec mailing list

Re: [RFC PATCH v2 02/11] vfs: define a generic function to read a file from the kernel

2016-01-21 Thread Mimi Zohar
On Wed, 2016-01-20 at 02:09 +0100, Luis R. Rodriguez wrote: > On Mon, Jan 18, 2016 at 10:11:17AM -0500, Mimi Zohar wrote: > > diff --git a/fs/exec.c b/fs/exec.c > > index b06623a..6d623c2 100644 > > --- a/fs/exec.c > > +++ b/fs/exec.c > > @@ -831,6 +832,58 @@

Re: [RFC PATCH v2 09/11] ima: load policy using path

2016-01-21 Thread Mimi Zohar
On Thu, 2016-01-21 at 01:05 +0100, Luis R. Rodriguez wrote: > On Mon, Jan 18, 2016 at 10:11:24AM -0500, Mimi Zohar wrote: > > --- a/fs/exec.c > > +++ b/fs/exec.c > > @@ -903,6 +903,27 @@ out: > > return ret; > > } > > > > +int kernel_read_file_f

Re: [RFC PATCH v2 08/11] module: replace copy_module_from_fd with kernel version

2016-01-21 Thread Mimi Zohar
On Thu, 2016-01-21 at 01:03 +0100, Luis R. Rodriguez wrote: > On Mon, Jan 18, 2016 at 10:11:23AM -0500, Mimi Zohar wrote: > > This patch replaces the module copy_module_from_fd() call with the VFS > > common kernel_read_file_from_fd() function. Instead of reading the > > kern

Re: [RFC PATCH v2 00/11] vfss: support for a common kernel file loader

2016-01-21 Thread Mimi Zohar
On Thu, 2016-01-21 at 21:16 +0100, Luis R. Rodriguez wrote: > On Mon, Jan 18, 2016 at 10:11:15AM -0500, Mimi Zohar wrote: > > > > The latest version of these patches can be found in the next-kernel-read-v2 > > branch of: > > git://git.kernel.org/pub/scm/linux/kernel/gi

Re: [RFC PATCH v2 08/11] module: replace copy_module_from_fd with kernel version

2016-01-21 Thread Mimi Zohar
On Thu, 2016-01-21 at 08:56 -0800, Luis R. Rodriguez wrote: > On Thu, Jan 21, 2016 at 5:12 AM, Mimi Zohar <zo...@linux.vnet.ibm.com> wrote: > > On Thu, 2016-01-21 at 01:03 +0100, Luis R. Rodriguez wrote: > >> On Mon, Jan 18, 2016 at 10:11:23AM -0500, Mimi Zohar wrote: &g

Re: [RFC PATCH v2 08/11] module: replace copy_module_from_fd with kernel version

2016-01-21 Thread Mimi Zohar
On Thu, 2016-01-21 at 10:45 -0500, Paul Moore wrote: > On Thursday, January 21, 2016 08:12:12 AM Mimi Zohar wrote: > > Paul, Casey, Kees, Jon, Tetsuo does it make sense to consolidate the > > module, firmware, and kexec pre and post security hooks and have just > > one set of

[RFC PATCH v2 03/11] ima: provide buffer hash calculation function

2016-01-18 Thread Mimi Zohar
From: Dmitry Kasatkin <d.kasat...@samsung.com> This patch provides convenient buffer hash calculation function. Changelog: - rewrite to support loff_t sized buffers - Mimi (based on Fenguang Wu's testing) Signed-off-by: Dmitry Kasatkin <d.kasat...@samsung.com> Signed-off-by: Mi

[RFC PATCH v2 04/11] ima: calculate the hash of a buffer using aynchronous hash(ahash)

2016-01-18 Thread Mimi Zohar
Setting up ahash has some overhead. Only use ahash to calculate the hash of a buffer, if the buffer is larger than ima_ahash_minsize. Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima_crypto.c | 75 - 1 file chang

[RFC PATCH v2 01/11] ima: separate 'security.ima' reading functionality from collect

2016-01-18 Thread Mimi Zohar
h algo to the ima_collect_measurement(). Signed-off-by: Dmitry Kasatkin <d.kasat...@samsung.com> Signed-off-by: Mimi Zohar <zo...@linux.vnet.ibm.com> --- security/integrity/ima/ima.h | 15 +++ security/integrity/ima/ima_api.c | 15 +++ secu

<    1   2   3   4   5   >