Re: [ANNOUNCE] kexec-tools 2.0.4

2013-03-27 Thread Simon Horman
On Thu, Mar 28, 2013 at 09:46:47AM +0800, Dave Young wrote: On 03/27/2013 08:34 PM, Simon Horman wrote: On Thu, Mar 21, 2013 at 06:00:29PM +0800, Dave Young wrote: On 03/21/2013 05:02 PM, Baoquan wrote: On 03/21/2013 04:56 PM, Baoquan wrote: On 03/21/2013 04:51 PM, Simon Horman wrote

Re: [PATCH 2/2] kexec: Use err() instead of fprintf()

2013-03-20 Thread Simon Horman
On Wed, Mar 20, 2013 at 09:17:51PM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com Since we have the err() interface, so replace the error printing function with err(). This patch introduces a lot of code changes and I'm not entirely sure that I see the benefit.

[ANNOUNCE] kexec-tools 2.0.4

2013-03-18 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.4. The release can be downloaded from kernel.org: http://kernel.org/pub/linux/utils/kernel/kexec/kexec-tools-2.0.4.tar.xz http://kernel.org/pub/linux/utils/kernel/kexec/ I have also tagged it in git:

Re: [PATCH 04/13] kexec: use _ALIGN* to make the logic clear

2013-03-15 Thread Simon Horman
On Thu, Mar 14, 2013 at 07:26:18PM +0800, Zhang Yanfei wrote: 于 2013年03月14日 17:58, Simon Horman 写道: On Thu, Mar 14, 2013 at 10:49:51AM +0100, Simon Horman wrote: On Thu, Mar 14, 2013 at 10:08:06AM +0100, Simon Horman wrote: On Thu, Mar 14, 2013 at 01:26:56AM +0800, Zhang Yanfei wrote

Re: [PATCH v3 04/13] kexec: use _ALIGN* to make the logic clear

2013-03-15 Thread Simon Horman
On Fri, Mar 15, 2013 at 05:46:35PM +0800, Zhang Yanfei wrote: By replacing all the explicit align opertion with marco _ALIGN*, the code logic could more clear. Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH] kexec/s390: Replace clgfi with cghi

2013-03-15 Thread Simon Horman
On Fri, Mar 15, 2013 at 01:46:32PM +0100, Michael Holzheu wrote: The clgfi instruction needs at least z9 machine level. To allow kexec-tools compiled also with z900, this patch replaces clgfi with the older cghi instruction. Hi, could you update the changelog to include a brief description of

Re: [PATCH] kexec/s390: Replace clgfi with cghi

2013-03-15 Thread Simon Horman
. Michael On Fri, 15 Mar 2013 16:57:33 +0100 Simon Horman ho...@verge.net.au wrote: On Fri, Mar 15, 2013 at 01:46:32PM +0100, Michael Holzheu wrote: The clgfi instruction needs at least z9 machine level. To allow kexec-tools compiled also with z900, this patch replaces clgfi

Re: [PATCH] kexec: check size before trying the malloc

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:16:25AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com If size is zero, it is unnecessary to do the malloc operation. So checking size first is better than doing malloc first. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com

Re: [PATCH 04/13] kexec: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:26:56AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com By replacing all the explicit align opertions with marco _ALIGN*, the code logic could be more clear. Not a big deal, but I believe this patch needs to come after the arm changes in

Re: [PATCH 09/13] kexec: ppc: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:32:20AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com By replacing all the explicit align opertion with marco _ALIGN*, the code logic could be more clear. Besides, remove the duplicate _ALIGN_* definition in file

Re: [PATCH 10/13] kexec: ppc64: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:33:07AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com By replacing all the explicit align opertion with marco _ALIGN*, the code logic could be more clear. This appears to break the ppc64 build. powerpc64-unknown-linux-gnu-gcc -Wall

Re: [PATCH 01/13] kexec: add _ALIGN* marcos for align operation

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:19:13AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com This patch imports Macros for align operation: - _ALIGN_UP(addr, size): align addr up on a size boundary - _ALIGN_DOWN(addr, size): align addr down on a size boundary - _ALIGN(addr,

Re: [PATCH 02/13] kexec: use _ALIGN() instead of align()

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:21:43AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com Since we have imported macro _ALIGN() for global use, replace the call of function align() with _ALIGN() and remove align(). Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com

Re: [PATCH 03/13] kexec: ppc: remove duplicated _ALIGN_* macros

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:23:49AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com We have defined the global align macros for use, so remove the duplicated macros here. And in file kexec/arch/ppc/include/page.h, we directly expand the align operation for marco

Re: [PATCH 04/13] kexec: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 10:08:06AM +0100, Simon Horman wrote: On Thu, Mar 14, 2013 at 01:26:56AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com By replacing all the explicit align opertions with marco _ALIGN*, the code logic could be more clear. Not a big

Re: [PATCH 05/13] kexec: i386: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:28:36AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com By replacing all the explicit align opertion with marco _ALIGN*, the code logic could be more clear. Thanks, applied. ___ kexec mailing

Re: [PATCH 07/13] kexec: ia64: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:30:27AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com By replacing all the explicit align opertion with marco _ALIGN*, the code logic could be simplified. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Thanks, applied.

Re: [PATCH v2 09/13] kexec: ppc: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 05:33:10PM +0800, Zhang Yanfei wrote: By replacing all the explicit align opertion with marco _ALIGN*, the code logic could be more clear. Besides, remove the duplicate _ALIGN_* definition in file kexec/arch/ppc/crashdump-powerpc.h. Hi, I am still seeing a build

Re: [PATCH 04/13] kexec: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 10:49:51AM +0100, Simon Horman wrote: On Thu, Mar 14, 2013 at 10:08:06AM +0100, Simon Horman wrote: On Thu, Mar 14, 2013 at 01:26:56AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com By replacing all the explicit align opertions

Re: [PATCH v2 09/13] kexec: ppc: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 10:54:14AM +0100, Simon Horman wrote: On Thu, Mar 14, 2013 at 05:33:10PM +0800, Zhang Yanfei wrote: By replacing all the explicit align opertion with marco _ALIGN*, the code logic could be more clear. Besides, remove the duplicate _ALIGN_* definition in file

Re: [PATCH 12/13] kexec: sh: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:34:41AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com By replacing all the explicit align opertion with marco _ALIGN*, the code logic could be more clear. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Thanks, applied.

Re: [PATCH v2 09/13] kexec: ppc: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 10:57:50AM +0100, Simon Horman wrote: On Thu, Mar 14, 2013 at 10:54:14AM +0100, Simon Horman wrote: On Thu, Mar 14, 2013 at 05:33:10PM +0800, Zhang Yanfei wrote: By replacing all the explicit align opertion with marco _ALIGN*, the code logic could be more clear

Re: [PATCH 13/13] kexec: x86_64: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:35:26AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com By replacing all the explicit align opertion with marco _ALIGN*, the code logic could be more clear. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Thanks, applied.

Re: [PATCH 11/13] kexec: s390: remove ALIGN_UP and use _ALIGN_UP

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 01:33:53AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com We have _ALIGN_UP now, so remove ALIGN_UP and use _ALIGN_UP instead of it. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Thanks, applied.

Re: [PATCH v2 10/13] kexec: ppc64: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 05:38:02PM +0800, Zhang Yanfei wrote: By replacing all the explicit align opertion with marco _ALIGN*, the code logic could be more clear. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Thanks, applied. ___ kexec

Re: [PATCH 04/13] kexec: use _ALIGN* to make the logic clear

2013-03-14 Thread Simon Horman
On Thu, Mar 14, 2013 at 05:48:40PM +0800, Zhang Yanfei wrote: 于 2013年03月14日 17:08, Simon Horman 写道: On Thu, Mar 14, 2013 at 01:26:56AM +0800, Zhang Yanfei wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com By replacing all the explicit align opertions with marco _ALIGN*, the code

Re: failed to compile kexec from git

2013-03-13 Thread Simon Horman
, could you test this? commit 51438a32f6a0f09a358742f06196d14e4ad0ccab Author: Simon Horman ho...@verge.net.au Date: Wed Mar 13 10:48:48 2013 +0100 Correct build failure in init_linux_parameters() This fixes a build failure introduced by kexec x86: drop truncation warning for crash

Re: failed to compile kexec from git

2013-03-13 Thread Simon Horman
On Wed, Mar 13, 2013 at 05:57:58PM +0800, Zhang Yanfei wrote: 于 2013年03月13日 17:52, Simon Horman 写道: On Tue, Mar 12, 2013 at 11:08:17PM -0400, CAI Qian wrote: If I revert this commit, 6df15d1cca55b2cd59c79aed69f004e1b2a6ba36 kexec x86: drop truncation warning for crash kernel

Re: [PATCH v2 0/4] kexec: Support for uImage RAMDISK

2013-03-07 Thread Simon Horman
On Wed, Mar 06, 2013 at 02:07:35PM +0530, Suzuki K. Poulose wrote: The following series adds support and APIs for handling uImage formatted RAMDISK. The support for PPC has been implemented. Changes since V1: * Do not uncompress RAMDISK uImage (Pointed by Sebastian) * Introduce new

Re: [PATCH v9 0/7] kexec: put bzImage and ramdisk above 4G for x86 64bit

2013-03-04 Thread Simon Horman
On Tue, Feb 26, 2013 at 05:18:58PM +0800, Dave Young wrote: On 02/22/2013 12:07 PM, Yinghai Lu wrote: Now we have limit kdump reserved under 896M, because kexec has the limitation. and also bzImage need to stay under 4g. I think the kernel patches has been merged in linus tree, I got a

Re: [PATCH] kexec/ppc: Fix kernel program entry point while changing the load addr

2013-03-04 Thread Simon Horman
On Mon, Mar 04, 2013 at 11:26:24AM +0530, Suzuki K. Poulose wrote: On 03/04/2013 07:11 AM, Simon Horman wrote: [ Cc: linuxppc-...@lists.ozlabs.org ] On Sun, Mar 03, 2013 at 01:06:00PM +0530, Suzuki K. Poulose wrote: From: Suzuki K. Poulose suz...@in.ibm.com uImage probe fills the entry

Re: kexec,x86: Use macro CRASH_MAX_MEMMAP_NR for clarification

2013-03-04 Thread Simon Horman
On Tue, Feb 26, 2013 at 06:12:54PM +0800, Zhang Yanfei wrote: For the allocation, using CRASH_MAX_MEMMAP_NR instead of KEXEC_MAX_SEGMENTS + 1 seems more understandable. Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH v9 0/7] kexec: put bzImage and ramdisk above 4G for x86 64bit

2013-03-04 Thread Simon Horman
On Thu, Feb 21, 2013 at 08:07:49PM -0800, Yinghai Lu wrote: Now we have limit kdump reserved under 896M, because kexec has the limitation. and also bzImage need to stay under 4g. kernel parts changes get merged to linus tree already. Thanks, applied.

Re: [PATCH] kexec: lengthen the kernel command line image

2013-03-04 Thread Simon Horman
On Mon, Feb 04, 2013 at 01:53:55PM -0600, Cliff Wickman wrote: From: Cliff Wickman c...@sgi.com The crash kernel's boot command line is not long enough to contain the necessary memmap= options for a large memory. The fix is simple, as long as the boot loader's command line is also long

Re: [PATCH] kexec x86: drop truncation warning for crash kernel

2013-03-04 Thread Simon Horman
On Mon, Feb 25, 2013 at 12:00:07PM -0600, Cliff Wickman wrote: From: Cliff Wickman c...@sgi.com On kexec set-up of a crash kernel on a very large memory machine we sometimes see the worrisome warning: Too many memory ranges, truncating... meaning that the total count of e820 ram, reserved

Re: [PATCH] kexec: include reserved e820 sections in crash kernel

2013-03-04 Thread Simon Horman
On Mon, Feb 04, 2013 at 01:54:00PM -0600, Cliff Wickman wrote: From: Cliff Wickman c...@sgi.com The crash kernel is not able to find its root device if that device is not on PCI 0. This is because it is booted with the command line option memmap=exactmap which currently clears the e820

Re: [PATCH v2 0/2] kexec: Limit the crash memory ranges according to first kernel's memory limit.

2013-03-04 Thread Simon Horman
On Tue, Feb 12, 2013 at 04:16:50PM +0530, Mahesh J Salgaonkar wrote: So far powerpc kernel never exported memory limit information which is reflected by mem= kernel cmdline option. Hence, kexec-tools always use to build ELF header for entire system RAM generating a dump bigger than the actual

Re: [PATCH] kexec: fix some compiler warnings

2013-03-04 Thread Simon Horman
On Tue, Dec 25, 2012 at 04:30:27PM +0800, Zhang Yanfei wrote: I got the following warnings when I compiled kexec-tools: kexec/kexec-elf-rel.c: In function 'elf_rel_load': kexec/kexec-elf-rel.c:367: warning: format '%lx' expects type 'long unsigned int', but argument 6 has type 'unsigned

Re: [PATCH] kexec,x86: code optimization and adjustment for add_memmap and delete_memmap

2013-03-04 Thread Simon Horman
On Tue, Feb 26, 2013 at 09:58:14AM +0900, HATAYAMA Daisuke wrote: From: Zhang Yanfei zhangyan...@cn.fujitsu.com Subject: [PATCH] kexec,x86: code optimization and adjustment for add_memmap and delete_memmap Date: Mon, 25 Feb 2013 20:38:41 +0800 The code in the two functions seems a little

Re: [PATCH] kexec: use dbgprintf instead of #if 0 for debug printing

2013-03-04 Thread Simon Horman
On Tue, Dec 25, 2012 at 05:35:51PM +0800, Zhang Yanfei wrote: Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- kexec/arch/i386/kexec-x86-common.c | 28 ++-- kexec/kexec.c | 18 +- 2 files changed, 19 insertions(+), 27

Re: [PATCH] kexec: consolidate crash late initialization

2013-03-04 Thread Simon Horman
On Wed, May 30, 2012 at 02:05:09PM +0400, Vladimir Davydov wrote: Use one module_init() instead of two. I'm not sure I understand the motivation for this change. --- kernel/kexec.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/kernel/kexec.c

Re: [PATCH] kexec/ppc: Fix kernel program entry point while changing the load addr

2013-03-03 Thread Simon Horman
[ Cc: linuxppc-...@lists.ozlabs.org ] On Sun, Mar 03, 2013 at 01:06:00PM +0530, Suzuki K. Poulose wrote: From: Suzuki K. Poulose suz...@in.ibm.com uImage probe fills the entry point (ep) based on the load_addr from the uImage headers. If we change the load_addr, we should accordingly update

Re: [PATCH v3 1/2] kexec: fix wrong types of some local variables

2013-02-28 Thread Simon Horman
: Andrew Morton a...@linux-foundation.org Cc: Simon Horman ho...@verge.net.au Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com No complaints here. Reviewed-by: Simon Horman ho...@verge.net.au --- kernel/kexec.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] kexec: use min_t/max_t to avoid 'if (foo == bar)' thing

2013-02-24 Thread Simon Horman
: Eric W. Biederman ebied...@xmission.com Cc: Andrew Morton a...@linux-foundation.org Cc: Simon Horman ho...@verge.net.au Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- kernel/kexec.c | 20 +--- 1 files changed, 5 insertions(+), 15 deletions(-) diff --git a/kernel

Re: [PATCH v2] kexec: Use min_t to simplify logic

2013-02-24 Thread Simon Horman
. Thanks Simon. Hi Zhang, thanks for the update. Signed-off-by: Simon Horman ho...@verge.net.au Cc: Eric W. Biederman ebied...@xmission.com Cc: Andrew Morton a...@linux-foundation.org Cc: Simon Horman ho...@verge.net.au Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com --- kernel/kexec.c

Re: [PATCH] kexec: fix memory leak in function kimage_normal_alloc

2013-02-23 Thread Simon Horman
: Andrew Morton a...@linux-foundation.org Cc: Sasha Levin sasha.le...@oracle.com Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Reviewed-by: Simon Horman ho...@verge.net.au --- kernel/kexec.c | 18 ++ 1 files changed, 10 insertions(+), 8 deletions(-) diff --git

Re: [PATCH] kexec: avoid freeing NULL pointer in function kimage_crash_alloc

2013-02-23 Thread Simon Horman
: Andrew Morton a...@linux-foundation.org Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Reviewed-by: Simon Horman ho...@verge.net.au --- kernel/kexec.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/kernel/kexec.c b/kernel/kexec.c index

Re: [PATCH 2/2] kexec: add additional check when getting memory info

2013-01-29 Thread Simon Horman
On Fri, Jan 11, 2013 at 04:58:45PM +0800, Zhang Yanfei wrote: This check makes sure that we indeed get the memory information. Signed-off-by: Zhang Yanfei zhangyan...@cn.fujitsu.com Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH 1/2] kexec,x86: remove duplicate get_memory_ranges

2013-01-29 Thread Simon Horman
On Tue, Jan 15, 2013 at 12:56:02PM +0800, Zhang Yanfei wrote: 于 2013年01月11日 16:57, Zhang Yanfei 写道: At first, we have already filled the kexec_info.memory_ranges by calling my_load() - get_memory_ranges(). So if we want to get the memory information, we could just use the existing one

Re: [PATCH 0/3] Make use of new memmap= kernel parameter syntax

2013-01-29 Thread Simon Horman
On Tue, Jan 22, 2013 at 04:02:12PM +0100, Thomas Renninger wrote: Details were discussed on quite some lists (kexec, lkml, x86, etc) in a kernel thread with subject: [PATCH] x86 e820: only void usable memory areas in memmap=exactmap case The patch that memmap= can take several arguments is

Re: [PATCH 0/3] Make use of new memmap= kernel parameter syntax

2013-01-29 Thread Simon Horman
On Tue, Jan 29, 2013 at 11:40:46PM -0600, H. Peter Anvin wrote: The right thing to do as I have discussed with the people involved is to modify the memory map data structure to have a new memory type ID for memory which is to be dumped. That eliminates the need to put all this info into the

Re: [PATCH v7 0/7] kexec: put bzImage and ramdisk above 4G for x86 64bit

2013-01-25 Thread Simon Horman
On Thu, Jan 24, 2013 at 12:44:17PM -0800, Yinghai Lu wrote: Now we have limit kdump reserved under 896M, because kexec has the limitation. and also bzImage need to stay under 4g. kernel parts changes could be found at:

Re: [PATCH] x86: update x86_linux_header

2013-01-17 Thread Simon Horman
On Thu, Jan 17, 2013 at 07:47:25PM +0100, Olaf Hering wrote: Update struct x86_linux_header with new fields, based on arch/x86/include/asm/bootparam.h as included in linux-3.7. Upcoming changes will use the payload_offset/payload_length fields. Signed-off-by: Olaf Hering o...@aepfle.de Cc:

Re: [PATCH] kexec,i386: Remove unnecessary if condition check

2013-01-10 Thread Simon Horman
On Thu, Jan 10, 2013 at 05:25:04PM +0800, Zhang Yanfei wrote: If we load the relocatable bzImage, the boot protocol must = 2.05, So the if condition check is unnecessary. Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH] kexec-zImage-arm: simply cmdline-related DTB resizing

2012-12-22 Thread Simon Horman
On Thu, Dec 20, 2012 at 10:01:25AM +0800, Daniel Mack wrote: On 12/20/2012 07:19 AM, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com When resizing a dtb to add the command-line, only resize the DTB once, rather than once to add the /chosen node, and once to add the bootargs

[PATCH 2/3] build: Use cross compiler's strip if available

2012-12-22 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- Makefile.in |1 + configure.ac |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile.in b/Makefile.in index 99b4bb3..384cf0b 100644 --- a/Makefile.in +++ b/Makefile.in @@ -220,6 +220,7 @@ echo:: @echo CC

[PATCH 1/3] die: Use const for fmt

2012-12-22 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/kexec.c |2 +- kexec/kexec.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kexec/kexec.c b/kexec/kexec.c index 9d8..89ec182 100644 --- a/kexec/kexec.c +++ b/kexec/kexec.c @@ -53,7 +53,7 @@ unsigned long

[PATCH 3/3] build: Restrict scope of per-arch compiler flags

2012-12-22 Thread Simon Horman
Restrict the scope of compiler flags set in per-arch Makefiles to the architecture the Makefile belongs to. Signed-off-by: Simon Horman ho...@verge.net.au --- Makefile.in |4 ++-- kexec/arch/arm/Makefile |2 +- kexec/arch/ppc/Makefile |4 ++-- 3 files changed, 5

Re: [PATCH] kexec-elf-ppc: Fix crashkernel region overflow check

2012-12-17 Thread Simon Horman
On Mon, Dec 17, 2012 at 11:11:48PM +0100, Anders Hedlund wrote: Signed-off-by: Anders Hedlund anders.j.hedl...@gmail.com Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] kexec-zImage-arm: add code to support --command-line along with --dtb

2012-12-14 Thread Simon Horman
On Fri, Dec 14, 2012 at 10:20:21AM +0100, Sven Neumann wrote: Hi, On Thu, 2012-12-13 at 14:35 +0100, Daniel Mack wrote: If --dtb is called together with --command-line, we need to modify the binary dtb buffer. Luckily, we have libfdt functions available, so this is straight forward.

Re: [PATCH 1/5] Fix xen_cpuid() inline asm to not clobber stack's red zone

2012-12-14 Thread Simon Horman
On Thu, Dec 13, 2012 at 04:48:46PM +0100, Olaf Hering wrote: Port xen-unstable changeset 24344:72f4e4cb7440 to kexec-tools: Pushing stuff onto the stack on x86-64 when we do not specify -mno-red-zone is unsafe. Since the complicated asm is due to register pressure on i386, we simply

Re: kexec: ppc exec stack fix

2012-12-12 Thread Simon Horman
On Mon, Dec 10, 2012 at 11:07:32AM +0800, Dave Young wrote: execstack shows ppc kexec has an executable stack, this leaves it vulnerable to buffer overflows. Fix it by adding ASFLAGS --noexecstack Tested on PowerMac G4 Macmini: Without the patch: dave@darkstar:~/kexec-tools$ execstack

Re: [PATCH] kexec: Fix compile errors in crashdump-mips.c

2012-12-03 Thread Simon Horman
On Thu, Nov 29, 2012 at 04:12:38PM -0800, David Daney wrote: On 11/29/2012 04:02 PM, Simon Horman wrote: On Thu, Nov 29, 2012 at 12:02:49PM -0800, David Daney wrote: From: David Daney david.da...@cavium.com When building configured as '--host=mips64-octeon-linux-gnu' using GCC-4.7.0

Re: [PATCH v5 0/5] kexec: put bzImage and ramdisk above 4G for x86 64bit

2012-12-03 Thread Simon Horman
Hi Everyone, there was some healthy discussion around the previous versions of this series, but so far none on this version. Have we reached consensus? On Wed, Nov 28, 2012 at 02:09:49PM -0800, Yinghai Lu wrote: Now we have limit kdump reserved under 896M, because kexec has the limitation. and

Re: [PATCH 2/2] fs2dt: check for initrd_size != 0 when adding initrd entries

2012-11-26 Thread Simon Horman
On Mon, Nov 26, 2012 at 01:14:43PM +0100, Daniel Mack wrote: This prevents the creation of chosen/linux,initrd-{start,stop} entries with zero length. Signed-off-by: Daniel Mack zon...@gmail.com Thanks, applied. ___ kexec mailing list

Re: [PATCH] kexec x86_64: Make purgatory relocatable anywhere in the 64bit address space.

2012-11-20 Thread Simon Horman
On Mon, Nov 19, 2012 at 08:56:22AM -0800, Eric W. Biederman wrote: Remove kexec/arch/i386/compat_x6_64.S purgatory/arch/i386/linux-entry16.S and purgatory/arch/i386/entry16.S Those were early attempts at entry32-16.S that should have been deleted long ago. Strip the purgatory code of

[ANNOUNCE] kexec-tools 2.0.4-rc1

2012-11-20 Thread Simon Horman
Hi all, I am happy to announce the release of kexec-tools 2.0.4-rc1. I would like this release candidate to present an opportunity for discussion of what if any changes need to be made in order to release v2.0.4. The release can be downloaded from kernel.org:

Re: [PATCH][V2] vmcore-dmesg: Determine correct machine pointer size

2012-11-14 Thread Simon Horman
On Wed, Nov 14, 2012 at 03:38:43PM +0800, Dave Young wrote: On 11/14/2012 12:38 AM, Vivek Goyal wrote: A 32bit arch can prepare ELF64 headers. For example for PAE case to preresent file offsets 64bit but data size at the offset still remains 32bit. If we just base our decision based on

Re: [PATCH] ppc/uImage: Find new kernel load_addr if the default addr is not available

2012-11-07 Thread Simon Horman
On Wed, Nov 07, 2012 at 06:00:43PM +, McClintock Matthew-B29882 wrote: On Wed, Nov 7, 2012 at 7:36 AM, Suzuki K. Poulose suz...@in.ibm.com wrote: From: Suzuki K. Poulose suz...@in.ibm.com If the kernel cannot be loaded at the default load_addr, provided by the image, we should try

Re: [RFC] Kdump with UEFI secure boot (Re: [PATCH v2] kdump: pass acpi_rsdp= to 2nd kernel for efi booting)

2012-10-22 Thread Simon Horman
On Mon, Oct 22, 2012 at 04:43:39PM -0400, Vivek Goyal wrote: On Fri, Oct 19, 2012 at 10:31:12AM -0400, Vivek Goyal wrote: [..] - What happens to purgatory code. It is unsigned piece of code which runs in kernel? Thinking more about it, another not so clean proposal. I have always

Re: [PATCH v2] kdump: pass acpi_rsdp= to 2nd kernel for efi booting

2012-10-18 Thread Simon Horman
On Thu, Oct 18, 2012 at 02:20:46PM -0700, Eric W. Biederman wrote: Dave Young dyo...@redhat.com writes: In case efi booting, kdump need kernel parameter acpi_rsdp= to retrieve the acpi root table physical address. Add a function cmdline_add_efi to get the address from

Re: [PATCH] kexec: fix Makefile.in binaries_arch

2012-10-10 Thread Simon Horman
On Tue, Oct 09, 2012 at 09:33:56PM -0600, Khalid Aziz wrote: On Tue, 2012-10-09 at 17:35 -0700, Tony Jones wrote: Definitions of BINARIES_ARCH in Makefile.in seems to have been broken since commit 0775c60eb. Signed-off-by: Tony Jones to...@suse.com --- diff --git a/Makefile.in

Re: [PATCH 0/7] Add device-tree support to kexec-tools for ARM

2012-09-11 Thread Simon Horman
On Mon, Sep 10, 2012 at 09:53:58AM +0100, Will Deacon wrote: On Mon, Sep 10, 2012 at 01:05:50AM +0100, Simon Horman wrote: On Fri, Sep 07, 2012 at 10:11:19AM +0100, Matthew Leach wrote: Hi all, Running a kexec() on ARM platforms has become an issue as information about the platform

Re: [PATCH 0/7] Add device-tree support to kexec-tools for ARM

2012-09-09 Thread Simon Horman
how the kernel-side of things will pan out, but an incremental patch can be made to kexec-tools if needed and this series shouldn't break any existing support Does that work for you? Matt Matthew Leach (1): ARM: Add device tree support to the ARM platform Simon Horman (6): libfdt: Move

Re: [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM

2012-09-06 Thread Simon Horman
Hi Will, On Thu, Sep 06, 2012 at 10:01:28AM +0100, Will Deacon wrote: Hi guys, On Thu, Sep 06, 2012 at 04:29:02AM +0100, Simon Horman wrote: On Wed, Sep 05, 2012 at 03:34:09PM +0100, Matthew Leach wrote: Also, I use a different segment for the dtb rather than appending

Re: [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM

2012-09-06 Thread Simon Horman
On Thu, Sep 06, 2012 at 12:04:50PM +0100, Matthew Leach wrote: Hi Simon, I have been having some issues using kexec with your dtb patches... Thanks. It was that part of the code that I spent the bulk of my time on. And although it is still has a few rough edges I would be happy for it

Re: [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM

2012-09-06 Thread Simon Horman
On Thu, Sep 06, 2012 at 10:14:06AM +0100, Will Deacon wrote: On Thu, Sep 06, 2012 at 10:09:14AM +0100, Simon Horman wrote: Hi Will, On Thu, Sep 06, 2012 at 10:01:28AM +0100, Will Deacon wrote: Hi guys, On Thu, Sep 06, 2012 at 04:29:02AM +0100, Simon Horman wrote: On Wed, Sep

Re: [PATCH] kexec: Fix the purgatory Makefile to build arch specific purgatory code.

2012-09-06 Thread Simon Horman
On Thu, Sep 06, 2012 at 02:43:55PM +0530, Mahesh J Salgaonkar wrote: From: Mahesh Salgaonkar mah...@linux.vnet.ibm.com The latest commit 5e48916 has removed a line from purgatory/Makefile that was responsible for building arch specific purgatory code. This causes kexec -p (loading of panic

Re: [PATCH]kdump: pass noefi and acpi_rsdp= to 2nd kernel

2012-09-05 Thread Simon Horman
On Wed, Sep 05, 2012 at 01:44:45PM +0800, Dave Young wrote: In case efi booting, kdump need kernel parameter noefi and acpi_rsdp= to disable efi reinit and retrieve the acpi root table physical address. Add a function cmdline_add_efi to get the address from /sys/firmware/efi/systab If

Re: [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM

2012-09-05 Thread Simon Horman
On Wed, Sep 05, 2012 at 12:43:59PM +0100, Matthew Leach wrote: Hi all, Running a kexec() on newer ARM platforms has become an issue as information about the platform that is presented via device-tree is required to boot a new kernel. The ATAGs kernel code is re-used, replacing the ATAGs

Re: [RFC PATCH 0/4] Add device-tree support to kexec-tools for ARM

2012-09-05 Thread Simon Horman
Hi Matt, On Wed, Sep 05, 2012 at 03:34:09PM +0100, Matthew Leach wrote: Hi Simon, Hi Matt, are you aware that I posted patches to add ARM DT support to kexec-tools a few weeks ago? Ah, I missed that... I'm not particularly concerned which version goes in, but perhaps we can

[PATCH 2/7] kexec-elf.h: Include headers for types used

2012-08-28 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/kexec-elf.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kexec/kexec-elf.h b/kexec/kexec-elf.h index 99cb80b..d0e9dc0 100644 --- a/kexec/kexec-elf.h +++ b/kexec/kexec-elf.h @@ -1,6 +1,9 @@ #ifndef KEXEC_ELF_H #define KEXEC_ELF_H

[PATCH 0/7] Generic DT handling and DT support for ARM

2012-08-28 Thread Simon Horman
Hi, the primary purpose of this series is to add devices tree (DT) support to ARM which is as close as possible to the behaviour provided for 32 and 64 bit powerpc. In order to try to move away from one dt implementation per architecture this series, patches 1-3 of this series attempt to provide

[PATCH 6/7] arm: Make use of memory_ranges

2012-08-28 Thread Simon Horman
Make use of struct memory_ranges and provide a global usablemem_rgns. This is in preparation for adding device tree support. Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/arch/arm/crashdump-arm.c | 45 ++ kexec/arch/arm/crashdump-arm.h | 2

[PATCH 5/7] powerpc: Move 32bit powerpc to use generic fs2dt code

2012-08-28 Thread Simon Horman
Compile tested only Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/arch/ppc/Makefile| 7 +- kexec/arch/ppc/crashdump-powerpc.c | 2 +- kexec/arch/ppc/crashdump-powerpc.h | 2 + kexec/arch/ppc/fs2dt.c | 450 - kexec/arch

[PATCH 4/7] ppc64: Move 64bit powerpc to use generic fs2dt code

2012-08-28 Thread Simon Horman
Compile tested only Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/arch/ppc64/Makefile | 7 +- kexec/arch/ppc64/crashdump-ppc64.c | 3 +- kexec/arch/ppc64/crashdump-ppc64.h | 4 + kexec/arch/ppc64/fs2dt.c | 744 - kexec/arch

[PATCH 7/7] arm: Add Device Tree support

2012-08-28 Thread Simon Horman
to the existing atags behaviour, synthesising atags from /proc/atags This patch has undergone light testing using an Armadillo 800 EVA board in conjunction with a 3.6-rc3 kernel. Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/arch/arm/Makefile | 8 +++ kexec/arch/arm

[PATCH 3/7] fs2dt: Add a generic copy of fs2dt

2012-08-28 Thread Simon Horman
and thus more care is needed when migrating that architecture to this code. Unfortunately I do not have any powerpc equipment available to test this code. Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/Makefile| 6 + kexec/arch_reuse_initrd.c | 2 + kexec/fs2dt.c

Re: [PATCH] kdump: remove unused including generated/utsrelease.h

2012-08-26 Thread Simon Horman
On Sat, Aug 25, 2012 at 10:18:20AM +0800, Wei Yongjun wrote: From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove including generated/utsrelease.h that don't need it. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Reviewed-by: Simon Horman ho...@verge.net.au Andrew, could

Re: [PATCH] kexec-tools: Read always one vmcoreinfo file

2012-08-06 Thread Simon Horman
On Thu, Aug 02, 2012 at 06:27:24AM -0700, Daniel Kiper wrote: Hi, If you spot any error in any logfile which in your opinion is relevent to our testes please send me it. Hi, is there any consensus on what to do here? As I know Petr was going to do some tests. I have

Re: [PATCH] kexec-tools: Read always one vmcoreinfo file

2012-08-01 Thread Simon Horman
On Tue, Jul 24, 2012 at 03:54:10PM +0200, Daniel Kiper wrote: On Tue, Jul 24, 2012 at 10:18:34AM +0200, Petr Tesarik wrote: Dne Po 23. ??ervence 2012 22:10:59 Daniel Kiper napsal(a): Hi Petr, On Mon, Jul 23, 2012 at 03:30:55PM +0200, Petr Tesarik wrote: Dne Po 23. ??ervence 2012

[PATCH] build: Avoid duplicate files in tarball

2012-08-01 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/Makefile | 75 +++--- kexec/arch/arm/Makefile| 2 +- kexec/arch/ppc/Makefile| 3 +- kexec/arch/sh/Makefile | 3 +- kexec/arch/x86_64/Makefile | 12 +--- purgatory

Re: [PATCH] vmcore-dmesg: vmcore-dmesg: Make it work with new structured logging format

2012-07-31 Thread Simon Horman
On Mon, Jul 30, 2012 at 01:32:48PM -0400, Vivek Goyal wrote: Now kernel has made kernel logging structured and exsisting vmcore-dmesg does not work with this new format. Hence kernel version 3.5 is broken. In 3.6 now a kernel patch has been put which exports relevant fields. This patch parses

Re: [PATCH] vmcore-dmesg: Do not write beyond end of allocated buffer

2012-07-23 Thread Simon Horman
On Mon, Jul 23, 2012 at 10:35:12AM -0400, Vivek Goyal wrote: On Wed, Jul 18, 2012 at 09:33:51AM -0400, Vivek Goyal wrote: [..] + char temp_buf[1024]; + bool last_line = false; Is there a chance of over-running temp_buf? I would be more comfortable if there was

Re: [PATCH] vmcore-dmesg: Do not write beyond end of allocated buffer

2012-07-23 Thread Simon Horman
On Wed, Jul 18, 2012 at 09:33:51AM -0400, Vivek Goyal wrote: On Wed, Jul 18, 2012 at 07:40:32AM +0900, Simon Horman wrote: On Tue, Jul 17, 2012 at 11:23:00AM -0400, Vivek Goyal wrote: scan_vmcoreinfo() currently assumes that every line in vmcoreinfo note ends with \n and overwrites

Re: [PATCH] vmcore-dmesg: Do not write beyond end of allocated buffer

2012-07-17 Thread Simon Horman
On Tue, Jul 17, 2012 at 11:23:00AM -0400, Vivek Goyal wrote: scan_vmcoreinfo() currently assumes that every line in vmcoreinfo note ends with \n and overwrites new line character with \0. But last entry in note, CRASHTIME= does not end with \n and this leads to corrupting memory as we write

Re: [PATCH] [ppc] Do not reserve cpu spin-table for crash kernel

2012-07-13 Thread Simon Horman
On Thu, Jul 05, 2012 at 01:26:56PM +0530, Suzuki K. Poulose wrote: On 06/25/2012 04:47 PM, Suzuki K. Poulose wrote: Simon, Ping. Sorry, I completely missed this! I'll apply the change ASAP. ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH] [ppc] Do not reserve cpu spin-table for crash kernel

2012-07-13 Thread Simon Horman
On Thu, May 24, 2012 at 11:39:45AM +0530, Suzuki K. Poulose wrote: As of now, the kexec reserves the spin-table for all the CPUs on an SMP machine. The spin-table is pointed to by the cpu-release-addr property in the device-tree. Reserving the spin-table in the crash kernel will cause a

Re: [PATCH] kexec-tools: Read always one vmcoreinfo file

2012-07-06 Thread Simon Horman
On Thu, Jul 05, 2012 at 02:16:35PM +0200, Daniel Kiper wrote: vmcoreinfo file could exists under /sys/kernel (valid on baremetal only) and/or under /sys/hypervisor (valid when Xen dom0 is running). Read only one of them. It means that only one PT_NOTE will be always created. Remove extra code

Re: [PATCH 1/2] Check format string of die()

2012-06-26 Thread Simon Horman
On Wed, Jun 27, 2012 at 12:53:42AM +0700, Aleksey Makarov wrote: Use gcc's __attribute__ to check format string. Signed-off-by: Aleksey Makarov aleksey.maka...@gmail.com Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

<    3   4   5   6   7   8   9   10   11   12   >