Re: [PATCH 2/2] Fix format strings of die()

2012-06-26 Thread Simon Horman
On Wed, Jun 27, 2012 at 12:53:43AM +0700, Aleksey Makarov wrote: One of them caused crash when user specifies a file that does not exist. Signed-off-by: Aleksey Makarov aleksey.maka...@gmail.com Thanks, applied. ___ kexec mailing list

Re: KDUMP on ARM 2.6.29

2012-06-19 Thread Simon Horman
On Tue, Jun 19, 2012 at 04:07:13PM +, nandu.ah...@accenture.com wrote: Is Kdump onARM supported ? Which kernel mainline are they supported. Any information available? I am trying to port Kdump on my ARM board/emulator with SMP enabled but haven't got any clue if this is supported. I have

Re: [PATCH] Support kernel_noload uImage type

2012-06-17 Thread Simon Horman
On Sat, Jun 16, 2012 at 04:52:15PM +0900, Alexandre Courbot wrote: Do not trigger an error when loading a uImage with the IH_TYPE_KERNEL_NOLOAD type. These images do not need to be copied to their load address before being executed. All archs (excepted PPC) do not use the uImage load and

Re: [PATCH] Load bzImages smaller than 32 KiB

2012-06-12 Thread Simon Horman
On Tue, Jun 05, 2012 at 07:46:07PM -0400, Eric Biggers wrote: Allow bzImages smaller than 32KiB to be kexec'ed. The current code will fail to load a bzImage smaller than 32768 bytes (sizeof struct x86_linux_header), but the 'memdisk' program that comes with syslinux is only about 26 KiB.

Re: [PATCH] ppc/ppc64: Compile purgatory code with gcc option -msoft-float

2012-06-10 Thread Simon Horman
e90343c521b68237c17ea4e4ed376c4a726f0789 Author: Simon Horman ho...@verge.net.au Date: Fri Oct 6 12:27:58 2006 +0900 build-util_lib-optimisation-flags [BUILD] Make sure sha256.c is compiled without optimisation It is almost 6 years old now. Simon, can it be changed to -O2 now? I have no objections

Re: [PATCH] Load bzImages smaller than 32 KiB

2012-06-04 Thread Simon Horman
On Fri, Jun 01, 2012 at 10:59:32AM -0500, Eric Biggers wrote: Allow bzImages smaller than 32KiB to be kexec'ed. The current code will fail to load a bzImage smaller than 32768 bytes (sizeof struct x86_linux_header), but the 'memdisk' program that comes with syslinux is only about 26 KiB.

Re: [v2 PATCH] ppc: move DEBUG code to --debug

2012-05-23 Thread Simon Horman
On Wed, May 23, 2012 at 06:20:12PM +0530, Suzuki K. Poulose wrote: On 05/18/2012 08:29 AM, Simon Horman wrote: On Mon, May 14, 2012 at 02:34:56PM +0800, Cong Wang wrote: From: Cong Wangxiyou.wangc...@gmail.com From: Cong Wangxiyou.wangc...@gmail.com V2: Fix a compile error Like commit

Re: [v2 PATCH] ppc: move DEBUG code to --debug

2012-05-17 Thread Simon Horman
to --debug on ppc arch. Sorry that I still can't find a ppc32 machine to test this. Thank, I don't have any ppc32 (or 64) hardware to test on, but I did use a cross-compiler to check that it builds. Cc: Simon Horman ho...@verge.net.au Signed-off-by: Cong Wang xiyou.wangc...@gmail.com Applied

Re: [PATCH] Correct section number for shutdown and clarify what -e does in manpage

2012-04-22 Thread Simon Horman
On Fri, Apr 20, 2012 at 10:39:14AM -0600, Khalid Aziz wrote: Another patch that I have been carrying in debian kexec-tools package. It corrects the section number for shutdown in the man page. This patch also adds little more descriptive note for the -e option to clarify that this does not do

Re: [PATCH] Add more debug infos when usable memory range changing

2012-04-15 Thread Simon Horman
On Fri, Apr 13, 2012 at 05:32:42PM +0800, Han Pingtian wrote: In the past, we did neglected some usable memory range changing infos. With those deubg code added, we can now catch them. Thanks, applied. ___ kexec mailing list

Re: Add a descriptive error message for kexec load failure

2012-03-28 Thread Simon Horman
On Wed, Mar 28, 2012 at 01:09:02PM -0600, Khalid Aziz wrote: kexec-tools package for debian includes a patch that adds a more descriptive error message when someone tries to laod a crash kernel and didn't remember to boot up with crashkernel= parameter. This patch would be of general

Re: Doing kexec reboot right in systemd

2012-03-27 Thread Simon Horman
On Tue, Mar 27, 2012 at 12:01:36PM +0200, Lennart Poettering wrote: On Mon, 26.03.12 21:25, Marti Raudsepp (ma...@juffo.org) wrote: On Mon, Mar 26, 2012 at 21:07, Lennart Poettering lenn...@poettering.net wrote: Marti, sorry for changing my mind on this: would be great if you could

Re: Doing kexec reboot right in systemd

2012-03-22 Thread Simon Horman
On Thu, Mar 22, 2012 at 09:14:56PM +0200, Marti Raudsepp wrote: Hi list, Hi Marti, I was recently pondering how systemd could use kexec properly, in a reasonably general way, to make reboots faster. I exchanged an email with Poettering on the systemd list and he suggested me to ask here.

Re: [PATCH 2/5] ppc: move DEBUG code to --debug

2012-03-15 Thread Simon Horman
[CC linuxppc-...@ozlabs.org] On Thu, Mar 08, 2012 at 02:39:39PM +0800, Cong Wang wrote: Like patch 1/5, this one moves code under #if DEBUG to --debug on ppc arch. Signed-off-by: Cong Wang xiyou.wangc...@gmail.com --- kexec/arch/ppc/crashdump-powerpc.c | 18 --

Re: [PATCH 1/5] Add generic debug option

2012-03-15 Thread Simon Horman
On Tue, Mar 13, 2012 at 10:58:40AM +0800, Cong Wang wrote: On 03/13/2012 08:21 AM, Simon Horman wrote: On Thu, Mar 08, 2012 at 02:39:38PM +0800, Cong Wang wrote: Currently the debugging code is under #ifdef DEBUG, which means when we want to debug, we have to re-compile the source code

Re: [PATCH v2 resend] kdump x86: fix total mem size calculation for reservation

2012-03-15 Thread Simon Horman
-by: WANG Cong xiyou.wangc...@gmail.com Reviewed-by: Simon Horman ho...@verge.net.au Andrew, can you pick this up? It has been floating around without objections for a week now. --- arch/x86/kernel/setup.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) --- linux-2.6.orig

Re: [PATCH 1/2] boot: ignore early NMIs

2012-03-14 Thread Simon Horman
On Tue, Mar 13, 2012 at 09:33:50AM -0400, Don Zickus wrote: On Tue, Mar 13, 2012 at 11:11:49AM +0900, Fernando Luis Vázquez Cao wrote: On 03/13/2012 05:16 AM, H. Peter Anvin wrote: On 03/12/2012 01:04 PM, H. Peter Anvin wrote: On 03/12/2012 01:01 PM, Eric W. Biederman wrote: The basic

Re: kexec-tools-2.0.2 prints unnecessary message on stderr when loaded in VESA framebuffer

2012-03-12 Thread Simon Horman
), and the assignee suggested reporting upstream. Agreed, I have pushed the following patch into the kexec-tools git tree and it should be included in the next release. From f1facd4b11aa141ffd9bbacb2631ad18dc33669c Mon Sep 17 00:00:00 2001 From: Simon Horman ho...@verge.net.au Date: Mon, 12 Mar

Re: [PATCH 1/5] Add generic debug option

2012-03-12 Thread Simon Horman
On Thu, Mar 08, 2012 at 02:39:38PM +0800, Cong Wang wrote: Currently the debugging code is under #ifdef DEBUG, which means when we want to debug, we have to re-compile the source code with -DDEBUG. This is not convenient, we want to have a generic --debug option so that we can enable debugging

Re: [PATCH] kdump: force page alignment for per-CPU crash notes.

2012-02-29 Thread Simon Horman
On Wed, Feb 29, 2012 at 09:21:23AM -0800, Eugene Surovegin wrote: Per-CPU allocations are not guaranteed to be physically contiguous. However, kdump kernel and user-space code assumes that per-CPU memory, used for saving CPU registers on crash, is. This can cause corrupted /proc/vmcore in some

Re: [PATCH] kdump: force page alignment for per-CPU crash notes.

2012-02-29 Thread Simon Horman
On Wed, Feb 29, 2012 at 05:23:10PM -0800, Eugene Surovegin wrote: On Wed, Feb 29, 2012 at 5:18 PM, Simon Horman ho...@verge.net.au wrote: On Wed, Feb 29, 2012 at 09:21:23AM -0800, Eugene Surovegin wrote: Per-CPU allocations are not guaranteed to be physically contiguous. However, kdump

Re: [PATCH] kdump: force page alignment for per-CPU crash notes.

2012-02-29 Thread Simon Horman
On Thu, Mar 01, 2012 at 10:51:26AM +0900, HATAYAMA Daisuke wrote: From: Eugene Surovegin surove...@google.com Subject: Re: [PATCH] kdump: force page alignment for per-CPU crash notes. Date: Wed, 29 Feb 2012 17:39:55 -0800 On Wed, Feb 29, 2012 at 5:32 PM, Simon Horman ho...@verge.net.au

Re: [PATCH] kdump: force page alignment for per-CPU crash notes.

2012-02-29 Thread Simon Horman
On Wed, Feb 29, 2012 at 05:39:55PM -0800, Eugene Surovegin wrote: On Wed, Feb 29, 2012 at 5:32 PM, Simon Horman ho...@verge.net.au wrote: On Wed, Feb 29, 2012 at 05:23:10PM -0800, Eugene Surovegin wrote: On Wed, Feb 29, 2012 at 5:18 PM, Simon Horman ho...@verge.net.au wrote: On Wed, Feb

Re: [PATCH] kexec: crash: don't save swapper_pg_dir for !CONFIG_MMU configurations

2012-02-27 Thread Simon Horman
On Mon, Feb 27, 2012 at 07:30:54PM +, Will Deacon wrote: On Mon, Feb 27, 2012 at 12:37:30AM +, Simon Horman wrote: On Sun, Feb 26, 2012 at 10:58:42PM +, Will Deacon wrote: On Sat, Feb 25, 2012 at 02:37:49AM +, Simon Horman wrote: might this cover cases where

Re: [PATCH] kexec: crash: don't save swapper_pg_dir for !CONFIG_MMU configurations

2012-02-27 Thread Simon Horman
On Mon, Feb 27, 2012 at 03:56:43PM -0800, Andrew Morton wrote: On Tue, 28 Feb 2012 08:52:35 +0900 Simon Horman ho...@verge.net.au wrote: On Mon, Feb 27, 2012 at 07:30:54PM +, Will Deacon wrote: On Mon, Feb 27, 2012 at 12:37:30AM +, Simon Horman wrote: On Sun, Feb 26, 2012

Re: [PATCH] kexec: crash: don't save swapper_pg_dir for !CONFIG_MMU configurations

2012-02-27 Thread Simon Horman
On Mon, Feb 27, 2012 at 05:25:55PM -0800, Andrew Morton wrote: On Tue, 28 Feb 2012 09:51:30 +0900 Simon Horman ho...@verge.net.au wrote: On Mon, Feb 27, 2012 at 04:26:31PM -0800, Andrew Morton wrote: On Tue, 28 Feb 2012 09:19:28 +0900 Simon Horman ho...@verge.net.au wrote

Re: [PATCH] kexec: crash: don't save swapper_pg_dir for !CONFIG_MMU configurations

2012-02-26 Thread Simon Horman
On Sun, Feb 26, 2012 at 10:58:42PM +, Will Deacon wrote: On Sat, Feb 25, 2012 at 02:37:49AM +, Simon Horman wrote: On Fri, Feb 24, 2012 at 02:40:47PM +, Will Deacon wrote: nommu platforms don't have very interesting swapper_pg_dir pointers and usually just #define them to NULL

Re: [PATCH] Fix out-of-tree build

2012-02-07 Thread Simon Horman
On Tue, Feb 07, 2012 at 06:50:05PM -0500, Tyler Hall wrote: Use automatic variables for prerequisites when copying man pages and include a makefile relative to $(srcdir). Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org

Re: [Patch] kexec: make some functions static

2012-01-31 Thread Simon Horman
On Tue, Jan 31, 2012 at 02:58:09PM +0800, Cong Wang wrote: The following functions/variables can become static. Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: kexec 2.0.2 MIPS

2012-01-24 Thread Simon Horman
On Tue, Jan 24, 2012 at 10:35:42PM -0800, Maxim Uvarov wrote: 2012/1/24 Simon Horman ho...@verge.net.au: Hi, sorry for the extensive delay in responding to this. I am now back from Christmas, New Year, holidays and attending LCA 2012. On Fri, Dec 16, 2011 at 05:27:31AM +, ANDY

Re: [PATCH] kdump: Define KEXEC_NOTE_BYTES arch specific for s390x

2012-01-11 Thread Simon Horman
allocated memory is not sufficient. With this patch the KEXEC_NOTE_BYTES macro can be defined by architecture code and for s390x it is set to the correct size now. Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com This seems reasonable to me. Reviewed-by: Simon Horman ho

Re: [PATCH] Correct magic varible of function name in debug code

2012-01-09 Thread Simon Horman
On Mon, Jan 09, 2012 at 06:02:30PM +0800, Han Pingtian wrote: The magic varible of function name should be uppercase. Thanks, applied. ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] kexec-tools: s390: Do not create ELF header by default

2011-12-11 Thread Simon Horman
On Fri, Dec 09, 2011 at 02:42:19PM +0100, Michael Holzheu wrote: Hello Simon, From: Michael Holzheu holz...@linux.vnet.ibm.com For s390 we have two modes for kdump: For the first mode, as on all other architectures, the kexec tool creates the ELF header and the 2nd kernel processes it

Re: [PATCH v2 2/3] PM / Sleep: Replace mutex_[un]lock(pm_mutex) with [un]lock_system_sleep()

2011-12-06 Thread Simon Horman
instead. Suggested-by: Tejun Heo t...@kernel.org Signed-off-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com I am happy with this from a kexec point of view. Reviewed-by: Simon Horman ho...@verge.net.au --- kernel/kexec.c |4 ++-- kernel/power/hibernate.c | 16

Re: [PATCH] kdump: crashk_res init check for /sys/kernel/kexec_crash_size

2011-11-23 Thread Simon Horman
. goto unlock; } But I am happy with the patch without my above suggestion. Reviewed-by-by: Simon Horman ho...@verge.net.au ___ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH v2] kdump: crashk_res init check for /sys/kernel/kexec_crash_size

2011-11-23 Thread Simon Horman
to that this patch also simplifies the ret = -EINVAL vs. ret = 0 logic as suggested by Simon Horman. Cc: Simon Horman ho...@verge.net.au Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com Thanks Michael, Reviewed-by: Simon Horman ho...@verge.net.au

Re: [Patch] kexec: fix several issues in get_crash_notes()

2011-11-21 Thread Simon Horman
On Mon, Nov 21, 2011 at 03:43:34PM +0800, Cong Wang wrote: On Fri, Nov 18, 2011 at 10:11 AM, Simon Horman ho...@verge.net.au wrote: On Wed, Nov 16, 2011 at 09:09:26PM +0800, WANG Cong wrote: a) We don't need 'crash_notes' array at all, save some bytes on stack. b) We forgot to fclose 'fp

Re: [Patch] fix rpm build errors

2011-11-21 Thread Simon Horman
On Mon, Nov 21, 2011 at 04:26:04PM +0800, Cong Wang wrote: a) rpmbuild doesn't like '-' in version, replace it with '.'. b) update the files installed in kexec-tools.spec Signed-off-by: WANG Cong xiyou.wangc...@gmail.com Thanks, applied. ___ kexec

Re: kexec-tools git tree is tagged incorrectly?

2011-11-17 Thread Simon Horman
On Wed, Nov 16, 2011 at 10:51:03AM -0500, Don Zickus wrote: On Wed, Nov 16, 2011 at 11:35:03AM +0900, Simon Horman wrote: On Wed, Nov 16, 2011 at 10:04:06AM +0800, Américo Wang wrote: On Wed, Nov 16, 2011 at 9:12 AM, Simon Horman ho...@verge.net.au wrote: Hi Américo, I'm

Re: [Patch] kexec: improve the debug printf in get_crash_notes_per_cpu()

2011-11-17 Thread Simon Horman
On Wed, Nov 16, 2011 at 09:19:44PM +0800, WANG Cong wrote: Signed-off-by: WANG Cong xiyou.wangc...@gmail.com Thanks, applied. --- diff --git a/kexec/crashdump.c b/kexec/crashdump.c index 945b052..e7ac42c 100644 --- a/kexec/crashdump.c +++ b/kexec/crashdump.c @@ -102,8 +102,8 @@ int

Re: [Patch] kexec: fix several issues in get_crash_notes()

2011-11-17 Thread Simon Horman
On Wed, Nov 16, 2011 at 09:09:26PM +0800, WANG Cong wrote: a) We don't need 'crash_notes' array at all, save some bytes on stack. b) We forgot to fclose 'fp' before return. Signed-off-by: WANG Cong xiyou.wangc...@gmail.com --- diff --git a/kexec/arch/i386/crashdump-x86.c

Re: [PATCH 1/3] kexec-tools: powerpc: Fix 64bit optimize for size (gcc -Os) build

2011-11-17 Thread Simon Horman
On Tue, Nov 15, 2011 at 09:00:38AM +1030, Alan Modra wrote: On Tue, Nov 15, 2011 at 09:24:06AM +1100, Anton Blanchard wrote: I wonder why we aren't building and linking an -fpic object, wouldn't it make the relocation code much simpler? No, powerpc64 is PIC anyway. Hi Alan, Hi Anton, Hi

Re: kexec-tools git tree is tagged incorrectly?

2011-11-15 Thread Simon Horman
On Tue, Nov 15, 2011 at 08:51:15PM +0800, Américo Wang wrote: Hello, Simon, I am wondering why I get: % git log --pretty=oneline -n 1 920f4ededd9627add3ca1cdea965d204f2ca43a7 kexec-tools: powerpc: Add more 64bit relocations % git describe v1.101-618-g920f4ed % git tag -l v1.101

Re: kexec-tools git tree is tagged incorrectly?

2011-11-15 Thread Simon Horman
On Wed, Nov 16, 2011 at 10:04:06AM +0800, Américo Wang wrote: On Wed, Nov 16, 2011 at 9:12 AM, Simon Horman ho...@verge.net.au wrote: Hi Américo, I'm not sure that I understand your question, but 920f4ededd9627add3ca1cdea965d204f2ca43a7 is the HEAD of the master (development) branch

Re: [PATCH 1/3] kexec-tools: powerpc: Fix 64bit optimize for size (gcc -Os) build

2011-11-14 Thread Simon Horman
On Mon, Nov 14, 2011 at 06:53:29PM +1100, Anton Blanchard wrote: commit 46b2d0b8a719 (kexec/powerpc fix optimization for size (gcc -Os) build) added out of line GPR save/restore handlers for 32bit -Os builds. This patch adds the handlers for 64bit builds. Signed-off-by: Anton Blanchard

Re: [PATCH] remove unnecessary check code for hole_align

2011-11-08 Thread Simon Horman
On Tue, Nov 08, 2011 at 04:22:08PM +0900, Simon Horman wrote: On Tue, Nov 08, 2011 at 01:26:23PM +0800, Dave Young wrote: hole_align == 0 check is not neccesary, because it will be set to pagesize if it's zero. Just remove it here. Hi Dave, it looks like the if condition can never

Re: [PATCH] remove unnecessary check code for hole_align

2011-11-07 Thread Simon Horman
On Tue, Nov 08, 2011 at 01:26:23PM +0800, Dave Young wrote: hole_align == 0 check is not neccesary, because it will be set to pagesize if it's zero. Just remove it here. Hi Dave, it looks like the if condition can never be true due to hole_base being set to a non-zero value on the previous

Re: [PATCH] kexec-tools: s390: Fix memory detection for memory hotplug

2011-10-31 Thread Simon Horman
On Fri, Oct 28, 2011 at 03:35:35PM +0200, Michael Holzheu wrote: Hello Simon, Here comes the patch... On Thu, 2011-10-27 at 07:31 +0900, Simon Horman wrote: On Tue, Oct 25, 2011 at 07:17:17PM +0200, Michael Holzheu wrote: To fix this I could parse /sys/devices/system/memory and exclude

Re: kdump: A memory hotplug issue on s390

2011-10-26 Thread Simon Horman
On Tue, Oct 25, 2011 at 07:17:17PM +0200, Michael Holzheu wrote: Hello Simon and Vivek, For s390 we currently use /proc/iomem for defining the memory layout in the kexec elfcore header. Unfortunately this is not correct, when using memory hotplug. When a memory chunk is set offline (e.g.

Re: [PATCH] kexec: powerpc: crash_dump: No backup region for PPC BookE

2011-10-21 Thread Simon Horman
On Mon, Oct 10, 2011 at 03:23:19PM +0530, Suzuki Poulose wrote: On 10/03/11 15:48, Suzuki K. Poulose wrote: Disable backup regions for BookE in case of a CRASH Dump, as they can be run from anywhere. The patch introduces --with-booke option to support the BookE. With the patch, we get :

Re: Possible regression in kexec on ARM ARMv6 and ARMv7 cores

2011-10-21 Thread Simon Horman
On Thu, Oct 20, 2011 at 05:08:24PM +0900, Simon Horman wrote: On Thu, Oct 20, 2011 at 08:01:06AM +0100, Will Deacon wrote: On Thu, Oct 20, 2011 at 05:24:45AM +0100, Simon Horman wrote: Hi Will, Hi All, Hi Simon, Hi Will, it appears that ARM: proc: add definition of cpu_reset

Re: Possible regression in kexec on ARM ARMv6 and ARMv7 cores

2011-10-21 Thread Simon Horman
On Fri, Oct 21, 2011 at 09:46:41AM +0100, Will Deacon wrote: On Fri, Oct 21, 2011 at 09:34:26AM +0100, Simon Horman wrote: I have tested the kexec/mmu-off branch of your tree on the UP board I mentioned above and kexec works :) Hurrah! Thanks for giving it a spin. You mention UP

Re: [PATCH] intel-iommu:make identity_map default for crash dump

2011-10-21 Thread Simon Horman
On Fri, Oct 21, 2011 at 08:31:54PM +0800, Dave Young wrote: kdump kernel sometimes will get DMAR faults which is caused by random in-flight dma from 1st kernel Here make the identity_mapping as default for this case This seems reasonable to me. Although I am curious to know what the side

Re: Possible regression in kexec on ARM ARMv6 and ARMv7 cores

2011-10-21 Thread Simon Horman
On Fri, Oct 21, 2011 at 10:15:24AM +0100, Will Deacon wrote: On Fri, Oct 21, 2011 at 09:59:58AM +0100, Simon Horman wrote: On Fri, Oct 21, 2011 at 09:46:41AM +0100, Will Deacon wrote: The more difficult case is when you want to offline the secondary CPUs into a pen and then boot them

Re: Possible regression in kexec on ARM ARMv6 and ARMv7 cores

2011-10-20 Thread Simon Horman
On Thu, Oct 20, 2011 at 08:01:06AM +0100, Will Deacon wrote: On Thu, Oct 20, 2011 at 05:24:45AM +0100, Simon Horman wrote: Hi Will, Hi All, Hi Simon, Hi Will, it appears that ARM: proc: add definition of cpu_reset for ARMv6 and ARMv7 cores (f4daf06fc23b99df5ca5b3e892428b91e148cc52

Possible regression in kexec on ARM ARMv6 and ARMv7 cores

2011-10-19 Thread Simon Horman
Hi Will, Hi All, it appears that ARM: proc: add definition of cpu_reset for ARMv6 and ARMv7 cores (f4daf06fc23b99df5ca5b3e892428b91e148cc52), which was introduced for 3.1-rc1, causes a regression and that kexec no longer works on ARM. The board that I am testing on is a Renesas Mackerel which

Re: [PATCH v2] sh: Take into account the base of System RAM in virt_to_phys()

2011-10-12 Thread Simon Horman
On Wed, Oct 12, 2011 at 05:24:23PM +0900, Magnus Damm wrote: On Mon, Oct 3, 2011 at 10:05 AM, Simon Horman ho...@verge.net.au wrote: Previously virt_to_phys() assumed that physical memory always started at address 0. This is not always the case. Tested on an sh7757lcr (32bit system) whose

[PATCH 1/2] sh: Correct logic errors in is_32bit()

2011-10-12 Thread Simon Horman
This corrects logic errors so that is_32bit() can actually detect that it is running on a 32 bit system - something the original version I wrote failed at woefully. Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/arch/sh/kexec-sh.c | 20 +++- 1 files changed, 11

[PATCH 2/2] sh: On 32bit segments may not be in P2

2011-10-12 Thread Simon Horman
Cc: Paul Mundt let...@linux-sh.org Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/arch/sh/kexec-sh.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/kexec/arch/sh/kexec-sh.c b/kexec/arch/sh/kexec-sh.c index a397d08..7710fdf 100644 --- a/kexec/arch/sh

[PATCH v2] sh: Take into account the base of System RAM in virt_to_phys()

2011-10-02 Thread Simon Horman
Previously virt_to_phys() assumed that physical memory always started at address 0. This is not always the case. Tested on an sh7757lcr (32bit system) whose only System RAM region is 4000-4eff and an ecovec24 (29bit system). Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/arch

Re: kexec 2.0.2 MIPS

2011-09-29 Thread Simon Horman
On Thu, Sep 29, 2011 at 06:03:42PM +, ANDY KENNEDY wrote: My bad, yes the idea is to check between 2.0.1 and 2.0.2. I will explain git bisect further down. However, it looking at the logs it strikes me that there was only one significant MIPS change between 2.0.1 and 2.0.2. So that

Re: kexec: load-preserve-context option on s390

2011-09-28 Thread Simon Horman
On Mon, Sep 26, 2011 at 03:09:09PM +0200, Michael Holzheu wrote: Hello Simon, I think the --load-preserve-context and --load-jump-back-helper kexec options are not working on s390 because we do not support CONFIG_KEXEC_JUMP. I assume the same is true also on other architectures. Correct me,

Re: kexec 2.0.2 MIPS

2011-09-21 Thread Simon Horman
On Wed, Sep 21, 2011 at 03:45:21AM +, ANDY KENNEDY wrote: On Mon, Sep 19, 2011 at 08:14:21PM +, ANDY KENNEDY wrote: Guys, sorry for the long lines on that last e-mail attempt. I, unfortunately, have to use LookOut at work. This is a better formatted message: Attempting to

Re: kexec 2.0.2 MIPS

2011-09-20 Thread Simon Horman
On Mon, Sep 19, 2011 at 08:14:21PM +, ANDY KENNEDY wrote: Guys, sorry for the long lines on that last e-mail attempt. I, unfortunately, have to use LookOut at work. This is a better formatted message: Attempting to make kexec work for Mips32r2. 2.0.1 works, 2.0.2 doesn't. Looking

Re: [RFC] sh: Take into account the base of physical memory in virt_to_phys()

2011-09-17 Thread Simon Horman
On Fri, Sep 16, 2011 at 07:59:21PM +0900, Magnus Damm wrote: On Thu, Sep 15, 2011 at 8:12 PM, Simon Horman ho...@verge.net.au wrote: Previously virt_to_phys() assumed that physical memory always started at address 0. This is not always the case. I think most boards have NOR Flash or ROM

Re: [PATCH] kexec-tools: s390: Find correct address for ramdisk

2011-09-17 Thread Simon Horman
On Fri, Sep 16, 2011 at 02:46:04PM +0200, Michael Holzheu wrote: Hello Simon, From: Michael Holzheu holz...@linux.vnet.ibm.com When the kernel image size is larger than 8 MiB on s390, we currently can't load the ramdisk, because it is loaded to the fix address 8 MiB (RAMDISK_ORIGIN_ADDR)

[PATCH] sh: kexec: Add PHYSICAL_START

2011-09-15 Thread Simon Horman
on MEMORY_START on such systems. Signed-off-by: Simon Horman ho...@verge.net.au --- arch/sh/Kconfig | 13 - arch/sh/boot/Makefile|6 -- arch/sh/include/asm/page.h | 10 ++ arch/sh/kernel/vmlinux.lds.S |2 +- arch/sh/mm/init.c

Re: [PATCH] ARM: kdump: copy kernel relocation code at the kexec prepare stage

2011-09-15 Thread Simon Horman
On Thu, Sep 15, 2011 at 10:32:09PM -0700, Lei Wen wrote: This copy really don't need to do at the very second before the kernel would crash. Signed-off-by: Lei Wen lei...@marvell.com This seems reasonable to me. Acked-by: Simon Horman ho...@verge.net.au

Re: [PATCH] kexec-tools: Add --append option for s390

2011-09-07 Thread Simon Horman
On Wed, Sep 07, 2011 at 10:42:50AM +0200, Michael Holzheu wrote: Hello Simon, From: Michael Holzheu holz...@linux.vnet.ibm.com All architectures define the --append option together with the --command-line option to specify kernel parameters. This option is also used by kdump init scripts.

Re: [PATCH] kexec: sh: Fixed command line management.

2011-09-05 Thread Simon Horman
On Mon, Sep 05, 2011 at 05:02:24PM +0200, Angelo CASTELLO wrote: This fixes the command line management to be rightly used by elf-sh and zImage-sh type formats. Basically, the issue was on use of --append option for both set and append the STRING at the cmdline. With this patch we correctly

[PATCH] [RFC] sh: kexec: Register crashk_res

2011-09-01 Thread Simon Horman
Register crashk_res so that it can be used by kexec-tools via /proc/iomem. On x86 the registration occurs using insert_resource(iomem_resource, crashk_res). However that approach seems to result in the boot hanging on SH. Signed-off-by: Simon Horman ho...@verge.net.au --- arch/sh/kernel/setup.c

Re: [PATCH] kexec-tools: include minor klibc porting

2011-08-09 Thread Simon Horman
On Mon, Aug 08, 2011 at 08:43:08PM +0200, maximilian attems wrote: These 2 uncommon include pathes are the first stumbling blocks to build kexec-tools against klibc. Of course more is needed, but this is a first step. On the klibc step there is still stuff needed, but it is already possible

Re: [PATCH] kexec-tools: powerpc: dt_reserve doesn't allocate enough memory for large properties

2011-07-25 Thread Simon Horman
On Mon, Jul 25, 2011 at 05:35:42PM +1000, Anton Blanchard wrote: On a large ppc64 box I got the following error from kexec -l: unrecoverable error: could not read /proc/device-tree/ibm,dynamic-reconfiguration-memory/ibm,dynamic-memory: Bad address dt_reserve was assuming a property

Re: [PATCH] [v3] kexec-tools: ppc32: Fixup ThreadPointer for purgatory code

2011-07-12 Thread Simon Horman
On Tue, Jul 12, 2011 at 03:20:40PM +0530, Suzuki K. Poulose wrote: PPC32 ELF ABI expects r2 to be loaded with Thread Pointer, which is 0x7000 bytes past the end of TCB. Though the purgatory is single threaded, it uses TCB scratch space in vsnprintf(). This patch allocates a 1024byte TCB and

Re: [PATCH] ARM: conditional ioremap() fix for copy_oldmem_page()

2011-06-22 Thread Simon Horman
-by: Simon Horman ho...@verge.net.au --- arch/arm/kernel/crash_dump.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) --- 0001/arch/arm/kernel/crash_dump.c +++ work/arch/arm/kernel/crash_dump.c 2011-06-18 20:59:49.0 +0900 @@ -39,9 +39,13 @@ ssize_t

Re: [RFC][PATCH] kexec-tools: powerpc: Use the #address-cells information to parsememory/reg - V2

2011-06-15 Thread Simon Horman
On Wed, Jun 08, 2011 at 12:08:55PM +0530, Suzuki Poulose wrote: Hi, This is version 2 of the patch Changes from Version 1 : : Changed the interface for read_memory_region_limits to use 'int fd' instead of FILE*. : Use sizeof(variable) for read(, instead of sizeof(type). ---

Re: [RFC Patch 5/6] slimdump: Capture slimdump for fatal MCE generated crashes

2011-05-26 Thread Simon Horman
On Thu, May 26, 2011 at 03:10:08PM -0400, Vivek Goyal wrote: On Thu, May 26, 2011 at 08:58:38PM +0200, Andi Kleen wrote: If we are just extracting and saving MCE registers from vmcore, then reboot time does not increase. It increases only if user decides to extract and save extra data

Re: [PATCH] detect Xen dom0 properly to avoid conflict with pv_on_hvm domU

2011-05-05 Thread Simon Horman
On Wed, May 04, 2011 at 06:32:32PM +0200, Olaf Hering wrote: A Xen HVM guest with PV drivers loaded has also a /proc/xen directory. But such a guest is an ordinary PC and the special handling for dom0 breaks kdump in this environment. Test for /proc/xen/capabilities instead and cache the

Re: [Patch] kexec: remove duplicated backup_src_start field from struct crash_elf_info

2011-04-28 Thread Simon Horman
On Thu, Apr 28, 2011 at 09:15:39AM -0400, Vivek Goyal wrote: On Thu, Apr 28, 2011 at 03:57:48PM +0800, Cong Wang wrote: 于 2011年04月27日 23:01, Vivek Goyal 写道: Amerigo, Now who will do following initialization for ppc? info-backup_src_start = BACKUP_SRC_START; info-backup_sz =

Re: [Patch] kexec: remove duplicated backup_src_start field from struct crash_elf_info

2011-04-28 Thread Simon Horman
On Fri, Apr 29, 2011 at 10:59:40AM +0800, Cong Wang wrote: 于 2011年04月29日 06:05, Simon Horman 写道: On Thu, Apr 28, 2011 at 09:15:39AM -0400, Vivek Goyal wrote: On Thu, Apr 28, 2011 at 03:57:48PM +0800, Cong Wang wrote: 于 2011年04月27日 23:01, Vivek Goyal 写道: Amerigo, Now who will do following

Re: [Patch] kexec: fix a compiler warning on ppc64

2011-04-27 Thread Simon Horman
/../../kexec-syscall.h:115:1: warning: this is the location of the previous definition This is due to that ppc64 defines bot __powerpc64__ and __powerpc__, this patch fixes that warning. Signed-off-by: WANG Cong amw...@redhat.com Cc: Simon Horman ho...@verge.net.au Thanks, applied

Re: [Patch] kexec: remove duplicated backup_src_start field from struct crash_elf_info

2011-04-27 Thread Simon Horman
and ppc64, and used a test case from Dave Anderson to confirm the backup region is correct on i686. Signed-off-by: WANG Cong amw...@redhat.com Cc: Vivek Goyal vgo...@redhat.com Cc: Simon Horman ho...@verge.net.au Thanks, applied. ___ kexec mailing list

Re: kexec-tools support for add_efi_memmap

2011-04-27 Thread Simon Horman
On Tue, Apr 26, 2011 at 02:24:50PM -0400, Ben Romer wrote: Hi Simon! I'm working on supporting linux on a Unisys virtualization platform called s-Par, and I've put together a patch for kexec-tools that I'd like to submit. s-Par is an EFI-based virtualization system that splits up a machine

Re: [PATCH] Fix memory access errors for kexec PPC

2011-04-27 Thread Simon Horman
On Wed, Apr 20, 2011 at 03:02:02PM +0530, Suzuki Poulose wrote: Hi, I was trying the kexec for ppc32 and came across a couple of memory errors while running with glibc. The attached patch is the outcome of the glibc's alerts ! We define buf[MAXBYTES-1] and issue fread(buf, 1, MAXBYTES,

Re: [PATCH V2] kexec, x86: fix kexec when?boot_params.hardware_subarch != 0

2011-04-27 Thread Simon Horman
On Fri, Apr 01, 2011 at 11:00:51AM +0900, Simon Horman wrote: On Thu, Mar 31, 2011 at 05:21:15PM +, Chris Leech wrote: Simon Horman horms@... writes: On Tue, Mar 29, 2011 at 09:04:53AM +, WANG Cong wrote: On Mon, 28 Mar 2011 14:50:11 -0700, Chris Leech wrote

Re: [PATCH 2.0.2] use /proc/iomem for map with add_efi_memmap kernel option

2011-04-27 Thread Simon Horman
On Wed, Apr 27, 2011 at 08:56:09AM -0400, Ben Romer wrote: This patch changes the behavior of the kexec loader when the add_efi_memmap option is present on the currently running kernel's command line, to read the kernel memory map from /proc/iomem instead of /sys/firmware/memmap. On EFI

Re: [Patch] kexec: fix the missing i386 part in commit 1100580b05e

2011-04-18 Thread Simon Horman
On Sun, Apr 17, 2011 at 04:29:05PM +0800, Amerigo Wang wrote: Vivek pointed out that I missed the i386 part in this commit, commit 1100580b05e3fdfe648d9be8617d962b11f4b88b Author: Amerigo Wang amw...@redhat.com Date: Thu Mar 3 00:10:43 2011 +0800 get the

Re: kexec release schedule?

2011-04-18 Thread Simon Horman
On Mon, Apr 18, 2011 at 03:15:22PM +, McClintock Matthew-B29882 wrote: Hello Simon, I wanted to inquire about the next kexec release. The current release (2.0.2) has a few bugs that prevent mpc85xx from working that are fixed in git head. Any plans to make a 2.0.3 release? Hi Matthew,

Re: [PATCH V2] kexec, x86: fix kexec when?boot_params.hardware_subarch != 0

2011-03-31 Thread Simon Horman
On Thu, Mar 31, 2011 at 05:21:15PM +, Chris Leech wrote: Simon Horman horms@... writes: On Tue, Mar 29, 2011 at 09:04:53AM +, WANG Cong wrote: On Mon, 28 Mar 2011 14:50:11 -0700, Chris Leech wrote: kexec needs to keep the subarch setting the same as the running kernel

Re: [PATCH V2] kexec, x86: fix kexec when boot_params.hardware_subarch != 0

2011-03-29 Thread Simon Horman
On Tue, Mar 29, 2011 at 09:04:53AM +, WANG Cong wrote: On Mon, 28 Mar 2011 14:50:11 -0700, Chris Leech wrote: kexec needs to keep the subarch setting the same as the running kernel in the boot parameters, or the kernel will die in early setup. I ran into this with X86_SUBARCH_MRST,

[PATCH 3/3] Don't compare signed and unsigned types

2011-03-29 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- vmcore-dmesg/vmcore-dmesg.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c index 4c1475c..8518150 100644 --- a/vmcore-dmesg/vmcore-dmesg.c +++ b

[PATCH 2/3] Remove assigned but otherwise unused variables

2011-03-29 Thread Simon Horman
Signed-off-by: Simon Horman ho...@verge.net.au --- kexec/arch/x86_64/kexec-elf-x86_64.c |3 --- kexec/kexec.c|4 +--- vmcore-dmesg/vmcore-dmesg.c |3 +-- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/kexec/arch/x86_64/kexec-elf-x86_64

Re: [PATCH] kexec, x86: fix kexec when boot_params.hardware_subarch != 0

2011-03-28 Thread Simon Horman
On Mon, Mar 28, 2011 at 12:40:49PM -0700, Chris Leech wrote: kexec needs to keep the subarch setting the same as the running kernel in the boot parameters, or the kernel will die in early setup. I ran into this with X86_SUBARCH_MRST, but it should apply to CE4100 and any future subarch that

Re: [PATCH V2] kexec, x86: fix kexec when boot_params.hardware_subarch != 0

2011-03-28 Thread Simon Horman
On Mon, Mar 28, 2011 at 02:50:11PM -0700, Chris Leech wrote: kexec needs to keep the subarch setting the same as the running kernel in the boot parameters, or the kernel will die in early setup. I ran into this with X86_SUBARCH_MRST, but it should apply to CE4100 and any future subarch that

Re: [PATCH 2/2] Avoid signed/unsigned comparsions

2011-03-03 Thread Simon Horman
On Thu, Mar 03, 2011 at 01:53:33PM -0800, Eric W. Biederman wrote: Simon Horman ho...@verge.net.au writes: At least the change of ret from ssize_t to size_t is bogus. pread returns a ssize_t and I am comparing it against sizeof(X). We might as we type convert in the comparison. That test

Re: [PATCH 1/2] Remove bogus check for too many program headers

2011-03-03 Thread Simon Horman
On Thu, Mar 03, 2011 at 01:50:09PM -0800, Eric W. Biederman wrote: Simon Horman ho...@verge.net.au writes: This test appears bogus because the e_phnum element of Elf32_Phdr and is an unsigned 16bit entity. The test is a basic sanity check, that apparently can never fail. So I see

Re: [PULL] x86_64 kdump fixes

2011-03-03 Thread Simon Horman
On Thu, Mar 03, 2011 at 01:48:54PM -0800, Eric W. Biederman wrote: These are bug fixes that were tested several months ago and I forgot to ask for them to be pulled. I have tested against the latest tree and these changes still apply and build cleanly.

Re: [Patch] get the backup area dynamically

2011-03-02 Thread Simon Horman
On Wed, Mar 02, 2011 at 11:44:21AM -0500, Vivek Goyal wrote: On Thu, Mar 03, 2011 at 12:10:43AM +0800, Amerigo Wang wrote: Currently we hard-coded the first 640K area as backup area, however, this is not correct on some system which has reserved memory area in the first 640K:

[PATCH 1/2] Remove bogus check for too many program headers

2011-03-02 Thread Simon Horman
vmcore-dmesg/vmcore-dmesg.c: In function ‘read_elf64’: vmcore-dmesg/vmcore-dmesg.c:192: warning: comparison is always false due to limited range of data type Cc: Eric W. Biederman ebied...@xmission.com Signed-off-by: Simon Horman ho...@verge.net.au --- vmcore-dmesg/vmcore-dmesg.c |8

[PATCH 2/2] Avoid signed/unsigned comparsions

2011-03-02 Thread Simon Horman
Cc: Eric W. Biederman ebied...@xmission.com Signed-off-by: Simon Horman ho...@verge.net.au --- vmcore-dmesg/vmcore-dmesg.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/vmcore-dmesg/vmcore-dmesg.c b/vmcore-dmesg/vmcore-dmesg.c index 365e293..f7eef16 100644

<    4   5   6   7   8   9   10   11   12   13   >