Re: [PATCH 1/2 v5] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-25 Thread lijiang
在 2019年10月25日 11:39, Eric W. Biederman 写道: > lijiang writes: > >> * Returns the length of the argument (regardless of if it was >> * truncated to fit in the buffer), or -1 on not found. >> */ >> static int >> __cmdline_find_option(const char *cmdline, int max_cmdline_size, >>

RE: [PATCH 1/2 v5] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-24 Thread d.hatay...@fujitsu.com
...@kernel.org; kexec@lists.infradead.org; > dhowe...@redhat.com; mi...@redhat.com; b...@alien8.de; ebied...@xmission.com; > h...@zytor.com; t...@linutronix.de; dyo...@redhat.com; vgo...@redhat.com > Subject: Re: [PATCH 1/2 v5] x86/kdump: always reserve the low 1MiB when the > crashkernel option is s

Re: [PATCH 1/2 v5] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-24 Thread Eric W. Biederman
lijiang writes: > * Returns the length of the argument (regardless of if it was > * truncated to fit in the buffer), or -1 on not found. > */ > static int > __cmdline_find_option(const char *cmdline, int max_cmdline_size, > const char *option, char *buffer, int bufsize) >

Re: [PATCH 1/2 v5] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-24 Thread lijiang
; jgr...@suse.com; thomas.lenda...@amd.com; >> b...@redhat.com; x...@kernel.org; kexec@lists.infradead.org; >> dhowe...@redhat.com; mi...@redhat.com; b...@alien8.de; ebied...@xmission.com; >> h...@zytor.com; t...@linutronix.de; dyo...@redhat.com; vgo...@redhat.com >> Subje

Re: [PATCH 1/2 v5] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-24 Thread lijiang
在 2019年10月24日 19:33, lijiang 写道: > 在 2019年10月24日 18:07, Simon Horman 写道: >> Hi Linbo, >> >> thanks for your patch. >> >> On Wed, Oct 23, 2019 at 10:19:11PM +0800, Lianbo Jiang wrote: >>> Kdump kernel will reuse the first 640k region because the real mode >>> trampoline has to work in this area. Whe

Re: [PATCH 1/2 v5] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-24 Thread lijiang
在 2019年10月24日 18:07, Simon Horman 写道: > Hi Linbo, > > thanks for your patch. > > On Wed, Oct 23, 2019 at 10:19:11PM +0800, Lianbo Jiang wrote: >> Kdump kernel will reuse the first 640k region because the real mode >> trampoline has to work in this area. When the vmcore is dumped, the >> old memor

Re: [PATCH 1/2 v5] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-24 Thread Simon Horman
Hi Linbo, thanks for your patch. On Wed, Oct 23, 2019 at 10:19:11PM +0800, Lianbo Jiang wrote: > Kdump kernel will reuse the first 640k region because the real mode > trampoline has to work in this area. When the vmcore is dumped, the > old memory in this area may be accessed, therefore, kernel h

[PATCH 1/2 v5] x86/kdump: always reserve the low 1MiB when the crashkernel option is specified

2019-10-23 Thread Lianbo Jiang
Kdump kernel will reuse the first 640k region because the real mode trampoline has to work in this area. When the vmcore is dumped, the old memory in this area may be accessed, therefore, kernel has to copy the contents of the first 640k area to a backup region so that kdump kernel can read the old