Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-12-09 Thread Michal Suchánek
Hello, On Wed, Dec 08, 2021 at 08:50:54PM -0500, Nayna wrote: > > On 11/25/21 13:02, Michal Suchanek wrote: > > Hello, > > Hi Michael, > > > > > This is resend of the KEXEC_SIG patchset. > > > > The first patch is new because it'a a cleanup that does not require any > > change to the module v

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-12-08 Thread Nayna
On 11/25/21 13:02, Michal Suchanek wrote: Hello, Hi Michael, This is resend of the KEXEC_SIG patchset. The first patch is new because it'a a cleanup that does not require any change to the module verification code. The second patch is the only one that is intended to change any functional

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-12-08 Thread Philipp Rudo
Hi Michal, On Tue, 7 Dec 2021 18:32:21 +0100 Michal Suchánek wrote: > On Tue, Dec 07, 2021 at 05:10:14PM +0100, Philipp Rudo wrote: > > Hi Michal, > > > > i finally had the time to take a closer look at the series. Except for > > the nit in patch 4 and my personal preference in patch 6 the code

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-12-07 Thread Michal Suchánek
On Tue, Dec 07, 2021 at 05:10:14PM +0100, Philipp Rudo wrote: > Hi Michal, > > i finally had the time to take a closer look at the series. Except for > the nit in patch 4 and my personal preference in patch 6 the code looks > good to me. > > What I don't like are the commit messages on the first

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-12-07 Thread Philipp Rudo
Hi Michal, i finally had the time to take a closer look at the series. Except for the nit in patch 4 and my personal preference in patch 6 the code looks good to me. What I don't like are the commit messages on the first commits. In my opinion they are so short that they are almost useless. For e

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-12-01 Thread Michal Suchánek
Hello, On Wed, Dec 01, 2021 at 10:37:47AM +0800, Baoquan He wrote: > Hi, > > On 11/25/21 at 07:02pm, Michal Suchanek wrote: > > Hello, > > > > This is resend of the KEXEC_SIG patchset. > > > > The first patch is new because it'a a cleanup that does not require any > > change to the module verif

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-11-30 Thread Baoquan He
Hi, On 11/25/21 at 07:02pm, Michal Suchanek wrote: > Hello, > > This is resend of the KEXEC_SIG patchset. > > The first patch is new because it'a a cleanup that does not require any > change to the module verification code. > > The second patch is the only one that is intended to change any > f

Re: [PATCH v2 0/6] KEXEC_SIG with appended signature

2021-11-30 Thread Heiko Carstens
On Thu, Nov 25, 2021 at 07:02:38PM +0100, Michal Suchanek wrote: > Hello, > > This is resend of the KEXEC_SIG patchset. > > The first patch is new because it'a a cleanup that does not require any > change to the module verification code. > > The second patch is the only one that is intended to c

[PATCH v2 0/6] KEXEC_SIG with appended signature

2021-11-25 Thread Michal Suchanek
Hello, This is resend of the KEXEC_SIG patchset. The first patch is new because it'a a cleanup that does not require any change to the module verification code. The second patch is the only one that is intended to change any functionality. The rest only deduplicates code but I did not receive a