Re: [PATCH v25 01/10] drivers/base: refactor cpu.c to use .is_visible()

2023-08-03 Thread Greg KH
On Thu, Aug 03, 2023 at 01:20:28PM -0500, Eric DeVolder wrote: > > > On 7/21/23 11:32, Eric DeVolder wrote: > > > > > > On 7/3/23 11:53, Eric DeVolder wrote: > > > > > > > > > On 7/3/23 08:05, Greg KH wrote: > > > > On Thu, Jun 29, 2023 at 03:21:10PM -0400, Eric DeVolder wrote: > > > > >   -

Re: [PATCH v25 01/10] drivers/base: refactor cpu.c to use .is_visible()

2023-08-03 Thread Eric DeVolder
On 7/21/23 11:32, Eric DeVolder wrote: On 7/3/23 11:53, Eric DeVolder wrote: On 7/3/23 08:05, Greg KH wrote: On Thu, Jun 29, 2023 at 03:21:10PM -0400, Eric DeVolder wrote:   - the function body of the callback functions are now wrapped with     IS_ENABLED(); as the callback function

Re: [PATCH v25 01/10] drivers/base: refactor cpu.c to use .is_visible()

2023-07-21 Thread Eric DeVolder
On 7/3/23 11:53, Eric DeVolder wrote: On 7/3/23 08:05, Greg KH wrote: On Thu, Jun 29, 2023 at 03:21:10PM -0400, Eric DeVolder wrote:   - the function body of the callback functions are now wrapped with     IS_ENABLED(); as the callback function must exist now that the     attribute is

Re: [PATCH v25 01/10] drivers/base: refactor cpu.c to use .is_visible()

2023-07-03 Thread Eric DeVolder
On 7/3/23 08:05, Greg KH wrote: On Thu, Jun 29, 2023 at 03:21:10PM -0400, Eric DeVolder wrote: - the function body of the callback functions are now wrapped with IS_ENABLED(); as the callback function must exist now that the attribute is always compiled-in (though not necessarily

Re: [PATCH v25 01/10] drivers/base: refactor cpu.c to use .is_visible()

2023-07-03 Thread Greg KH
On Thu, Jun 29, 2023 at 03:21:10PM -0400, Eric DeVolder wrote: > - the function body of the callback functions are now wrapped with >IS_ENABLED(); as the callback function must exist now that the >attribute is always compiled-in (though not necessarily visible). Why do you need to do

[PATCH v25 01/10] drivers/base: refactor cpu.c to use .is_visible()

2023-06-29 Thread Eric DeVolder
Greg Kroah-Hartman requested that this file use the .is_visible() method instead of #ifdefs for the attributes in cpu.c. static struct attribute *cpu_root_attrs[] = { #ifdef CONFIG_ARCH_CPU_PROBE_RELEASE _attr_probe.attr, _attr_release.attr, #endif _attrs[0].attr.attr,