Re: [PATCH v4] panic: Fixes the panic_print NMI backtrace setting

2023-02-26 Thread Guilherme G. Piccoli
On 26/02/2023 02:44, Andrew Morton wrote: > On Fri, 10 Feb 2023 17:35:10 -0300 "Guilherme G. Piccoli" > wrote: > [...] >> Notice that while at it, I got rid of the "crash_kexec_post_notifiers" >> local copy in panic(). This was introduced by commit b26e27ddfd2a >> ("kexec: use core_param for

Re: [PATCH v4] panic: Fixes the panic_print NMI backtrace setting

2023-02-25 Thread Andrew Morton
On Fri, 10 Feb 2023 17:35:10 -0300 "Guilherme G. Piccoli" wrote: > Commit 8d470a45d1a6 ("panic: add option to dump all CPUs backtraces in > panic_print") > introduced a setting for the "panic_print" kernel parameter to allow > users to request a NMI backtrace on panic. Problem is that the

Re: [PATCH v4] panic: Fixes the panic_print NMI backtrace setting

2023-02-15 Thread Guilherme G. Piccoli
On 14/02/2023 11:46, Petr Mladek wrote: > [...] >> My understanding is that it's a mechanism to prevent some concurrency, >> in case some other CPU modify this variable while panic() is running. >> I find it very unlikely, hence I removed it - but if people consider >> this copy needed, I can

Re: [PATCH v4] panic: Fixes the panic_print NMI backtrace setting

2023-02-14 Thread Petr Mladek
On Fri 2023-02-10 17:35:10, Guilherme G. Piccoli wrote: > Commit 8d470a45d1a6 ("panic: add option to dump all CPUs backtraces in > panic_print") > introduced a setting for the "panic_print" kernel parameter to allow > users to request a NMI backtrace on panic. Problem is that the panic_print >

[PATCH v4] panic: Fixes the panic_print NMI backtrace setting

2023-02-10 Thread Guilherme G. Piccoli
Commit 8d470a45d1a6 ("panic: add option to dump all CPUs backtraces in panic_print") introduced a setting for the "panic_print" kernel parameter to allow users to request a NMI backtrace on panic. Problem is that the panic_print handling happens after the secondary CPUs are already disabled,