Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-06-20 Thread Coiby Xu
On Fri, Jun 17, 2022 at 07:58:37AM -0400, Mimi Zohar wrote: On Fri, 2022-06-17 at 11:57 +0800, Coiby Xu wrote: >Thanks for explaining IMA to me! There is still the question of what's >the root of trust for .builtin_trusted_keys when there is no real >signature verification. For example, when

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-06-17 Thread Mimi Zohar
On Thu, 2022-06-16 at 09:21 +0800, Coiby Xu wrote: > Hi Mimi, > > On Thu, Jun 09, 2022 at 11:35:13AM -0400, Mimi Zohar wrote: > >Hi Coiby, > > > >On Fri, 2022-05-27 at 21:43 +0800, Coiby Xu wrote: > >> It seems I need to only change cover letter and commit message i.e. > >> there is no concern

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-06-17 Thread Mimi Zohar
On Fri, 2022-06-17 at 11:57 +0800, Coiby Xu wrote: > >Thanks for explaining IMA to me! There is still the question of what's > >the root of trust for .builtin_trusted_keys when there is no real > >signature verification. For example, when CONFIG_KEXEC_SIG is enabled, > >the default IMA policy is

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-06-16 Thread Coiby Xu
On Thu, Jun 16, 2022 at 09:15:06AM +0800, Coiby Xu wrote: Hi Mimi, Thanks for carefully reviewing the covert letter and patches and suggesting various improvements! And sorry for the late reply as I need some time to learn more about secure boot, lockdown and IMA to better make sense of what

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-06-15 Thread Coiby Xu
Hi Mimi, On Thu, Jun 09, 2022 at 11:35:13AM -0400, Mimi Zohar wrote: Hi Coiby, On Fri, 2022-05-27 at 21:43 +0800, Coiby Xu wrote: It seems I need to only change cover letter and commit message i.e. there is no concern about the code. So it's better to provide a new cover letter here to

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-06-15 Thread Coiby Xu
Hi Mimi, Thanks for carefully reviewing the covert letter and patches and suggesting various improvements! And sorry for the late reply as I need some time to learn more about secure boot, lockdown and IMA to better make sense of what you mean. On Fri, May 27, 2022 at 12:45:54PM -0400, Mimi

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-06-09 Thread Mimi Zohar
Hi Coiby, On Fri, 2022-05-27 at 21:43 +0800, Coiby Xu wrote: > It seems I need to only change cover letter and commit message i.e. > there is no concern about the code. So it's better to provide a > new cover letter here to collect new feedback from you thus we > can avoid unnecessary rounds of

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-05-27 Thread Mimi Zohar
On Fri, 2022-05-27 at 21:43 +0800, Coiby Xu wrote: > Hi Mini, Hi Coiby, > new cover letter here to collect new feedback from you thus we > can avoid unnecessary rounds of patch set. Agreed. Much better. Just a couple of nits. > Currently when loading a kernel image via the

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-05-27 Thread Coiby Xu
Hi Mini, It seems I need to only change cover letter and commit message i.e. there is no concern about the code. So it's better to provide a new cover letter here to collect new feedback from you thus we can avoid unnecessary rounds of patch set. Currently when loading a kernel image via the

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-05-25 Thread Mimi Zohar
On Wed, 2022-05-25 at 17:59 +0800, Coiby Xu wrote: > Hi Mimi, > > On Fri, May 20, 2022 at 01:04:47PM -0400, Mimi Zohar wrote: > >Hi Coiby, > > > >On Thu, 2022-05-12 at 15:01 +0800, Coiby Xu wrote: > > > >The cover letter should start out with an overall problem description > >and then continue

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-05-25 Thread Coiby Xu
Hi Mimi, On Fri, May 20, 2022 at 01:04:47PM -0400, Mimi Zohar wrote: Hi Coiby, On Thu, 2022-05-12 at 15:01 +0800, Coiby Xu wrote: The cover letter should start out with an overall problem description and then continue with the specifics. In this case each of the arch's use different keyrings

Re: [PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-05-20 Thread Mimi Zohar
Hi Coiby, On Thu, 2022-05-12 at 15:01 +0800, Coiby Xu wrote: The cover letter should start out with an overall problem description and then continue with the specifics. In this case each of the arch's use different keyrings to validate the kexec kernel image signature. I would continue with

[PATCH v8 0/4] use more system keyrings to verify arm64 and s390 kexec kernel image signature

2022-05-12 Thread Coiby Xu
Currently, a problem faced by arm64 is if a kernel image is signed by a MOK key, loading it via the kexec_file_load() system call would be rejected with the error "Lockdown: kexec: kexec of unsigned images is restricted; see man kernel_lockdown.7". This happens because arm64 uses only the primary