Re: [PATCHv2 02/13] kernel/cpu: Add support for declaring CPU offlining not supported

2023-10-29 Thread Kirill A. Shutemov
On Sat, Oct 28, 2023 at 04:12:10PM +0200, Thomas Gleixner wrote: > On Fri, Oct 20 2023 at 18:12, Kirill A. Shutemov wrote: > > Subject: cpu/hotplug: ... > > > ACPI MADT doesn't allow to offline CPU after it got woke up. > > ACPI MADT is a table ... > > This is about the MADT mailbox wakeup

Re: [PATCHv2 02/13] kernel/cpu: Add support for declaring CPU offlining not supported

2023-10-28 Thread Thomas Gleixner
On Mon, Oct 23 2023 at 22:07, Kai Huang wrote: > On Mon, 2023-10-23 at 18:31 +0300, kirill.shute...@linux.intel.com wrote: >> On Mon, Oct 23, 2023 at 09:30:59AM +, Huang, Kai wrote: >> > IMHO it's a little bit odd to have two mechanisms in place, even in this >> > middle >> > state patch. Is

Re: [PATCHv2 02/13] kernel/cpu: Add support for declaring CPU offlining not supported

2023-10-28 Thread Thomas Gleixner
On Fri, Oct 20 2023 at 18:12, Kirill A. Shutemov wrote: Subject: cpu/hotplug: ... > ACPI MADT doesn't allow to offline CPU after it got woke up. ACPI MADT is a table ... This is about the MADT mailbox wakeup method, right? > Currently offlining hotplug prevented based on the confidential is

Re: [PATCHv2 02/13] kernel/cpu: Add support for declaring CPU offlining not supported

2023-10-23 Thread Huang, Kai
On Mon, 2023-10-23 at 18:31 +0300, kirill.shute...@linux.intel.com wrote: > On Mon, Oct 23, 2023 at 09:30:59AM +, Huang, Kai wrote: > > IMHO it's a little bit odd to have two mechanisms in place, even in this > > middle > > state patch. Is it better to completely replace

Re: [PATCHv2 02/13] kernel/cpu: Add support for declaring CPU offlining not supported

2023-10-23 Thread kirill.shute...@linux.intel.com
On Mon, Oct 23, 2023 at 09:30:59AM +, Huang, Kai wrote: > IMHO it's a little bit odd to have two mechanisms in place, even in this > middle > state patch. Is it better to completely replace CC_ATTR_HOTPLUG_DISABLED with > the new cpu_hotplug_offline_disabled in this patch? You can explicitly

Re: [PATCHv2 02/13] kernel/cpu: Add support for declaring CPU offlining not supported

2023-10-23 Thread Huang, Kai
On Fri, 2023-10-20 at 18:12 +0300, Kirill A. Shutemov wrote: > ACPI MADT doesn't allow to offline CPU after it got woke up. > > Currently offlining hotplug prevented based on the confidential > computing attribute which is set for Intel TDX. But TDX is not > the only possible user of the wake up

[PATCHv2 02/13] kernel/cpu: Add support for declaring CPU offlining not supported

2023-10-20 Thread Kirill A. Shutemov
ACPI MADT doesn't allow to offline CPU after it got woke up. Currently offlining hotplug prevented based on the confidential computing attribute which is set for Intel TDX. But TDX is not the only possible user of the wake up method. Introduce cpu_hotplug_not_supported() that can be called to