Re: [PATCHv4 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2023-12-22 Thread Kirill A. Shutemov
On Fri, Dec 15, 2023 at 09:29:13PM +0100, Thomas Gleixner wrote: > So this waits and then does nothing if the wait fails. What's the point? > > ... > > > Do we really need this specific hackery or is there some similar > identity mapping muck which can be generalized? I've addressed all your

Re: [PATCHv4 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2023-12-22 Thread Huang, Kai
On Fri, 2023-12-22 at 14:19 +0300, kirill.shute...@linux.intel.com wrote: > On Tue, Dec 05, 2023 at 11:36:55PM +, Huang, Kai wrote: > > > > > + > > > +static void acpi_mp_stop_other_cpus(int wait) > > > +{ > > > + smp_shutdown_nonboot_cpus(smp_processor_id()); > > > +} > > > > Is this and

Re: [PATCHv4 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2023-12-22 Thread kirill.shute...@linux.intel.com
On Tue, Dec 05, 2023 at 11:36:55PM +, Huang, Kai wrote: > > > + > > +static void acpi_mp_stop_other_cpus(int wait) > > +{ > > + smp_shutdown_nonboot_cpus(smp_processor_id()); > > +} > > Is this and ... > > + smp_ops.stop_other_cpus = acpi_mp_stop_other_cpus; > > ... this below still

Re: [PATCHv4 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2023-12-15 Thread Thomas Gleixner
On Tue, Dec 05 2023 at 03:45, Kirill A. Shutemov wrote: > MADT Multiprocessor Wakeup structure version 1 brings support of CPU > offlining: BIOS provides a reset vector where the CPU has to jump to > offline itself. CPU has to jump to for offlining itself. > The new TEST mailbox command can be

Re: [PATCHv4 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2023-12-05 Thread Huang, Kai
> + > +static void acpi_mp_stop_other_cpus(int wait) > +{ > + smp_shutdown_nonboot_cpus(smp_processor_id()); > +} Is this and ... + smp_ops.stop_other_cpus = acpi_mp_stop_other_cpus; ... this below still needed? I think the current native_stop_other_cpus() should just work given

[PATCHv4 14/14] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2023-12-04 Thread Kirill A. Shutemov
MADT Multiprocessor Wakeup structure version 1 brings support of CPU offlining: BIOS provides a reset vector where the CPU has to jump to offline itself. The new TEST mailbox command can be used to test the CPU offlined successfully and BIOS has control over it. Add CPU offling support for ACPI