Re: [PATCHv6 00/16] x86/tdx: Add kexec support

2024-01-31 Thread Baoquan He
On 01/31/24 at 01:07pm, Huang, Kai wrote: > > > Runtime disabling kexec looks better than at cmpile time, esp for > > > distros. While from above patch, making using of kexec_load_disabled > > > to achive the runtime disabling may not be so good. Because we have a > > > front door to enable it

RE: [PATCHv6 00/16] x86/tdx: Add kexec support

2024-01-31 Thread Huang, Kai
> > Runtime disabling kexec looks better than at cmpile time, esp for > > distros. While from above patch, making using of kexec_load_disabled > > to achive the runtime disabling may not be so good. Because we have a > > front door to enable it through: > > > > /proc/sys/kernel/kexec_load_disabled

Re: [PATCHv6 00/16] x86/tdx: Add kexec support

2024-01-31 Thread Nikolay Borisov
On 31.01.24 г. 14:47 ч., Baoquan He wrote: On 01/31/24 at 09:31am, Nikolay Borisov wrote: On 30.01.24 г. 15:43 ч., Paolo Bonzini wrote: On 1/24/24 13:55, Kirill A. Shutemov wrote: The patchset adds bits and pieces to get kexec (and crashkernel) work on TDX guest. The last patch

Re: [PATCHv6 00/16] x86/tdx: Add kexec support

2024-01-31 Thread Baoquan He
On 01/31/24 at 09:31am, Nikolay Borisov wrote: > > > On 30.01.24 г. 15:43 ч., Paolo Bonzini wrote: > > On 1/24/24 13:55, Kirill A. Shutemov wrote: > > > The patchset adds bits and pieces to get kexec (and crashkernel) work on > > > TDX guest. > > > > > > The last patch implements CPU offlining

Re: [PATCHv6 00/16] x86/tdx: Add kexec support

2024-01-30 Thread Nikolay Borisov
On 30.01.24 г. 15:43 ч., Paolo Bonzini wrote: On 1/24/24 13:55, Kirill A. Shutemov wrote: The patchset adds bits and pieces to get kexec (and crashkernel) work on TDX guest. The last patch implements CPU offlining according to the approved ACPI spec change poposal[1]. It unlocks kexec with

Re: [PATCHv6 00/16] x86/tdx: Add kexec support

2024-01-30 Thread Kirill A. Shutemov
On Tue, Jan 30, 2024 at 03:59:34PM +0100, Paolo Bonzini wrote: > On Tue, Jan 30, 2024 at 3:34 PM Kirill A. Shutemov > wrote: > > > > On Tue, Jan 30, 2024 at 02:43:15PM +0100, Paolo Bonzini wrote: > > > On 1/24/24 13:55, Kirill A. Shutemov wrote: > > > > The patchset adds bits and pieces to get

Re: [PATCHv6 00/16] x86/tdx: Add kexec support

2024-01-30 Thread Paolo Bonzini
On Tue, Jan 30, 2024 at 3:34 PM Kirill A. Shutemov wrote: > > On Tue, Jan 30, 2024 at 02:43:15PM +0100, Paolo Bonzini wrote: > > On 1/24/24 13:55, Kirill A. Shutemov wrote: > > > The patchset adds bits and pieces to get kexec (and crashkernel) work on > > > TDX guest. > > > > > > The last patch

Re: [PATCHv6 00/16] x86/tdx: Add kexec support

2024-01-30 Thread Kirill A. Shutemov
On Tue, Jan 30, 2024 at 02:43:15PM +0100, Paolo Bonzini wrote: > On 1/24/24 13:55, Kirill A. Shutemov wrote: > > The patchset adds bits and pieces to get kexec (and crashkernel) work on > > TDX guest. > > > > The last patch implements CPU offlining according to the approved ACPI > > spec change

RE: [PATCHv6 00/16] x86/tdx: Add kexec support

2024-01-30 Thread Huang, Kai
> Hi Kirill, > > I have a very basic question: is there a reason why this series does not > revert > commit cb8eb06d50fc, "x86/virt/tdx: Disable TDX host support when kexec is > enabled"? > Hi Paolo, (Sorry I am replying using Outlook) This series is for TDX guest, but not TDX host. For TDX

Re: [PATCHv6 00/16] x86/tdx: Add kexec support

2024-01-30 Thread Paolo Bonzini
On 1/24/24 13:55, Kirill A. Shutemov wrote: The patchset adds bits and pieces to get kexec (and crashkernel) work on TDX guest. The last patch implements CPU offlining according to the approved ACPI spec change poposal[1]. It unlocks kexec with all CPUs visible in the target kernel. It requires