Re: [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2024-01-27 Thread Kirill A. Shutemov
On Fri, Jan 26, 2024 at 12:03:14PM -0800, Kuppuswamy Sathyanarayanan wrote: > > + /* Don't wait longer than a second. */ > > + timeout = USEC_PER_SEC; > > + while (READ_ONCE(acpi_mp_wake_mailbox->command) && --timeout) > > + udelay(1); > > + > > + if (!timeout) > Nit: IMO, since

Re: [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2024-01-27 Thread kirill.shute...@linux.intel.com
On Fri, Jan 26, 2024 at 02:21:30PM +, Huang, Kai wrote: > > +static int __init acpi_mp_setup_reset(u64 reset_vector) > > +{ > > + pgd_t *pgd; > > + struct x86_mapping_info info = { > > + .alloc_pgt_page = alloc_pgt_page, > > + .free_pgt_page = free_pgt_page, > > +

Re: [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2024-01-26 Thread Kuppuswamy Sathyanarayanan
On 1/24/24 4:55 AM, Kirill A. Shutemov wrote: > MADT Multiprocessor Wakeup structure version 1 brings support of CPU > offlining: BIOS provides a reset vector where the CPU has to jump to > for offlining itself. The new TEST mailbox command can be used to test > whether the CPU offlined itself

Re: [PATCHv6 16/16] x86/acpi: Add support for CPU offlining for ACPI MADT wakeup method

2024-01-26 Thread Huang, Kai
On Wed, 2024-01-24 at 14:55 +0200, Kirill A. Shutemov wrote: > MADT Multiprocessor Wakeup structure version 1 brings support of CPU > offlining: BIOS provides a reset vector where the CPU has to jump to > for offlining itself. The new TEST mailbox command can be used to test > whether the CPU