Re: [PATCHv9 05/17] x86/kexec: Keep CR4.MCE set during kexec for TDX guest

2024-04-04 Thread Kirill A. Shutemov
On Thu, Apr 04, 2024 at 10:40:34AM +1300, Huang, Kai wrote: > > > On 3/04/2024 4:42 am, Kirill A. Shutemov wrote: > > On Fri, Mar 29, 2024 at 06:48:21PM +0200, Kirill A. Shutemov wrote: > > > On Fri, Mar 29, 2024 at 11:21:32PM +0800, Xiaoyao Li wrote: > > > > On 3/25/2024 6:38 PM, Kirill A.

Re: [PATCHv9 05/17] x86/kexec: Keep CR4.MCE set during kexec for TDX guest

2024-04-03 Thread Huang, Kai
On 3/04/2024 4:42 am, Kirill A. Shutemov wrote: On Fri, Mar 29, 2024 at 06:48:21PM +0200, Kirill A. Shutemov wrote: On Fri, Mar 29, 2024 at 11:21:32PM +0800, Xiaoyao Li wrote: On 3/25/2024 6:38 PM, Kirill A. Shutemov wrote: TDX guests are not allowed to clear CR4.MCE. Attempt to clear it

Re: [PATCHv9 05/17] x86/kexec: Keep CR4.MCE set during kexec for TDX guest

2024-04-02 Thread Kirill A. Shutemov
On Fri, Mar 29, 2024 at 06:48:21PM +0200, Kirill A. Shutemov wrote: > On Fri, Mar 29, 2024 at 11:21:32PM +0800, Xiaoyao Li wrote: > > On 3/25/2024 6:38 PM, Kirill A. Shutemov wrote: > > > TDX guests are not allowed to clear CR4.MCE. Attempt to clear it leads > > > to #VE. > > > > Will we consider

Re: [PATCHv9 05/17] x86/kexec: Keep CR4.MCE set during kexec for TDX guest

2024-03-29 Thread Kirill A. Shutemov
On Fri, Mar 29, 2024 at 11:21:32PM +0800, Xiaoyao Li wrote: > On 3/25/2024 6:38 PM, Kirill A. Shutemov wrote: > > TDX guests are not allowed to clear CR4.MCE. Attempt to clear it leads > > to #VE. > > Will we consider making it more safe and compatible for future to guard > against

Re: [PATCHv9 05/17] x86/kexec: Keep CR4.MCE set during kexec for TDX guest

2024-03-29 Thread Xiaoyao Li
On 3/25/2024 6:38 PM, Kirill A. Shutemov wrote: TDX guests are not allowed to clear CR4.MCE. Attempt to clear it leads to #VE. Will we consider making it more safe and compatible for future to guard against X86_FEATURE_MCE as well? If in the future, MCE becomes configurable for TD guest,