Re: [PATCH v3 3/3] close_dump_bitmap: simplify logic

2016-09-20 Thread Martin Wilck
Kumagai-san, On Tue, 2016-09-20 at 09:43 +, Atsushi Kumagai wrote: >  > This version looks good, so could you add your Signed-off-by ? OK, I'll resend the whole v3 series. Martin ___ kexec mailing list kexec@lists.infradead.org

RE: [PATCH v3 3/3] close_dump_bitmap: simplify logic

2016-09-20 Thread Atsushi Kumagai
Hello Martin, >The boolean expression replicates the logic of open_dump_bitmap(). >It's simpler and less error-prone to simply check if fd_bitmap is >valid. > >(I forgot to apply the very change that Petr had asked for in V2 of >this patch. I'm very sorry. Please apply V3). This version looks