Re: blk->id read race: was: [PATCH v2 2/3] printk: add lockless buffer

2020-06-10 Thread John Ogness
On 2020-06-10, Petr Mladek wrote: --- /dev/null +++ b/kernel/printk/printk_ringbuffer.c +/* + * Given a data ring (text or dict), put the associated descriptor of each + * data block from @lpos_begin until @lpos_end into the reusable state. + * + * If there is

Re: redundant check in make_data_reusable(): was [PATCH v2 2/3] printk: add lockless buffer

2020-06-10 Thread John Ogness
On 2020-06-10, Petr Mladek wrote: >> +static bool data_make_reusable(struct printk_ringbuffer *rb, >> + struct prb_data_ring *data_ring, >> + unsigned long lpos_begin, >> + unsigned long lpos_end, >> +

Re: [PATCH v2] kexec: Do not verify the signature without the lockdown or mandatory signature

2020-06-10 Thread lijiang
I just noticed that I forgot to add Eric Biederman in cc list, so sorry for this. Thanks. Lianbo 在 2020年06月02日 12:59, Lianbo Jiang 写道: > Signature verification is an important security feature, to protect > system from being attacked with a kernel of unknown origin. Kexec > rebooting is a way

Re: redundant check in make_data_reusable(): was [PATCH v2 2/3] printk: add lockless buffer

2020-06-10 Thread John Ogness
On 2020-06-10, Petr Mladek wrote: >> >> --- /dev/null >> >> +++ b/kernel/printk/printk_ringbuffer.c >> >> +/* >> >> + * Given a data ring (text or dict), put the associated descriptor of >> >> each >> >> + * data block from @lpos_begin until @lpos_end into the reusable state. >> >> + * + *

Re: data_ring head_lpos and tail_lpos synchronization: was [PATCH v2 2/3] printk: add lockless buffer

2020-06-10 Thread John Ogness
On 2020-06-09, Petr Mladek wrote: >> --- /dev/null >> +++ b/kernel/printk/printk_ringbuffer.c >> +/* >> + * Advance the data ring tail to at least @lpos. This function puts >> + * descriptors into the reusable state if the tail is pushed beyond >> + * their associated data block. >> + */ >>

Re: blk->id read race: was: [PATCH v2 2/3] printk: add lockless buffer

2020-06-10 Thread Petr Mladek
On Tue 2020-06-09 16:18:35, John Ogness wrote: > On 2020-06-09, Petr Mladek wrote: > >> --- /dev/null > >> +++ b/kernel/printk/printk_ringbuffer.c > >> +/* > >> + * Given a data ring (text or dict), put the associated descriptor of each > >> + * data block from @lpos_begin until @lpos_end into

Re: redundant check in make_data_reusable(): was [PATCH v2 2/3] printk: add lockless buffer

2020-06-10 Thread Petr Mladek
On Tue 2020-06-09 16:48:30, John Ogness wrote: > On 2020-06-09, Petr Mladek wrote: > >> --- /dev/null > >> +++ b/kernel/printk/printk_ringbuffer.c > >> +/* > >> + * Given a data ring (text or dict), put the associated descriptor of each > >> + * data block from @lpos_begin until @lpos_end into

Re: [PATCH][RFC] kdump: append kernel build-id string to VMCOREINFO

2020-06-10 Thread Vijay Balakrishna
Thanks Baoquan. See inline. On 6/9/2020 7:20 PM, Baoquan He wrote: On 06/04/20 at 05:01pm, Vijay Balakrishna wrote: Make kernel GNU build-id available in VMCOREINFO. Having build-id in VMCOREINFO facilitates presenting appropriate kernel namelist image with debug information file to kernel

[PATCH v2][RFC] kdump: append kernel build-id string to VMCOREINFO

2020-06-10 Thread Vijay Balakrishna
Make kernel GNU build-id available in VMCOREINFO. Having build-id in VMCOREINFO facilitates presenting appropriate kernel namelist image with debug information file to kernel crash dump analysis tools. Currently VMCOREINFO lacks uniquely identifiable key for crash analysis automation. Regarding

RE: Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-06-10 Thread Bharat Gooty
Hello Bhupesh, V6 patch set on Linux 5.7, did not help. I have applied makedump file http://lists.infradead.org/pipermail/kexec/2019-November/023963.html changes also (makedump-1.6.6). Tried to apply it on makedumpfile 1.6.7. Patch set_2 failed. Would like to know, if you have V5 patch set for

RE: Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-06-10 Thread Bharat Gooty
Sorry, error message was not posted. Following is the error message crash: cannot determine VA_BITS_ACTUAL -Original Message- From: Bharat Gooty [mailto:bharat.go...@broadcom.com] Sent: Wednesday, June 10, 2020 10:18 PM To: Scott Branden; 'Bhupesh Sharma'; 'Amit Kachhap' Cc: 'Mark