Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code

2021-12-29 Thread Leizhen (ThunderTown)
On 2021/12/30 0:51, Borislav Petkov wrote: > On Wed, Dec 29, 2021 at 11:04:21PM +0800, Leizhen (ThunderTown) wrote: >> Chen Zhou and I tried to share the code because of a suggestion. After so >> many >> attempts, it doesn't seem to fit to make generic. Or maybe I haven't figured >> out a good

Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code

2021-12-29 Thread Borislav Petkov
On Wed, Dec 29, 2021 at 11:04:21PM +0800, Leizhen (ThunderTown) wrote: > Chen Zhou and I tried to share the code because of a suggestion. After so many > attempts, it doesn't seem to fit to make generic. Or maybe I haven't figured > out a good solution yet. Well, you learned a very important

Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code

2021-12-29 Thread Leizhen (ThunderTown)
On 2021/12/29 18:46, Dave Young wrote: > On 12/29/21 at 11:03am, Borislav Petkov wrote: >> On Wed, Dec 29, 2021 at 03:27:48PM +0800, Dave Young wrote: >>> So I think you can unify the parse_crashkernel* in x86 first with just >>> one function. And leave the further improvements to later work.

Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code

2021-12-29 Thread Leizhen (ThunderTown)
On 2021/12/29 18:38, Dave Young wrote: > On 12/29/21 at 11:11am, Borislav Petkov wrote: >> On Wed, Dec 29, 2021 at 03:45:12PM +0800, Dave Young wrote: >>> BTW, I would suggest to wait for reviewers to response (eg. one week at >>> least, or more due to the holidays) before updating another

Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code

2021-12-29 Thread Leizhen (ThunderTown)
On 2021/12/29 15:27, Dave Young wrote: > On 12/29/21 at 10:27am, Leizhen (ThunderTown) wrote: >> >> >> On 2021/12/29 0:13, Borislav Petkov wrote: >>> On Tue, Dec 28, 2021 at 09:26:01PM +0800, Zhen Lei wrote: Use parse_crashkernel_high_low() to bring the parsing of "crashkernel=X,high"

Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code

2021-12-29 Thread Borislav Petkov
On Wed, Dec 29, 2021 at 06:38:43PM +0800, Dave Young wrote: > I appreciate you further explanation below to describe the situation. > I do not see how can I tell this to *all* submitters, You don't have to - that was hypothetical. :-) I'm typing this on a public mailing list with the hope that

Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code

2021-12-29 Thread Dave Young
On 12/29/21 at 11:03am, Borislav Petkov wrote: > On Wed, Dec 29, 2021 at 03:27:48PM +0800, Dave Young wrote: > > So I think you can unify the parse_crashkernel* in x86 first with just > > one function. And leave the further improvements to later work. But > > let's see how Boris think about this.

Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code

2021-12-29 Thread Dave Young
On 12/29/21 at 11:11am, Borislav Petkov wrote: > On Wed, Dec 29, 2021 at 03:45:12PM +0800, Dave Young wrote: > > BTW, I would suggest to wait for reviewers to response (eg. one week at > > least, or more due to the holidays) before updating another version > > > > Do not worry to miss the 5.17.

Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code

2021-12-29 Thread Borislav Petkov
On Wed, Dec 29, 2021 at 03:45:12PM +0800, Dave Young wrote: > BTW, I would suggest to wait for reviewers to response (eg. one week at > least, or more due to the holidays) before updating another version > > Do not worry to miss the 5.17. I would say take it easy if it will > miss then let's

Re: [PATCH v19 02/13] x86/setup: Use parse_crashkernel_high_low() to simplify code

2021-12-29 Thread Borislav Petkov
On Wed, Dec 29, 2021 at 03:27:48PM +0800, Dave Young wrote: > So I think you can unify the parse_crashkernel* in x86 first with just > one function. And leave the further improvements to later work. But > let's see how Boris think about this. Well, I think this all unnecessary work. Why? If the