Re: [PATCH makedumpfile] handle mem_section as either a pointer or an array

2018-05-14 Thread Thadeu Lima de Souza Cascardo
CTION_MAP_MASK" patch modify the same line. > > I would like to reply about both patches by the end of the next week. > > > > > > Thanks > > Tachibana > > > > > > > -Original Message- > > > From: kexec [mailto:kexec-boun...@lists.

[PATCH makedumpfile] handle mem_section as either a pointer or an array

2018-02-19 Thread Thadeu Lima de Souza Cascardo
of kernels and succeeded in producing a compressed dump that could be analyzed with crash 7.2.1. Signed-off-by: Thadeu Lima de Souza Cascardo <casca...@canonical.com> --- makedumpfile.c | 153 +++-- makedumpfile.h | 1 + 2 files change

Re: [PATCH net-next v2 2/2] cxgb4: collect hardware dump in second kernel

2018-03-24 Thread Thadeu Lima de Souza Cascardo
On Sat, Mar 24, 2018 at 04:26:34PM +0530, Rahul Lakkireddy wrote: > Register callback to collect hardware/firmware dumps in second kernel > before hardware/firmware is initialized. The dumps for each device > will be available under /sys/kernel/crashdd/cxgb4/ directory in second > kernel. > >

Re: [PATCH makedumpfile] handle mem_section as either a pointer or an array

2018-03-02 Thread Thadeu Lima de Souza Cascardo
Any comments or reviews on the patch below? Thanks. Cascardo. On Mon, Feb 19, 2018 at 05:04:59PM -0300, Thadeu Lima de Souza Cascardo wrote: > Some kernel versions that have been recently shipped have mem_section point to > a pointer to the array, instead of pointing directly to the

[PATCH] lockdown: allow kexec_file of unsigned images when not under lockdown

2018-11-01 Thread Thadeu Lima de Souza Cascardo
, as it is, it will still prevent an unsigned image to be loaded with kexec -s when the system is not under lockdown, while still allowing kexec to work. At the same time, with lockdown, kexec_file_load would still work when CONFIG_KEXEC_VERIFY_SIG is disabled. Signed-off-by: Thadeu Lima de Souza

[PATCH v2] lockdown: allow kexec_file of unsigned images when not under lockdown

2018-11-05 Thread Thadeu Lima de Souza Cascardo
, as it is, it will still prevent an unsigned image to be loaded with kexec -s when the system is not under lockdown, while still allowing kexec to work. At the same time, with lockdown, kexec_file_load would still work when CONFIG_KEXEC_VERIFY_SIG is disabled. Signed-off-by: Thadeu Lima de Souza

[PATCH] crashdump-ppc64: crashkernel-base and crashkernel-size are big-endian

2020-03-04 Thread Thadeu Lima de Souza Cascardo
536870912 Signed-off-by: Thadeu Lima de Souza Cascardo --- kexec/arch/ppc64/crashdump-ppc64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kexec/arch/ppc64/crashdump-ppc64.c b/kexec/arch/ppc64/crashdump-ppc64.c index 50e3853dbdcf..b2787d5135bd 100644 --- a/kexec/arch

Re: [PATCH] makedumpfile: cope with not-present mem section

2020-01-27 Thread Thadeu Lima de Souza Cascardo
On Mon, Jan 27, 2020 at 02:04:54PM -0300, Thadeu Lima de Souza Cascardo wrote: > Sorry for taking too long to respond, as I was on vacation. > > The kernels that had commit 83e3c48729d9, but not commit a0b1280368d1, are > not supported anymore. In a way that it's even hard for me

Re: [PATCH] makedumpfile: cope with not-present mem section

2020-01-27 Thread Thadeu Lima de Souza Cascardo
; I tried to understand the code, but I don't know why it need call > > > validate_mem_section() twice and compare the returned value. > > I think it could be if/else, no need to call twice. > > It looks to me that commit 14876c45aef ("[PATCH makedumpfile] handle > mem_section > a

Re: [PATCH] makedumpfile: cope with not-present mem section

2020-02-04 Thread Thadeu Lima de Souza Cascardo
vanilla 4.4 kernel would not be dumpable with your patch. Thanks. Cascardo. > On 01/29/2020 03:33 AM, Thadeu Lima de Souza Cascardo wrote: > > On Tue, Jan 28, 2020 at 05:03:12PM +, HAGIO KAZUHITO(萩尾 一仁) wrote: > >> Hi Cascardo, > >> > >>> -Original Messa

Re: [PATCH] makedumpfile: cope with not-present mem section

2020-01-28 Thread Thadeu Lima de Souza Cascardo
On Tue, Jan 28, 2020 at 05:03:12PM +, HAGIO KAZUHITO(萩尾 一仁) wrote: > Hi Cascardo, > > > -Original Message- > > On Mon, Jan 27, 2020 at 02:04:54PM -0300, Thadeu Lima de Souza Cascardo > > wrote: > > > Sorry for taking too long to respond, as I was on

Re: [PATCH] makedumpfile: cope with not-present mem section

2020-02-19 Thread Thadeu Lima de Souza Cascardo
On Wed, Feb 19, 2020 at 08:12:41PM +, HAGIO KAZUHITO(萩尾 一仁) wrote: > Hi Cascardo, > > Do you have any solution or detailed information on the failure on your > kernel? > or could you try this branch? It has an additional patch on top of Pingfan's > one to avoid the false positive failure

Re: [PATCH] makedumpfile: cope with not-present mem section

2020-02-20 Thread Thadeu Lima de Souza Cascardo
Fix validate_mem_section()"). With that one, all of Ubuntu's 4.4 kernel and Debian's 3.16 and 4.9 kernels dump correctly. Without that one, all fail, and I suppose it would be easily reproducible. So, in effect, we are looking for any entry with the present bit, and then checking it is vali