Re: [PATCH v25 01/10] drivers/base: refactor cpu.c to use .is_visible()

2023-08-03 Thread Greg KH
On Thu, Aug 03, 2023 at 01:20:28PM -0500, Eric DeVolder wrote: > > > On 7/21/23 11:32, Eric DeVolder wrote: > > > > > > On 7/3/23 11:53, Eric DeVolder wrote: > > > > > > > > > On 7/3/23 08:05, Greg KH wrote: > > >

Re: [PATCH v25 06/10] crash: memory and CPU hotplug sysfs attributes

2023-07-03 Thread Greg KH
On Thu, Jun 29, 2023 at 03:21:15PM -0400, Eric DeVolder wrote: > +What:/sys/devices/system/cpu/crash_hotplug > +Date:Jun 2023 It's not "Jun" anymore :( > +Contact: Linux kernel mailing list Why are you not going to maintain this? Why is this up to me?

Re: [PATCH v25 01/10] drivers/base: refactor cpu.c to use .is_visible()

2023-07-03 Thread Greg KH
On Thu, Jun 29, 2023 at 03:21:10PM -0400, Eric DeVolder wrote: > - the function body of the callback functions are now wrapped with >IS_ENABLED(); as the callback function must exist now that the >attribute is always compiled-in (though not necessarily visible). Why do you need to do

Re: [PATCH v23 4/8] crash: memory and CPU hotplug sysfs attributes

2023-06-13 Thread Greg KH
On Mon, Jun 12, 2023 at 05:07:08PM -0400, Eric DeVolder wrote: > Introduce the crash_hotplug attribute for memory and CPUs for > use by userspace. These attributes directly facilitate the udev > rule for managing userspace re-loading of the crash kernel upon > hot un/plug changes. > > For

Re: [PATCH v4.9] kexec_file: drop weak attribute from arch_kexec_apply_relocations[_add]

2022-06-30 Thread Greg KH
On Tue, Jun 28, 2022 at 09:12:48PM +0530, Naveen N. Rao wrote: > commit 3e35142ef99fe6b4fe5d834ad43ee13cca10a2dc upstream. > > Since commit d1bcae833b32f1 ("ELF: Don't generate unused section > symbols") [1], binutils (v2.36+) started dropping section symbols that > it thought were unused. This

Re: kexec does not work for kernel version with patch level >= 256

2021-03-31 Thread Greg KH
On Wed, Mar 31, 2021 at 04:03:24PM +0800, Baoquan He wrote: > Add Sasha and Greg to the CC list. > > On 03/31/21 at 11:48am, Baoquan He wrote: > > On 03/31/21 at 11:04am, Patrick Sung wrote: > > > On Wed, Mar 31, 2021 at 10:47 AM Baoquan He wrote: > > > > > > > > On 03/24/21 at 12:28pm, Patrick

Re: [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

2021-01-11 Thread Greg KH
On Fri, Jan 08, 2021 at 11:32:48AM +0800, Baoquan He wrote: > On 09/30/20 at 12:23pm, Alexander Egorenkov wrote: > > The offset of the field 'init_uts_ns.name' has changed > > since commit 9a56493f6942 ("uts: Use generic ns_common::count"). > > This patch is merged into 5.11-rc1, but we met the

Re: [PATCH v3 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

2021-01-08 Thread Greg KH
On Fri, Jan 08, 2021 at 11:32:48AM +0800, Baoquan He wrote: > On 09/30/20 at 12:23pm, Alexander Egorenkov wrote: > > The offset of the field 'init_uts_ns.name' has changed > > since commit 9a56493f6942 ("uts: Use generic ns_common::count"). > > This patch is merged into 5.11-rc1, but we met the

Re: [PATCH 2/3] security: add symbol namespace for reading file data

2020-05-13 Thread Greg KH
On Wed, May 13, 2020 at 04:16:22PM +, Luis Chamberlain wrote: > On Wed, May 13, 2020 at 10:40:31AM -0500, Eric W. Biederman wrote: > > Luis Chamberlain writes: > > > > > Certain symbols are not meant to be used by everybody, the security > > > helpers for reading files directly is one such

Re: [PATCH 2/3] security: add symbol namespace for reading file data

2020-05-13 Thread Greg KH
On Wed, May 13, 2020 at 10:40:31AM -0500, Eric W. Biederman wrote: > Luis Chamberlain writes: > > > Certain symbols are not meant to be used by everybody, the security > > helpers for reading files directly is one such case. Use a symbol > > namespace for them. > > > > This will prevent abuse of

Re: [PATCH 3/3] fs: move kernel_read*() calls to its own symbol namespace

2020-05-13 Thread Greg KH
On Wed, May 13, 2020 at 03:21:08PM +, Luis Chamberlain wrote: > Signed-off-by: Luis Chamberlain I can't take patches without any changelog text at all, sorry. greg k-h ___ kexec mailing list kexec@lists.infradead.org

Re: [RFC PATCH v2 1/3] meminfo_extra: introduce meminfo extra

2020-03-29 Thread Greg KH
On Sun, Mar 29, 2020 at 10:19:07AM +0300, Leon Romanovsky wrote: > On Tue, Mar 24, 2020 at 09:53:16PM +0900, Jaewon Kim wrote: > > > > > > On 2020년 03월 24일 20:46, Greg KH wrote: > > > On Tue, Mar 24, 2020 at 08:37:38PM +0900, Jaewon Kim wrote: > > >> &g

Re: [RFC PATCH v2 1/3] meminfo_extra: introduce meminfo extra

2020-03-24 Thread Greg KH
On Tue, Mar 24, 2020 at 09:53:16PM +0900, Jaewon Kim wrote: > > > On 2020년 03월 24일 20:46, Greg KH wrote: > > On Tue, Mar 24, 2020 at 08:37:38PM +0900, Jaewon Kim wrote: > >> > >> On 2020년 03월 24일 19:11, Greg KH wrote: > >>> On Tue, Mar 2

Re: [RFC PATCH v2 1/3] meminfo_extra: introduce meminfo extra

2020-03-24 Thread Greg KH
On Tue, Mar 24, 2020 at 08:37:38PM +0900, Jaewon Kim wrote: > > > On 2020년 03월 24일 19:11, Greg KH wrote: > > On Tue, Mar 24, 2020 at 06:11:17PM +0900, Jaewon Kim wrote: > >> On 2020년 03월 23일 18:53, Greg KH wrote: > >>>> +int register_meminfo_extra(at

Re: [RFC PATCH v2 1/3] meminfo_extra: introduce meminfo extra

2020-03-24 Thread Greg KH
On Tue, Mar 24, 2020 at 06:11:17PM +0900, Jaewon Kim wrote: > On 2020년 03월 23일 18:53, Greg KH wrote: > >> +int register_meminfo_extra(atomic_long_t *val, int shift, const char > >> *name) > >> +{ > >> + struct meminfo_extra *meminfo, *memtemp;

Re: [RFC PATCH v2 1/3] meminfo_extra: introduce meminfo extra

2020-03-23 Thread Greg KH
On Mon, Mar 23, 2020 at 05:05:01PM +0900, Jaewon Kim wrote: > Provide APIs to drivers so that they can show its memory usage on > /proc/meminfo_extra. > > int register_meminfo_extra(atomic_long_t *val, int shift, > const char *name); > int

Re: [RFC PATCH v2 3/3] android: ion: include system heap size in meminfo extra

2020-03-23 Thread Greg KH
On Mon, Mar 23, 2020 at 05:05:03PM +0900, Jaewon Kim wrote: > In Android system ion system heap size is huge like hundreds of MB. To > know overal system memory usage, include ion system heap size in > proc/meminfo_extra. > > To include heap size, use register_meminfo_extra introduced in previous

Re: [PATCH net-next v4 1/3] vmcore: add API to collect hardware dump in second kernel

2018-04-19 Thread Greg KH
On Tue, Apr 17, 2018 at 01:14:17PM +0530, Rahul Lakkireddy wrote: > +config PROC_VMCORE_DEVICE_DUMP > + bool "Device Hardware/Firmware Log Collection" > + depends on PROC_VMCORE > + default y Only things that require the machine to keep working should be 'default y', please remove

Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot

2013-11-27 Thread Greg KH
On Wed, Nov 27, 2013 at 12:18:28PM -0700, Khalid Aziz wrote: +/* flag to track if kexec reboot is in progress */ +extern unsigned long kexec_in_progress; unsigned long for a flag? ___ kexec mailing list kexec@lists.infradead.org

Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot

2013-11-27 Thread Greg KH
On Wed, Nov 27, 2013 at 12:59:40PM -0700, Khalid Aziz wrote: On 11/27/2013 12:38 PM, ebied...@xmission.com wrote: Khalid Aziz khalid.a...@oracle.com writes: Add a flag to tell the PCI subsystem that kernel is shutting down in prepapration to kexec a kernel. Add code in PCI subsystem to use

Re: [PATCH] PCI: Clear Bus Master bit only on kexec reboot

2013-11-27 Thread Greg KH
On Wed, Nov 27, 2013 at 09:53:09PM +, Matthew Garrett wrote: On Wed, Nov 27, 2013 at 01:22:27PM -0800, Greg KH wrote: Then fix the drivers please. It's not as if you don't have access to the source for them all... Define fix. It's clearly wrong to disable busmastering at shutdown

Re: [PATCH 0/6] kexec: A new system call to allow in kernel loading

2013-11-22 Thread Greg KH
On Fri, Nov 22, 2013 at 09:19:46AM -0500, Vivek Goyal wrote: On Fri, Nov 22, 2013 at 05:34:03AM -0800, Eric W. Biederman wrote: [..] Why ELF case is so interesting. I have not use kexec to boot ELF images in years and have not seen others using it too. In fact bzImage seems to be the

Re: [PATCH 1/6] kexec: Export vmcoreinfo note size properly

2013-11-21 Thread Greg KH
On Wed, Nov 20, 2013 at 12:50:46PM -0500, Vivek Goyal wrote: Right now we seem to be exporting the max data size contained inside vmcoreinfo note. But this does not include the size of meta data around vmcore info data. Like name of the note and starting and ending elf_note. I think user

Re: [PATCH 4/6] kexec: A new system call, kexec_file_load, for in kernel kexec

2013-11-21 Thread Greg KH
On Wed, Nov 20, 2013 at 12:50:49PM -0500, Vivek Goyal wrote: This patch implements the in kernel kexec functionality. It implements a new system call kexec_file_load. I think parameter list of this system call will change as I have not done the kernel image signature handling yet. I have been

Re: [patch 5/9 v3] efi: export more efi table variable to sysfs

2013-11-21 Thread Greg KH
On Thu, Nov 21, 2013 at 02:17:09PM +0800, dyo...@redhat.com wrote: Export fw_vendor, runtime and config tables physical addresses to /sys/firmware/efi/systab becaue kexec kernel will need them. From EFI spec these 3 variables will be updated to virtual address after entering virtual mode.

Re: [PATCH 0/6] kexec: A new system call to allow in kernel loading

2013-11-21 Thread Greg KH
On Wed, Nov 20, 2013 at 12:50:45PM -0500, Vivek Goyal wrote: Current proposed secureboot implementation disables kexec/kdump because it can allow unsigned kernel to run on a secureboot platform. Intial idea was to sign /sbin/kexec binary and let that binary do the kernel signature

Re: [PATCH 5/6] kexec-bzImage: Support for loading bzImage using 64bit entry

2013-11-21 Thread Greg KH
On Wed, Nov 20, 2013 at 12:50:50PM -0500, Vivek Goyal wrote: This is loader specific code which can load bzImage and set it up for 64bit entry. This does not take care of 32bit entry or real mode entry yet. Signed-off-by: Vivek Goyal vgo...@redhat.com ---

Re: [patch 9/9 v3] x86: export x86 boot_params to sysfs

2013-11-21 Thread Greg KH
On Thu, Nov 21, 2013 at 02:17:13PM +0800, dyo...@redhat.com wrote: kexec-tools use boot_params for getting the 1st kernel hardware_subarch, the kexec kernel efi runtime support also need read the old efi_info from boot_params. Currently it exists in debugfs which is not a good place for such

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-12 Thread Greg KH
On Tue, Nov 12, 2013 at 04:08:54PM +0800, Dave Young wrote: On 11/11/13 at 11:58pm, Greg KH wrote: kexec-tools can have a fallback to debugfs if we really need it, but making people mount debugfs to have some essential piece of functionality scares the heck out of me. I agree

Re: [patch 4/7 v2] export more efi table variable to sysfs

2013-11-12 Thread Greg KH
On Tue, Nov 12, 2013 at 04:24:01PM +0800, Dave Young wrote: On 11/12/13 at 04:19pm, Dave Young wrote: On 11/11/13 at 04:40pm, Greg KH wrote: On Tue, Nov 05, 2013 at 04:20:11PM +0800, dyo...@redhat.com wrote: Export fw_vendor, runtime and config tables physical addresses to /sys

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-12 Thread Greg KH
On Tue, Nov 12, 2013 at 01:37:25AM -0800, H. Peter Anvin wrote: On 11/12/2013 12:30 AM, Greg KH wrote: And these binary data blobs are a standard somewhere, and will not change per kernel version change? If so, that structure is fine with me. Correct. The structure

Re: [patch 4/7 v2] export more efi table variable to sysfs

2013-11-11 Thread Greg KH
On Tue, Nov 05, 2013 at 04:20:11PM +0800, dyo...@redhat.com wrote: Export fw_vendor, runtime and config tables physical addresses to /sys/firmware/efi/systab becaue kexec kernel will need them. sysfs files are one-value-per-file. Please don't abuse this and add more values to this single

Re: [patch 1/3 v2] Add function get_bootparam

2013-11-11 Thread Greg KH
On Mon, Nov 11, 2013 at 07:20:17PM -0800, H. Peter Anvin wrote: On 11/11/2013 05:27 PM, Toshi Kani wrote: On Tue, 2013-11-05 at 16:29 +0800, dyo...@redhat.com wrote: Not only setup_subarch will get data from debugfs file boot_params/data, later code for adding efi_info will also need do

Re: [PATCH 00/16] [RFC PATCH] Signed kexec support

2013-09-12 Thread Greg KH
On Thu, Sep 12, 2013 at 07:43:36AM -0400, Vivek Goyal wrote: On Wed, Sep 11, 2013 at 08:40:23PM -0700, Greg KH wrote: On Tue, Sep 10, 2013 at 05:44:15PM -0400, Vivek Goyal wrote: Hi, Matthew has been posting patches to lock down kernel either due to secureboot requirements

Re: [PATCH 00/16] [RFC PATCH] Signed kexec support

2013-09-11 Thread Greg KH
On Tue, Sep 10, 2013 at 05:44:15PM -0400, Vivek Goyal wrote: Hi, Matthew has been posting patches to lock down kernel either due to secureboot requirements or because of signed modules with signing enforced. In kernel lock down mode, kexec will be disabled and that means kdump will not work

Re: [PATCH 14/16] kexec: Export sysfs attributes for secureboot and secure modules to user space

2013-09-10 Thread Greg KH
On Tue, Sep 10, 2013 at 05:44:29PM -0400, Vivek Goyal wrote: User space kexec-tools need to know whether to verify signature of kernel image being loaded. This patch exports two knobs to user space. One is for knowing if secureboot is enabled, this knob will be set to 1 if secure boot is

Re: [PATCH v4 2/3] KVM-INTEL: Add new module vmcsinfo-intel to fill VMCSINFO

2012-07-04 Thread Greg KH
On Wed, Jul 04, 2012 at 06:05:19PM +0800, Yanfei Zhang wrote: +int vmcs_sysfs_add(struct device *dev) +{ + return sysfs_create_group(dev-kobj, vmcs_attr_group); +} + +void vmcs_sysfs_remove(struct device *dev) +{ + sysfs_remove_group(dev-kobj, vmcs_attr_group); +} Why are these

Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs

2012-06-28 Thread Greg KH
On Thu, Jun 28, 2012 at 05:54:30PM +0800, Yanfei Zhang wrote: 于 2012年06月28日 03:22, Greg KH 写道: On Wed, Jun 27, 2012 at 04:54:54PM +0800, Yanfei Zhang wrote: This patch export offsets of fields via /sys/devices/cpu/vmcs/. Individual offsets are contained in subfiles named by the filed's

Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs

2012-06-28 Thread Greg KH
On Thu, Jun 28, 2012 at 04:37:38AM -0700, Greg KH wrote: On Thu, Jun 28, 2012 at 05:54:30PM +0800, Yanfei Zhang wrote: 于 2012年06月28日 03:22, Greg KH 写道: On Wed, Jun 27, 2012 at 04:54:54PM +0800, Yanfei Zhang wrote: This patch export offsets of fields via /sys/devices/cpu/vmcs

Re: [PATCH v3 4/5] Sysfs: Export VMCSINFO via sysfs

2012-06-27 Thread Greg KH
On Wed, Jun 27, 2012 at 04:54:54PM +0800, Yanfei Zhang wrote: This patch export offsets of fields via /sys/devices/cpu/vmcs/. Individual offsets are contained in subfiles named by the filed's encoding, e.g.: /sys/devices/cpu/vmcs/0800 Signed-off-by: zhangyanfei zhangyan...@cn.fujitsu.com

Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs

2012-04-16 Thread Greg KH
On Tue, Apr 17, 2012 at 09:52:42AM +0800, zhangyanfei wrote: 于 2012年04月13日 07:00, Greg KH 写道: On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: This patch creates sysfs file to export where VMCSINFO is allocated, as below: $ cat /sys/kernel/vmcsinfo 1cb88a0

Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs

2012-04-12 Thread Greg KH
On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: This patch creates sysfs file to export where VMCSINFO is allocated, as below: $ cat /sys/kernel/vmcsinfo 1cb88a0 2000 number on the left-hand side is the physical address of VMCSINFO, while the one on the

[072/474] mm, x86: Saving vmcore with non-lazy freeing of vmas

2011-03-17 Thread Greg KH
2.6.33-longterm review patch. If anyone has any objections, please let us know. -- Content-Length: 2026 Lines: 68 From: Cliff Wickman c...@sgi.com commit 3ee48b6af49cf534ca2f481ecc484b156a41451d upstream. During the reading of /proc/vmcore the kernel is doing

Re: [RFC][PATCH] Add a sysctl option controlling kexec when MCE occurred

2010-12-22 Thread Greg KH
On Wed, Dec 22, 2010 at 06:35:40PM -0500, Seiji Aguchi wrote: --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -81,6 +81,9 @@ #include linux/nmi.h #endif +#ifdef CONFIG_X86_MCE +#include asm/mce.h +#endif Please don't put ifdefs in .c files, you do that a lot for this option. Just make

[08/45] mm, x86: Saving vmcore with non-lazy freeing of vmas

2010-11-19 Thread Greg KH
2.6.32-stable review patch. If anyone has any objections, please let us know. -- From: Cliff Wickman c...@sgi.com commit 3ee48b6af49cf534ca2f481ecc484b156a41451d upstream. During the reading of /proc/vmcore the kernel is doing ioremap()/iounmap() repeatedly. And the buildup of

[16/66] mm, x86: Saving vmcore with non-lazy freeing of vmas

2010-11-19 Thread Greg KH
2.6.36-stable review patch. If anyone has any objections, please let us know. -- From: Cliff Wickman c...@sgi.com commit 3ee48b6af49cf534ca2f481ecc484b156a41451d upstream. During the reading of /proc/vmcore the kernel is doing ioremap()/iounmap() repeatedly. And the buildup of

Re: x86: Add /sys/firmware/memmap

2008-06-27 Thread Greg KH
that interface for E820 on x86. Change compared to previous commit: 1. Comments from Greg KH. 2. Documentation. The patch has been tested on i386 and x86_64 with success. Looks good, want me to take this through my tree (due to the firmware core change)? If so, can you get an ack on the x86

Re: [PATCH 1/2] Add /sys/firmware/memmap

2008-06-27 Thread Greg KH
On Fri, Jun 27, 2008 at 01:12:54PM +0200, Bernhard Walle wrote: This patch adds /sys/firmware/memmap interface that represents the BIOS (or Firmware) provided memory map. The tree looks like: /sys/firmware/memmap/0/start (hex number) end (hex number)

Re: [PATCH 1/2] Add /sys/firmware/memmap

2008-06-26 Thread Greg KH
On Thu, Jun 26, 2008 at 10:19:01PM +0200, Bernhard Walle wrote: This patch adds /sys/firmware/memmap interface that represents the BIOS (or Firmware) provided memory map. The tree looks like: /sys/firmware/memmap/0/start (hex number) end (hex number)

Re: [PATCH 1/2] add tunable_notifier function ,take2

2008-04-11 Thread Greg KH
On Fri, Apr 11, 2008 at 04:53:52PM +0900, Takenori Nagano wrote: This patch adds new notifier function tunable_notifier_chain. Its base is atomic_notifier_chain. You are adding sysfs files, not debugfs files, please change your announcement text. Also, as you are adding new sysfs files, we