RE: [PATCH] makedumpfile tries to output infinite ETA

2018-06-14 Thread Masaki Tachibana
Hi Michael, Thank you very much for your comment. Certainly makedumpfile can print an invalid value at the progress bar. Well, this problem was also argued in other mails, and Petr Tesarik posted the patch. I'll merge the v2 patch into v1.6.4. We are debugging V1.6.4 now and planning to release

RE: [PATCH 2/2] Check PG_swapbacked for swap cache pages

2018-05-20 Thread Masaki Tachibana
Hi Petr, Thank you for the patch. I will merge it into V1.6.4. Thanks Tachibana > -Original Message- > From: kexec [mailto:kexec-boun...@lists.infradead.org] On Behalf Of Masaki > Tachibana > Sent: Monday, May 07, 2018 4:42 PM > To: Petr Tesarik <ptesa...@suse.

RE: [PATCH v2] makedumpfile: Use integer arithmetics for the progress bar

2018-05-18 Thread Masaki Tachibana
Hi Petr and Lianbo, Sorry for the late reply. I will merge the patch into V1.6.4. Thanks Tachibana > -Original Message- > From: Petr Tesarik [mailto:ptesa...@suse.cz] > Sent: Tuesday, April 10, 2018 8:39 PM > To: lijiang > Cc: Tachibana Masaki()

RE: [PATCH makedumpfile] handle mem_section as either a pointer or an array

2018-05-14 Thread Masaki Tachibana
-Original Message- > From: kexec [mailto:kexec-boun...@lists.infradead.org] On Behalf Of Masaki > Tachibana > Sent: Monday, March 05, 2018 6:16 PM > To: Thadeu Lima de Souza Cascardo <casca...@canonical.com> > Cc: Hayashi Masahiko() <mas-haya...@tg.jp.nec.com>; kexec@li

RE: [PATCH 2/2] Check PG_swapbacked for swap cache pages

2018-05-07 Thread Masaki Tachibana
Hi Petr, Sorry for the late reply. Your patches look good. Thank you. Thanks Tachibana > -Original Message- > From: kexec [mailto:kexec-boun...@lists.infradead.org] On Behalf Of Masaki > Tachibana > Sent: Wednesday, April 25, 2018 1:12 PM > To: Petr Tesarik <ptes

RE: [PATCH 4/4] arch/x86_64: Add 5-level paging support

2018-05-07 Thread Masaki Tachibana
Hi Baoquan, Sorry for the late reply. The patch looks good. Thanks Tachibana > -Original Message- > From: kexec [mailto:kexec-boun...@lists.infradead.org] On Behalf Of Baoquan He > Sent: Friday, March 02, 2018 2:49 PM > To: kexec@lists.infradead.org > Cc: douly.f...@cn.fujitsu.com;

RE: [PATCH 2/4] Makedumpfile: Add pgtable_l5_enabled to number_table

2018-05-07 Thread Masaki Tachibana
Hi Baoquan, Sorry for the late reply. > + ENUM_NUMBER_INIT(N_ONLINE, "pgtable_l5_enabled"); Is this ENUM_NUMBER_INIT(pgtable_l5_enabled, "pgtable_l5_enabled"); ? > + WRITE_NUMBER("N_ONLINE", pgtable_l5_enabled); Is this WRITE_NUMBER("pgtable_l5_enabled", pgtable_l5_enabled); ? If so,

RE: [PATCH 3/4] Makedumpfile: Add a new function check_5level_paging()

2018-05-07 Thread Masaki Tachibana
Hi Baoquan, Sorry for the late reply. > +check_5level_paging(void) > +{ > + if (NUMBER(pgtable_l5_enabled) != 0) Is this if (NUMBER(pgtable_l5_enabled) != NOT_FOUND_NUMBER && NUMBER(pgtable_l5_enabled) != 0) ? If so, I will correct this. > + return TRUE; Thanks Tachibana >

RE: [PATCH 1/4] arch/x86_64: Cleanup the address translation of the 4-level page tables

2018-05-07 Thread Masaki Tachibana
Hi Baoquan, Sorry for the late reply. > +#define PUD_SIZE (1UL << PUD_SHIFT) > +#define PUD_MASK (~(PUD_SHIFT - 1)) Is this (~(PUD_SIZE - 1)) ? If so, I will correct this. > +#define PMD_SIZE (1UL << PMD_SHIFT) > +#define PMD_MASK

RE: [PATCH 2/2] Check PG_swapbacked for swap cache pages

2018-04-24 Thread Masaki Tachibana
Hi Petr, Sorry. I can't take time enough for makedumpfile recently. I would like to reply by May 11th. Please wait some weeks. Thanks Tachibana > -Original Message- > From: Petr Tesarik [mailto:ptesa...@suse.cz] > Sent: Tuesday, April 24, 2018 7:43 PM > To: Tachibana Masaki()

RE: makedumpfile filters out wrong pages

2018-04-13 Thread Masaki Tachibana
Hi Petr, Thank you for important information. I will wait for the patch. Thanks Tachibana > -Original Message- > From: Petr Tesarik [mailto:ptesa...@suse.cz] > Sent: Thursday, April 12, 2018 6:02 PM > To: Tachibana Masaki(橘 正樹) ; Nakayama Takuya(中山 > 卓也)

RE: [PATCH 0/4] Makedumpfile: Add 5-level paging support

2018-04-11 Thread Masaki Tachibana
Hi Baoquan, Sorry for the late reply. I'll merge the patches into V1.6.4. However, I need time to acknowledge formally. Please wait some weeks. Thanks Tachibana > -Original Message- > From: Baoquan He [mailto:b...@redhat.com] > Sent: Thursday, April 12, 2018 11:45 AM > To: Tachibana

RE: makedumpfile fails on 4.4 longterm kernel with kaslr enabled

2018-03-29 Thread Masaki Tachibana
Hi Fukui-san Thank you for the detailed report. And sorry that makedumpfile doesn't have the enough compatibility. Unfortunately, my idea is only to disable KASLR. If no one propose another way, please consider it. Thanks Tachibana > -Original Message- > From: kexec

RE: [PATCH makedumpfile] Fix array index out of bound exception

2018-03-23 Thread Masaki Tachibana
Hi Lianbo, Sorry for the late reply. Thank you for the patch. I will merge it into V1.6.4. Thanks Tachibana > -Original Message- > From: kexec [mailto:kexec-boun...@lists.infradead.org] On Behalf Of Masaki > Tachibana > Sent: Wednesday, March 07, 2018 2:07 PM > To

RE: [makedumpfile PATCH v2] Always use bigger SECTION_MAP_MASK

2018-03-20 Thread Masaki Tachibana
Hi Petr, Thank you for your V2 patch. I will merge it into V1.6.4. Thanks Tachibana > -Original Message- > From: kexec [mailto:kexec-boun...@lists.infradead.org] On Behalf Of Petr > Tesarik > Sent: Tuesday, March 20, 2018 6:31 PM > To: Tachibana Masaki() >

RE: [makedumpfile PATCH] Always use bigger SECTION_MAP_MASK

2018-03-14 Thread Masaki Tachibana
.infradead.org>; Hayashi Masahiko() > <mas-haya...@tg.jp.nec.com> > Subject: Re: [makedumpfile PATCH] Always use bigger SECTION_MAP_MASK > > Hi, > > On Tue, 13 Mar 2018 09:18:54 + > Masaki Tachibana <mas-tachib...@vf.jp.nec.com> wrote: > &g

RE: [makedumpfile PATCH] Always use bigger SECTION_MAP_MASK

2018-03-13 Thread Masaki Tachibana
Hi Petr, Sorry for the late reply. > -Original Message- > From: kexec [mailto:kexec-boun...@lists.infradead.org] On Behalf Of Petr > Tesarik > Sent: Friday, February 02, 2018 5:19 PM > To: kexec mailing list ; Tachibana Masaki() >

RE: [PATCH] makedumpfile: fix for hugepages filtering

2018-03-08 Thread Masaki Tachibana
Hi Hari, Thank you for your patch. It looks good. I will merge it into V1.6.4. Thanks Tachibana P.S. Sorry. I am prohibited from sending a mail to free mail address such as gmail.com. > -Original Message- > From: kexec [mailto:kexec-boun...@lists.infradead.org] On Behalf Of Hari >

RE: [PATCH v2 1/3] Add a new helper file 'tools.c' that provides some useful APIs

2018-03-07 Thread Masaki Tachibana
gt; Subject: Re: [PATCH v2 1/3] Add a new helper file 'tools.c' that provides > some useful APIs > > Hello Masaki, > > On Tue, Mar 6, 2018 at 3:33 PM, Masaki Tachibana > <mas-tachib...@vf.jp.nec.com> wrote: > > Hi bhupesh, > > > > Thank you for your

RE: [PATCH makedumpfile] Fix array index out of bound exception

2018-03-06 Thread Masaki Tachibana
Hi Lianbo, Thank you for your patch. I understand the purpose of the patch. I'll reply formally in 10 days or so. Thanks Tachibana > -Original Message- > From: lijiang [mailto:liji...@redhat.com] > Sent: Wednesday, March 07, 2018 10:25 AM > To: kexec@lists.infradead.org > Cc: Tachibana

RE: [PATCH v2 1/3] Add a new helper file 'tools.c' that provides some useful APIs

2018-03-06 Thread Masaki Tachibana
Hi bhupesh, Thank you for your V2 patchset. When you have introduced tools.c from crash utility, you have deleted a part of htol()'s error handling that is unnecessary for makedumpfile as follows; htol_error: - switch (flags & (FAULT_ON_ERROR|RETURN_ON_ERROR))

RE: [PATCH makedumpfile] handle mem_section as either a pointer or an array

2018-03-05 Thread Masaki Tachibana
Hi Thadeu, Sorry for the late reply. "handle mem_section as either a pointer or an array" patch and "Always use bigger SECTION_MAP_MASK" patch modify the same line. I would like to reply about both patches by the end of the next week. Thanks Tachibana > -Original Message- > From:

RE: [PATCH] makedumpfile/arm64: Add '--mem-usage' support

2018-03-04 Thread Masaki Tachibana
p.nec.com> > Cc: kexec@lists.infradead.org; Hayashi Masahiko() <mas-haya...@tg.jp.nec.com> > Subject: Re: [PATCH] makedumpfile/arm64: Add '--mem-usage' support > > Hello Masaki, > > Thanks for your reply. > > On Fri, Mar 2, 2018 at 11:01 AM, Masaki Tachibana >

RE: [PATCH] makedumpfile/arm64: Add '--mem-usage' support

2018-03-01 Thread Masaki Tachibana
Sent: Thursday, February 22, 2018 3:58 AM > To: Tachibana Masaki() <mas-tachib...@vf.jp.nec.com> > Cc: kexec@lists.infradead.org; Bhupesh Sharma <bhsha...@redhat.com>; Hayashi > Masahiko() > <mas-haya...@tg.jp.nec.com> > Subject: Re: [PATCH] makedumpfile/arm64: Ad

RE: [PATCH] makedumpfile/arm64: Add '--mem-usage' support

2018-02-20 Thread Masaki Tachibana
yes User process pages > > FREE 1450569 yes Free pages > > KERN_DATA 14243 no Dumpable kernel data > > > > page size: 65536 > > Total pages on system: 1562310 > > T

RE: [PATCH] makedumpfile: Fix a bug when multi-threads feature meets enospace

2018-02-15 Thread Masaki Tachibana
Hi, Atsushi Kumagai has retired, so other members will maintain makedumpfile. Wenjian Sorry for the late reply. Your patch looks good to me. I'll merge it into V1.6.4. Thanks tachibana > -Original Message- > From: kexec [mailto:kexec-boun...@lists.infradead.org] On Behalf Of Zhou >