Re: [PATCH] Handle additional e820 memmap type strings

[Baoquan He]

On 05/22/17 at 01:43pm, Simon Horman wrote:
> On Fri, May 19, 2017 at 05:15:38PM +0800, Baoquan He wrote:
> > On 05/17/17 at 07:51am, Eric DeVolder wrote:
> > > > > diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c
> > > > > index 4d84f00..1ee214a 100644
> > > > > --- a/kexec/firmware_memmap.c
> > > > > +++ b/kexec/firmware_memmap.c
> > > > > @@ -164,6 +164,10 @@ static int parse_memmap_entry(const char *entry, 
> > > > > struct memory_range *range)
> > > > >   range->type = RANGE_RESERVED;
> > > > >   else if (strcmp(type, "reserved") == 0)
> > > > >   range->type = RANGE_RESERVED;
> > > > > + else if (strcmp(type, "Reserved") == 0)
> > > > > + range->type = RANGE_RESERVED;
> > > > > + else if (strcmp(type, "Unknown E820 type") == 0)
> > > > > + range->type = RANGE_RESERVED;
> > > > 
> > > > Should we change the "reserved" one to "Reserved" so that we don't need
> > > > to have "reserved" and "Reserved" at the same time?
> > > 
> > > The lower-case "reserved" has been in use by the kernel for quite a long
> > > while, and upper-case "Reserved" has been recently introduced. I think
> > > removing lower-case "reserved" would result in problems with existing,
> > > older, kernels that still would be using "reserved".
> > 
> > Thanks. Then it looks good to me. Ack.
> > 
> > Simon might pick several patches one time every several days. Please
> > wait.
> 
> Yes, I try to pick up new patches within a few working days.
> I have applied this one.

Thanks, Simon!


___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] Handle additional e820 memmap type strings

[Baoquan He]

On 05/17/17 at 07:51am, Eric DeVolder wrote:
> > > diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c
> > > index 4d84f00..1ee214a 100644
> > > --- a/kexec/firmware_memmap.c
> > > +++ b/kexec/firmware_memmap.c
> > > @@ -164,6 +164,10 @@ static int parse_memmap_entry(const char *entry, 
> > > struct memory_range *range)
> > >   range->type = RANGE_RESERVED;
> > >   else if (strcmp(type, "reserved") == 0)
> > >   range->type = RANGE_RESERVED;
> > > + else if (strcmp(type, "Reserved") == 0)
> > > + range->type = RANGE_RESERVED;
> > > + else if (strcmp(type, "Unknown E820 type") == 0)
> > > + range->type = RANGE_RESERVED;
> > 
> > Should we change the "reserved" one to "Reserved" so that we don't need
> > to have "reserved" and "Reserved" at the same time?
> 
> The lower-case "reserved" has been in use by the kernel for quite a long
> while, and upper-case "Reserved" has been recently introduced. I think
> removing lower-case "reserved" would result in problems with existing,
> older, kernels that still would be using "reserved".

Thanks. Then it looks good to me. Ack.

Simon might pick several patches one time every several days. Please
wait.
> 
> > 
> > >   else if (strcmp(type, "ACPI Non-volatile Storage") == 0)
> > >   range->type = RANGE_ACPI_NVS;
> > >   else if (strcmp(type, "Uncached RAM") == 0)
> > > -- 
> > > 2.7.4
> > > 
> > > 
> > > ___
> > > kexec mailing list
> > > kexec@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/kexec
> 
> ___
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] Handle additional e820 memmap type strings

[Eric DeVolder]

On 05/15/2017 09:07 AM, Baoquan He wrote:

On 05/10/17 at 11:03am, Eric DeVolder wrote:

Keep pace with changes to linux arch/x86/kernel/e820.c to
function e820_type_to_string(). With this change, the following
messages from kexec are eliminated (and allows kexec to load):

  Unknown type (Reserved) while parsing /sys/firmware/memmap/8/type.
  Please report this as bug. Using RANGE_RESERVED now.

  Unknown type (Unknown E820 type) while parsing /sys/firmware/memmap/4/type.
  Please report this as bug. Using RANGE_RESERVED now.

Signed-off-by: Eric DeVolder 
---
  kexec/firmware_memmap.c | 4 
  1 file changed, 4 insertions(+)

diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c
index 4d84f00..1ee214a 100644
--- a/kexec/firmware_memmap.c
+++ b/kexec/firmware_memmap.c
@@ -164,6 +164,10 @@ static int parse_memmap_entry(const char *entry, struct 
memory_range *range)
range->type = RANGE_RESERVED;
else if (strcmp(type, "reserved") == 0)
range->type = RANGE_RESERVED;
+   else if (strcmp(type, "Reserved") == 0)
+   range->type = RANGE_RESERVED;
+   else if (strcmp(type, "Unknown E820 type") == 0)
+   range->type = RANGE_RESERVED;


Should we change the "reserved" one to "Reserved" so that we don't need
to have "reserved" and "Reserved" at the same time?


The lower-case "reserved" has been in use by the kernel for quite a long 
while, and upper-case "Reserved" has been recently introduced. I think 
removing lower-case "reserved" would result in problems with existing, 
older, kernels that still would be using "reserved".





else if (strcmp(type, "ACPI Non-volatile Storage") == 0)
range->type = RANGE_ACPI_NVS;
else if (strcmp(type, "Uncached RAM") == 0)
--
2.7.4


___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec


___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] Handle additional e820 memmap type strings

[Baoquan He]

On 05/10/17 at 11:03am, Eric DeVolder wrote:
> Keep pace with changes to linux arch/x86/kernel/e820.c to
> function e820_type_to_string(). With this change, the following
> messages from kexec are eliminated (and allows kexec to load):
> 
>  Unknown type (Reserved) while parsing /sys/firmware/memmap/8/type.
>  Please report this as bug. Using RANGE_RESERVED now.
> 
>  Unknown type (Unknown E820 type) while parsing /sys/firmware/memmap/4/type.
>  Please report this as bug. Using RANGE_RESERVED now.
> 
> Signed-off-by: Eric DeVolder 
> ---
>  kexec/firmware_memmap.c | 4 
>  1 file changed, 4 insertions(+)
> 
> diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c
> index 4d84f00..1ee214a 100644
> --- a/kexec/firmware_memmap.c
> +++ b/kexec/firmware_memmap.c
> @@ -164,6 +164,10 @@ static int parse_memmap_entry(const char *entry, struct 
> memory_range *range)
>   range->type = RANGE_RESERVED;
>   else if (strcmp(type, "reserved") == 0)
>   range->type = RANGE_RESERVED;
> + else if (strcmp(type, "Reserved") == 0)
> + range->type = RANGE_RESERVED;
> + else if (strcmp(type, "Unknown E820 type") == 0)
> + range->type = RANGE_RESERVED;

Should we change the "reserved" one to "Reserved" so that we don't need
to have "reserved" and "Reserved" at the same time?

>   else if (strcmp(type, "ACPI Non-volatile Storage") == 0)
>   range->type = RANGE_ACPI_NVS;
>   else if (strcmp(type, "Uncached RAM") == 0)
> -- 
> 2.7.4
> 
> 
> ___
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

Re: [PATCH] Handle additional e820 memmap type strings

[Eric DeVolder]

There have been no reviews of this patch yet; just bubbling it up to the 
top to gain some attention.


Regards,
eric

On 05/10/2017 11:03 AM, Eric DeVolder wrote:

Keep pace with changes to linux arch/x86/kernel/e820.c to
function e820_type_to_string(). With this change, the following
messages from kexec are eliminated (and allows kexec to load):

 Unknown type (Reserved) while parsing /sys/firmware/memmap/8/type.
 Please report this as bug. Using RANGE_RESERVED now.

 Unknown type (Unknown E820 type) while parsing /sys/firmware/memmap/4/type.
 Please report this as bug. Using RANGE_RESERVED now.

Signed-off-by: Eric DeVolder 
---
 kexec/firmware_memmap.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c
index 4d84f00..1ee214a 100644
--- a/kexec/firmware_memmap.c
+++ b/kexec/firmware_memmap.c
@@ -164,6 +164,10 @@ static int parse_memmap_entry(const char *entry, struct 
memory_range *range)
range->type = RANGE_RESERVED;
else if (strcmp(type, "reserved") == 0)
range->type = RANGE_RESERVED;
+   else if (strcmp(type, "Reserved") == 0)
+   range->type = RANGE_RESERVED;
+   else if (strcmp(type, "Unknown E820 type") == 0)
+   range->type = RANGE_RESERVED;
else if (strcmp(type, "ACPI Non-volatile Storage") == 0)
range->type = RANGE_ACPI_NVS;
else if (strcmp(type, "Uncached RAM") == 0)



___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

[PATCH] Handle additional e820 memmap type strings

[Eric DeVolder]

Keep pace with changes to linux arch/x86/kernel/e820.c to
function e820_type_to_string(). With this change, the following
messages from kexec are eliminated (and allows kexec to load):

 Unknown type (Reserved) while parsing /sys/firmware/memmap/8/type.
 Please report this as bug. Using RANGE_RESERVED now.

 Unknown type (Unknown E820 type) while parsing /sys/firmware/memmap/4/type.
 Please report this as bug. Using RANGE_RESERVED now.

Signed-off-by: Eric DeVolder 
---
 kexec/firmware_memmap.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/kexec/firmware_memmap.c b/kexec/firmware_memmap.c
index 4d84f00..1ee214a 100644
--- a/kexec/firmware_memmap.c
+++ b/kexec/firmware_memmap.c
@@ -164,6 +164,10 @@ static int parse_memmap_entry(const char *entry, struct 
memory_range *range)
range->type = RANGE_RESERVED;
else if (strcmp(type, "reserved") == 0)
range->type = RANGE_RESERVED;
+   else if (strcmp(type, "Reserved") == 0)
+   range->type = RANGE_RESERVED;
+   else if (strcmp(type, "Unknown E820 type") == 0)
+   range->type = RANGE_RESERVED;
else if (strcmp(type, "ACPI Non-volatile Storage") == 0)
range->type = RANGE_ACPI_NVS;
else if (strcmp(type, "Uncached RAM") == 0)
-- 
2.7.4


___
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec