On 05/04/22 at 05:36am, lizhe wrote:
> When ck_cmdline is NULL. The last three lines of
> this function(get_last_crashkernel()) are equivalent to :
> if (!NULL)
> return NULL;
>
> return NULL;
> This is obviously a redundant check
Now the patch log correctly reflects
When ck_cmdline is NULL. The last three lines of
this function(get_last_crashkernel()) are equivalent to :
if (!NULL)
return NULL;
return NULL;
This is obviously a redundant check
Signed-off-by: lizhe
---
kernel/crash_core.c | 3 ---
1 file changed, 3
Hi lizhe,
On Mon, 2 May 2022 18:11:20 +0800 (CST)
lizhe wrote:
> HI Philipp Rudo.
>
>
> When ck_cmdline is NULL. The last three lines of this function are
> equivalent to :
> if ( ! NULL)
> return NULL;
> return NULL;
> This is obviously a
Hi lizhe,
On Mon, 25 Apr 2022 08:38:57 -0700
lizhe wrote:
> When ck_cmdline is NULL, the only caller of get_last_crashkernel()
> has already done non-NULL check(see __parse_crashkernel()),
> so it doesn't make any sense to make a check here
sorry, but I still don't like the description.
When ck_cmdline is NULL, the only caller of get_last_crashkernel()
has already done non-NULL check(see __parse_crashkernel()),
so it doesn't make any sense to make a check here
Signed-off-by: lizhe
---
kernel/crash_core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git
