Re: [PATCH RFC] kexec: Freeze processes before kexec

2022-11-17 Thread Joel Fernandes
On Thu, Nov 17, 2022 at 3:46 PM Philipp Rudo wrote: > On Wed, 16 Nov 2022 15:16:10 -0500 > Steven Rostedt wrote: > > > On Wed, 16 Nov 2022 19:56:24 + > > "Joel Fernandes (Google)" wrote: > > > > > --- a/kernel/kexec_core.c > > > +++ b/kernel/kexec_core.c > > > @@ -1175,6 +1175,12 @@ int

Re: [PATCH RFC] kexec: Freeze processes before kexec

2022-11-17 Thread Philipp Rudo
Hi Steve, On Wed, 16 Nov 2022 15:16:10 -0500 Steven Rostedt wrote: > On Wed, 16 Nov 2022 19:56:24 + > "Joel Fernandes (Google)" wrote: > > > --- a/kernel/kexec_core.c > > +++ b/kernel/kexec_core.c > > @@ -1175,6 +1175,12 @@ int kernel_kexec(void) > > } else > > #endif > > { > > +

Re: [PATCH RFC] kexec: Freeze processes before kexec

2022-11-16 Thread Joel Fernandes
Hey Steve, On Wed, Nov 16, 2022 at 8:15 PM Steven Rostedt wrote: > > On Wed, 16 Nov 2022 19:56:24 + > "Joel Fernandes (Google)" wrote: > > > --- a/kernel/kexec_core.c > > +++ b/kernel/kexec_core.c > > @@ -1175,6 +1175,12 @@ int kernel_kexec(void) > > } else > > #endif > > { > >

Re: [PATCH RFC] kexec: Freeze processes before kexec

2022-11-16 Thread Steven Rostedt
On Wed, 16 Nov 2022 19:56:24 + "Joel Fernandes (Google)" wrote: > --- a/kernel/kexec_core.c > +++ b/kernel/kexec_core.c > @@ -1175,6 +1175,12 @@ int kernel_kexec(void) > } else > #endif > { > + error = freeze_processes(); > + if (error) { > +

[PATCH RFC] kexec: Freeze processes before kexec

2022-11-16 Thread Joel Fernandes (Google)
During kexec, it is possible for userspace to race with device_shutdown() causing accesses to GPU after pm_runtime suspend has already happened. Fix by freezing userspace before device_shutdown(). Such freezing is already being done if kernel supports KEXEC_JUMP and kexec_image->preserve_context