[PATCH] makedumpfile: fix for hugepages filtering

2018-03-08 Thread Hari Bathini
Kernel commit 036e7aa49fb2 changed 'compound_dtor' & 'compound_order' types from 'unsigned short' to 'unsigned char'. Fix it here to ensure hugepages are filtered properly. Also, makedumpfile tool commit 484c6b18624 used 'int' type for 'dtor' argument in 'isHugetlb' function. While this works in

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

2018-03-08 Thread Dave Young
Hi Philipp, On 02/26/18 at 04:16pm, Philipp Rudo wrote: > > Hi everybody > > following the discussion with Dave and AKASHI, here are the common code > patches extracted from my recent patch set (Add kexec_file_load support to > s390) [1]. The patches were extracted to allow upstream integration

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

2018-03-08 Thread Dave Young
On 03/09/18 at 02:02pm, Dave Young wrote: > On 03/08/18 at 09:05am, Dave Young wrote: > > [Cc Andrew] > > > > On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: > > > This is a preparatory patch set for adding kexec_file support on arm64. > > > > > > It was originally included in a arm64 patch

Re: [PATCH 00/11] kexec_file: Clean up purgatory load

2018-03-08 Thread Dave Young
On 03/09/18 at 01:19pm, Dave Young wrote: > Hi Philipp, > On 02/26/18 at 04:16pm, Philipp Rudo wrote: > > > > Hi everybody > > > > following the discussion with Dave and AKASHI, here are the common code > > patches extracted from my recent patch set (Add kexec_file_load support to > > s390) [1].

[RESEND PATCH] makedumpfile: fix for hugepages filtering

2018-03-08 Thread Hari Bathini
Kernel commit 036e7aa49fb2 changed 'compound_dtor' & 'compound_order' types from 'unsigned short' to 'unsigned char'. Fix it here to ensure hugepages are filtered properly. Also, makedumpfile tool commit 484c6b18624 used 'int' type for 'dtor' argument in 'isHugetlb' function. While this works in

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

2018-03-08 Thread Dave Young
On 03/08/18 at 09:05am, Dave Young wrote: > [Cc Andrew] > > On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: > > This is a preparatory patch set for adding kexec_file support on arm64. > > > > It was originally included in a arm64 patch set[1], but Philipp is also > > working on their kexec_file

RE: [PATCH] makedumpfile: fix for hugepages filtering

2018-03-08 Thread Masaki Tachibana
Hi Hari, Thank you for your patch. It looks good. I will merge it into V1.6.4. Thanks Tachibana P.S. Sorry. I am prohibited from sending a mail to free mail address such as gmail.com. > -Original Message- > From: kexec [mailto:kexec-boun...@lists.infradead.org] On Behalf Of Hari >

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

2018-03-08 Thread AKASHI Takahiro
Dave, On Fri, Mar 09, 2018 at 02:44:12PM +0800, Dave Young wrote: > On 03/09/18 at 02:02pm, Dave Young wrote: > > On 03/08/18 at 09:05am, Dave Young wrote: > > > [Cc Andrew] > > > > > > On 03/06/18 at 07:22pm, AKASHI Takahiro wrote: > > > > This is a preparatory patch set for adding kexec_file

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

2018-03-08 Thread Dave Young
Hi AKASHI, On 03/09/18 at 04:18pm, AKASHI Takahiro wrote: > Dave, > > On Fri, Mar 09, 2018 at 02:44:12PM +0800, Dave Young wrote: > > On 03/09/18 at 02:02pm, Dave Young wrote: > > > On 03/08/18 at 09:05am, Dave Young wrote: > > > > [Cc Andrew] > > > > > > > > On 03/06/18 at 07:22pm, AKASHI

Re: [PATCH v2 0/7] kexec_file, x86, powerpc: refactoring for other architecutres

2018-03-08 Thread Dave Young
On 03/09/18 at 03:46pm, Dave Young wrote: > Hi AKASHI, > > On 03/09/18 at 04:18pm, AKASHI Takahiro wrote: > > Dave, > > > > On Fri, Mar 09, 2018 at 02:44:12PM +0800, Dave Young wrote: > > > On 03/09/18 at 02:02pm, Dave Young wrote: > > > > On 03/08/18 at 09:05am, Dave Young wrote: > > > > > [Cc

Re: [PATCH 07/11] kexec_file: Simplify kexec_purgatory_setup_sechdrs 1

2018-03-08 Thread kbuild test robot
Hi Philipp, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc3 next-20180228] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 09/11] kexec_file: Remove mis-use of sh_offset field

2018-03-08 Thread Dave Young
On 02/26/18 at 04:16pm, Philipp Rudo wrote: > The current code uses the sh_offset field in purgatory_info->sechdrs to > store a pointer to the current load address of the section. Depending > whether the section will be loaded or not this is either a pointer into > purgatory_info->purgatory_buf or

Re: [PATCH 08/11] kexec_file: Simplify kexec_purgatory_setup_sechdrs 2

2018-03-08 Thread Dave Young
Hi, On 02/26/18 at 04:16pm, Philipp Rudo wrote: > The main loop currently uses quite a lot of variables to update the section > headers. Some of them are unnecessary. So clean them up a little. > It looks better to use some patch subject eg below: "Remove unnecessary variables in