Re: [Kgdb-bugreport] [PATCH printk v2 26/38] kdb: use srcu console list iterator

2022-10-25 Thread Petr Mladek via Kgdb-bugreport
On Mon 2022-10-24 17:47:25, Doug Anderson wrote: > Hi, > > On Wed, Oct 19, 2022 at 7:56 AM John Ogness wrote: > > > > Guarantee safe iteration of the console list by using SRCU. > > > > Signed-off-by: John Ogness > > --- > > kernel/debug/kdb/kdb_io.c | 5 - > > 1 file changed, 4 insertions(

Re: [Kgdb-bugreport] [PATCH printk v2 12/38] tty: serial: kgdboc: use console_is_enabled()

2022-10-25 Thread John Ogness
On 2022-10-24, Doug Anderson wrote: > It actually only holds console_list_lock() even at the end of the > series. Still, it seems weird that we're declaring the `data_race` on > CON_ENABLED but not CON_BOOT ? You are correct that it is not a data race (because of the console_list_lock being held.

Re: [Kgdb-bugreport] [PATCH printk v2 22/38] serial: kgdboc: document console_lock usage

2022-10-25 Thread Petr Mladek via Kgdb-bugreport
On Wed 2022-10-19 17:01:44, John Ogness wrote: > kgdboc_earlycon_init() uses the console_lock to ensure that no consoles > are unregistered until the kgdboc_earlycon is setup. This is necessary > because the trapping of the exit() callback assumes that the exit() > callback is not called before the