Re: [Kgdb-bugreport] [PATCH printk v1 01/18] kdb: do not assume write() callback available

2023-03-07 Thread Doug Anderson
Hi, On Thu, Mar 2, 2023 at 11:57 AM John Ogness wrote: > > It is allowed for consoles to provide no write() callback. For > example ttynull does this. > > Check if a write() callback is available before using it. > > Signed-off-by: John Ogness > --- > kernel/debug/kdb/kdb_io.c | 2 ++ > 1 file

[Kgdb-bugreport] [PATCH 2/3] serial: uart_poll_init() should power on the UART

2023-03-07 Thread Douglas Anderson
On Qualcomm devices which use the "geni" serial driver, kdb/kgdb won't be very happy if you use it but the resources of the port haven't been powered on. Today kdb/kgdb rely on someone else powering the port on. This could be the normal kernel console or an agetty running. Let's fix this to explici

[Kgdb-bugreport] [PATCH 3/3] tty: serial: qcom-geni-serial: Add a poll_init() function

2023-03-07 Thread Douglas Anderson
On sc7180 Chromebooks, I did the following: * Didn't enable earlycon in the kernel command line. * Didn't enable serial console in the kernel command line. * Didn't enable an agetty or any other client of "/dev/ttyMSM0". * Added "kgdboc=ttyMSM0" to the kernel command line. After I did that, I trie

[Kgdb-bugreport] [PATCH 1/3] tty: serial: qcom-geni-serial: Fix kdb/kgdb after port shutdown (again)

2023-03-07 Thread Douglas Anderson
Commit d8aca2f96813 ("tty: serial: qcom-geni-serial: stop operations in progress at shutdown") was basically a straight revert of the commit it claims to fix without any explanation of why the problems talked about in the original patch were no longer relevant. Indeed, commit d8aca2f96813 ("tty: se

Re: [Kgdb-bugreport] [PATCH printk v1 01/18] kdb: do not assume write() callback available

2023-03-07 Thread Petr Mladek via Kgdb-bugreport
On Thu 2023-03-02 21:02:01, John Ogness wrote: > It is allowed for consoles to provide no write() callback. For > example ttynull does this. > > Check if a write() callback is available before using it. > > Signed-off-by: John Ogness Reviewed-by: Petr Mladek Best Regards, Petr _