Re: [Kgdb-bugreport] [PATCH v4 10/17] watchdog/hardlockup: Move perf hardlockup watchdog petting to watchdog.c

On Thu 2023-05-04 15:13:42, Douglas Anderson wrote: > In preparation for the buddy hardlockup detector, which wants the same > petting logic as the current perf hardlockup detector, move the code > to watchdog.c. While doing this, rename the global variable to match > others nearby. The arch_touch_

Re: [Kgdb-bugreport] [PATCH v8 08/10] kgdb: Provide a stub kgdb_nmicallback() if !CONFIG_KGDB

Hi, On Wed, Apr 19, 2023 at 3:57 PM Douglas Anderson wrote: > > To save architectures from needing to wrap the call in #ifdefs, add a > stub no-op version of kgdb_nmicallback(), which returns 1 if it didn't > handle anything. > > Signed-off-by: Douglas Anderson > --- > > Changes in v8: > - "Prov

Re: [Kgdb-bugreport] [PATCH v4 09/17] watchdog/hardlockup: Add a "cpu" param to watchdog_hardlockup_check()

On Thu 2023-05-04 15:13:41, Douglas Anderson wrote: > In preparation for the buddy hardlockup detector where the CPU > checking for lockup might not be the currently running CPU, add a > "cpu" parameter to watchdog_hardlockup_check(). > > --- a/kernel/watchdog.c > +++ b/kernel/watchdog.c > @@ -92,

Re: [Kgdb-bugreport] [PATCH v4 08/17] watchdog/hardlockup: Style changes to watchdog_hardlockup_check() / ..._is_lockedup()

On Fri 2023-05-05 09:38:14, Doug Anderson wrote: > Hi, > > On Thu, May 4, 2023 at 8:02 PM Nicholas Piggin wrote: > > > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > > These are tiny style changes: > > > - Add a blank line before a "return". > > > - Renames two globals to use t

Re: [Kgdb-bugreport] [PATCH v4 07/17] watchdog/hardlockup: Move perf hardlockup checking/panic to common watchdog.c

On Fri 2023-05-05 09:37:50, Doug Anderson wrote: > Hi, > > On Thu, May 4, 2023 at 7:58 PM Nicholas Piggin wrote: > > > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > > The perf hardlockup detector works by looking at interrupt counts and > > > seeing if they change from run to

Re: [Kgdb-bugreport] [PATCH v4 06/17] watchdog/perf: Rename watchdog_hld.c to watchdog_perf.c

On Thu 2023-05-04 15:13:38, Douglas Anderson wrote: > The code currently in "watchdog_hld.c" is for detecting hardlockups > using perf, as evidenced by the line in the Makefile that only > compiles this file if CONFIG_HARDLOCKUP_DETECTOR_PERF is > defined. Rename the file to prepare for the buddy h

Re: [Kgdb-bugreport] [PATCH v4 05/17] watchdog/hardlockup: Rename touch_nmi_watchdog() to touch_hardlockup_watchdog()

On Fri 2023-05-05 09:37:35, Doug Anderson wrote: > Hi, > > On Thu, May 4, 2023 at 7:51 PM Nicholas Piggin wrote: > > > > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > > In preparation for the buddy hardlockup detector, rename > > > touch_nmi_watchdog() to touch_hardlockup_watchd

Re: [Kgdb-bugreport] [PATCH v4 01/17] watchdog/perf: Define dummy watchdog_update_hrtimer_threshold() on correct config

On Fri 2023-05-05 12:43:49, Nicholas Piggin wrote: > On Fri May 5, 2023 at 8:13 AM AEST, Douglas Anderson wrote: > > The real watchdog_update_hrtimer_threshold() is defined in > > watchdog_hardlockup_perf.c. That file is included if > > In kernel/watchdog_hld.c. With this fixed path: Reviewed-by