Re: [Kgdb-bugreport] [PATCH v3 4/4] kdb: Switch kdb_msg_write() to use safer polling I/O

2020-05-28 Thread Sumit Garg
On Wed, 27 May 2020 at 19:01, Daniel Thompson wrote: > > On Wed, May 27, 2020 at 11:55:59AM +0530, Sumit Garg wrote: > > In kgdb NMI context, calling console handlers isn't safe due to locks > > used in those handlers which could lead to a deadlock. Although, using > > oops_in_progress increases

Re: [Kgdb-bugreport] [PATCH v3 3/4] kdb: Make kdb_printf robust to run in NMI context

2020-05-28 Thread Sumit Garg
On Wed, 27 May 2020 at 19:56, Daniel Thompson wrote: > > On Wed, May 27, 2020 at 11:55:58AM +0530, Sumit Garg wrote: > > While rounding up CPUs via NMIs, its possible that a rounded up CPU > > This problem does not just impact NMI roundup (breakpoints, I guess here via breakpoints you meant if

Re: [Kgdb-bugreport] [PATCH v3] kdb: Remove the misfeature 'KDBFLAGS'

2020-05-28 Thread Daniel Thompson
On Thu, May 21, 2020 at 03:21:25PM +0800, Wei Li wrote: > Currently, 'KDBFLAGS' is an internal variable of kdb, it is combined > by 'KDBDEBUG' and state flags. It will be shown only when 'KDBDEBUG' > is set, and the user can define an environment variable named 'KDBFLAGS' > too. These are puzzling

Re: [Kgdb-bugreport] [PATCH v3 4/4] kdb: Switch kdb_msg_write() to use safer polling I/O

2020-05-28 Thread Daniel Thompson
On Thu, May 28, 2020 at 11:48:48AM +0530, Sumit Garg wrote: > On Wed, 27 May 2020 at 19:01, Daniel Thompson > wrote: > > > > On Wed, May 27, 2020 at 11:55:59AM +0530, Sumit Garg wrote: > > > In kgdb NMI context, calling console handlers isn't safe due to locks > > > used in those handlers which

Re: [Kgdb-bugreport] [PATCH v3 4/4] kdb: Switch kdb_msg_write() to use safer polling I/O

2020-05-28 Thread Sumit Garg
On Thu, 28 May 2020 at 20:27, Petr Mladek wrote: > > On Thu 2020-05-28 12:26:20, Daniel Thompson wrote: > > On Thu, May 28, 2020 at 11:48:48AM +0530, Sumit Garg wrote: > > > On Wed, 27 May 2020 at 19:01, Daniel Thompson > > > wrote: > > > > > > > > On Wed, May 27, 2020 at 11:55:59AM +0530, Sumit