Re: [Kgdb-bugreport] [PATCH -next] kdb: Use newer api for tasklist scanning

2020-09-07 Thread Daniel Thompson
On Mon, Aug 31, 2020 at 12:34:35PM -0700, Davidlohr Bueso wrote: > This kills the custom kdb_do_each_thread/kdb_while_each_thread > calls used in kdb to iterate through all tasks. It is obsolete > and racy to use tsk->thread_group, although in this particular No objections to the change but kdb do

Re: [Kgdb-bugreport] [PATCH -next] kdb: Use newer api for tasklist scanning

2020-09-07 Thread Davidlohr Bueso
On Mon, 07 Sep 2020, Daniel Thompson wrote: No objections to the change but kdb doesn't use tsk->thread_group, it uses do_each_thread/while_each_thread. Can we change this to say that is osbsolete and racy to use while_each_thread() (that's pretty much what the description of the patch that intr

[Kgdb-bugreport] [PATCH v2] kdb: Use newer api for tasklist scanning

2020-09-07 Thread Davidlohr Bueso
This kills using the do_each_thread/while_each_thread combo to iterate all threads and uses for_each_process_thread() instead, maintaining semantics. while_each_thread() is ultimately racy and deprecated; although in this particular case there is no concurrency so it doesn't matter. Still lets tri