Re: [Kgdb-bugreport] [PATCH 5/5] kgdbts: unify/generalize gdb breakpoint adjustment

2011-06-18 Thread Arnd Bergmann
On Monday 18 April 2011, Paul Mundt wrote: > On Thu, Apr 14, 2011 at 02:01:35AM -0400, Mike Frysinger wrote: > > The Blackfin arch, like the x86 arch, needs to adjust the PC manually > > after a breakpoint is hit as normally this is handled by the remote gdb. > > However, rather than starting anoth

Re: [Kgdb-bugreport] [PATCH 5/5] kgdbts: unify/generalize gdb breakpoint adjustment

2011-06-18 Thread Arnd Bergmann
On Thursday 16 June 2011 22:07:55 Mike Frysinger wrote: > On Thu, Jun 16, 2011 at 16:06, Mike Frysinger wrote: > > On Thu, Jun 16, 2011 at 11:07, Arnd Bergmann wrote: > >> This patch is causing build problems now, because the > >> instruction_pointer_set() > >>

Re: [Kgdb-bugreport] [PATCH] kdb: Change timespec to use timespec64

2018-01-25 Thread Arnd Bergmann
On Thu, Jan 25, 2018 at 9:05 AM, Baolin Wang wrote: > @@ -2554,7 +2554,7 @@ static int kdb_summary(int argc, const char **argv) > kdb_printf("domainname %s\n", init_uts_ns.name.domainname); > kdb_printf("ccversion %s\n", __stringify(CCVERSION)); > > - now = __current_kernel_

Re: [Kgdb-bugreport] [PATCH] kdb: Change timespec to use timespec64

2018-01-25 Thread Arnd Bergmann
On Thu, Jan 25, 2018 at 3:49 PM, Jason Wessel wrote: > On 01/25/2018 05:38 AM, Daniel Thompson wrote: >> >> On Thu, Jan 25, 2018 at 05:18:54PM +0800, Baolin Wang wrote: >>> >>> On 25 January 2018 at 16:55, Arnd Bergmann wrote: >>>> >>>>

Re: [Kgdb-bugreport] [PATCH] kdb: use ktime_get_seconds() instead of ktime_get_ts()

2018-01-26 Thread Arnd Bergmann
On Fri, Jan 26, 2018 at 4:03 AM, Baolin Wang wrote: > The kdb code will print the monotonic time by ktime_get_ts(), but > the ktime_get_ts() will be protected by a sequence lock, that will > introduce one deadlock risk if the lock was already held in the > context from which we entered the debugge

Re: [Kgdb-bugreport] [PATCH] kdb: use ktime_get_seconds() instead of ktime_get_ts()

2018-01-26 Thread Arnd Bergmann
On Fri, Jan 26, 2018 at 3:20 PM, Baolin Wang wrote: > On 26 January 2018 at 22:00, Daniel Thompson > wrote: >> On Fri, Jan 26, 2018 at 10:21:58AM +0100, Arnd Bergmann wrote: >>> On Fri, Jan 26, 2018 at 4:03 AM, Baolin Wang wrote: >>> >>> Using ktime_get_s

Re: [Kgdb-bugreport] [PATCH v2] kdb: use ktime_get_mono_fast_ns() instead of ktime_get_ts()

2018-01-30 Thread Arnd Bergmann
entered the debugger. > > Thus we can use the ktime_get_mono_fast_ns() to get the monotonic > time, which is NMI safe access to clock monotonic. Moreover we can > remove the 'struct timespec', which is not y2038 safe. > > Signed-off-by:

[Kgdb-bugreport] [PATCH] kdb: use memmove instead of overlapping memcpy

2018-02-02 Thread Arnd Bergmann
linux/string.h:353:9: error: '__builtin_memcpy' accessing 792 bytes at offsets 0 and 8 overlaps 784 bytes at offset 8 [-Werror=restrict] return __builtin_memcpy(p, q, size); Signed-off-by: Arnd Bergmann --- kernel/debug/kdb/kdb_support.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

Re: [Kgdb-bugreport] [PATCH] kdb: prefer strlcpy to strncpy

2018-05-29 Thread Arnd Bergmann
On Tue, May 29, 2018 at 7:57 AM, Nick Desaulniers wrote: > Fixes stringop-truncation and stringop-overflow warnings from gcc-8. That patch description should really explain whether gcc is right or not. What's the worst thing that could happen here? I would also recommend citing the exact warning

[Kgdb-bugreport] [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Arnd Bergmann
From: Arnd Bergmann gcc-11 starts warning about misleading indentation inside of macros: drivers/misc/kgdbts.c: In function ‘kgdbts_break_test’: drivers/misc/kgdbts.c:103:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation] 103 | if (verbose >

Re: [Kgdb-bugreport] [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 6:03 PM Daniel Thompson wrote: > > > Acked-by: Daniel Thompson > > Which tree do you want to merge this one though? I've got nothing else > pending for this file so I am very relaxed about the route... I don't plan to merge any of the build fixes through my own tree. If y

Re: [Kgdb-bugreport] [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 6:07 PM Doug Anderson wrote: > On Mon, Mar 22, 2021 at 9:43 AM Arnd Bergmann wrote: > > > > -#define v1printk(a...) do { \ > > - if (verbose) \ > > - printk(KERN_INFO a); \ > > - } while (0) > > -#defi

Re: [Kgdb-bugreport] [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Arnd Bergmann
On Mon, Mar 22, 2021 at 9:14 PM Jason Wessel wrote: > > The original board this was developed with was a 32bit eeepc. > > The intent was that when v2printk() was called for a verbose > 1 > condition the touch_nmi_watchdog() was called. The test case > where a whole lot of single steps are execut

Re: [Kgdb-bugreport] [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-03-31 Thread Arnd Bergmann
On Thu, Mar 31, 2022 at 1:49 PM Greg KH wrote: > > + > > +static irqreturn_t a64fx_diag_handler(int irq, void *dev_id) > > +{ > > + handle_sysrq('c'); > > > Why is this calling this sysrq call? From an interrupt? Why? > > And you are hard-coding "c", are you sure? This is an actual sysrq dr

Re: [Kgdb-bugreport] [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-04-08 Thread Arnd Bergmann
On Fri, Apr 8, 2022 at 3:32 PM Daniel Thompson wrote: > On Thu, Mar 31, 2022 at 05:44:55PM +0200, Arnd Bergmann wrote: > > There is some prior art for this sort of feature. AFAICT SGI UV has a > similar mechanism that can send an NMI-with-no-side-channel to the > kernel. The corre

Re: [Kgdb-bugreport] [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-04-08 Thread Arnd Bergmann
On Fri, Apr 8, 2022 at 4:21 PM Greg KH wrote: > > On Fri, Apr 08, 2022 at 04:17:16PM +0200, Arnd Bergmann wrote: > > On Fri, Apr 8, 2022 at 3:32 PM Daniel Thompson > > wrote: > > > On Thu, Mar 31, 2022 at 05:44:55PM +0200, Arnd Bergmann wrote: > > > > >

Re: [Kgdb-bugreport] [PATCH v3 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-04-28 Thread Arnd Bergmann
On Thu, Apr 28, 2022 at 4:15 AM hasegawa-hit...@fujitsu.com wrote: > > Hi Greg, Arnd, and Daniel, > > > I understand that it is not appropriate to hardcode c. > > How about using __setup() to add a new kernel parameter and allow the admin > > to specify the sysrq command when booting? > > I have r

Re: [Kgdb-bugreport] [PATCH v4 1/1] soc: fujitsu: Add A64FX diagnostic interrupt driver

2022-05-13 Thread Arnd Bergmann
On Wed, May 11, 2022 at 8:50 AM Greg KH wrote: > > --- a/drivers/soc/Makefile > > +++ b/drivers/soc/Makefile > > @@ -12,6 +12,7 @@ obj-$(CONFIG_SOC_CANAAN)+= canaan/ > > obj-$(CONFIG_ARCH_DOVE) += dove/ > > obj-$(CONFIG_MACH_DOVE) += dove/ > > obj-y

[Kgdb-bugreport] [PATCH] kdb: include kdb_private.h for function prototypes

2023-05-17 Thread Arnd Bergmann
From: Arnd Bergmann The kdb_kbd_cleanup_state() is called from another file through the kdb_private.h file, but that is not included before the definition, causing a W=1 warning: kernel/debug/kdb/kdb_keyboard.c:198:6: error: no previous prototype for 'kdb_kbd_cleanup_state' [-Werr

[Kgdb-bugreport] [PATCH] kdb: include header in signal handling code

2023-05-17 Thread Arnd Bergmann
From: Arnd Bergmann kdb_send_sig() is defined in the signal code and called from kdb, but the declaration is part of the kdb internal code. Include this from signal.c as well to avoid the warning: kernel/signal.c:4789:6: error: no previous prototype for 'kdb_send_sig' [-Werr

Re: [Kgdb-bugreport] [PATCH] kdb: include header in signal handling code

2023-06-30 Thread Arnd Bergmann
On Fri, Jun 30, 2023, at 17:24, Daniel Thompson wrote: > On Wed, May 17, 2023 at 02:54:09PM +0200, Arnd Bergmann wrote: >> diff --git a/kernel/signal.c b/kernel/signal.c >> index 8f6330f0e9ca..d38df14f71ac 100644 >> --- a/kernel/signal.c >> +++ b/kernel/signal.c &g